From df5901fdc58565448629a9bfd5ccecc1c5a5b349 Mon Sep 17 00:00:00 2001
From: obscuren <geffobscura@gmail.com>
Date: Thu, 19 Mar 2015 22:45:03 +0100
Subject: [PATCH] Removed more casts

---
 cmd/ethtest/main.go |  3 +--
 common/big.go       |  4 ++--
 vm/common.go        |  9 +++++----
 vm/context.go       |  4 ----
 vm/vm.go            | 18 ++++++------------
 5 files changed, 14 insertions(+), 24 deletions(-)

diff --git a/cmd/ethtest/main.go b/cmd/ethtest/main.go
index ee6bcc5408..f2f7d27f37 100644
--- a/cmd/ethtest/main.go
+++ b/cmd/ethtest/main.go
@@ -24,7 +24,6 @@ package main
 import (
 	"bytes"
 	"encoding/json"
-	"fmt"
 	"io"
 	"io/ioutil"
 	"log"
@@ -210,7 +209,7 @@ func RunVmTest(r io.Reader) (failed int) {
 		}
 
 		if failed == 1 {
-			fmt.Println(string(statedb.Dump()))
+			helper.Log.Infoln(string(statedb.Dump()))
 		}
 
 		logger.Flush()
diff --git a/common/big.go b/common/big.go
index 750b28f85a..8fe9d8bef5 100644
--- a/common/big.go
+++ b/common/big.go
@@ -104,7 +104,7 @@ func BigCopy(src *big.Int) *big.Int {
 //
 // Returns the maximum size big integer
 func BigMax(x, y *big.Int) *big.Int {
-	if x.Cmp(y) <= 0 {
+	if x.Cmp(y) < 0 {
 		return y
 	}
 
@@ -115,7 +115,7 @@ func BigMax(x, y *big.Int) *big.Int {
 //
 // Returns the minimum size big integer
 func BigMin(x, y *big.Int) *big.Int {
-	if x.Cmp(y) >= 0 {
+	if x.Cmp(y) > 0 {
 		return y
 	}
 
diff --git a/vm/common.go b/vm/common.go
index 5441a4ac50..8d8f4253fc 100644
--- a/vm/common.go
+++ b/vm/common.go
@@ -73,9 +73,10 @@ func toValue(val *big.Int) interface{} {
 	return val
 }
 
-func getData(data []byte, start, size uint64) []byte {
-	x := uint64(math.Min(float64(start), float64(len(data))))
-	y := uint64(math.Min(float64(x+size), float64(len(data))))
+func getData(data []byte, start, size *big.Int) []byte {
+	dlen := big.NewInt(int64(len(data)))
 
-	return common.RightPadBytes(data[x:y], int(size))
+	s := common.BigMin(start, dlen)
+	e := common.BigMin(new(big.Int).Add(s, size), dlen)
+	return common.RightPadBytes(data[s.Uint64():e.Uint64()], int(size.Uint64()))
 }
diff --git a/vm/context.go b/vm/context.go
index ea70f23763..e73199b779 100644
--- a/vm/context.go
+++ b/vm/context.go
@@ -64,10 +64,6 @@ func (c *Context) GetRangeValue(x, size uint64) []byte {
 	return common.RightPadBytes(c.Code[x:y], int(size))
 }
 
-func (c *Context) GetCode(x, size uint64) []byte {
-	return getData(c.Code, x, size)
-}
-
 func (c *Context) Return(ret []byte) []byte {
 	// Return the remaining gas to the caller
 	c.caller.ReturnGas(c.Gas, c.Price)
diff --git a/vm/vm.go b/vm/vm.go
index 123da6b035..7400a48c40 100644
--- a/vm/vm.go
+++ b/vm/vm.go
@@ -445,14 +445,11 @@ func (self *Vm) Run(context *Context, callData []byte) (ret []byte, err error) {
 				cOff = stack.pop()
 				l    = stack.pop()
 			)
-			var data []byte
-			if cOff.Cmp(big.NewInt(int64(len(callData)))) <= 0 {
-				data = getData(callData, cOff.Uint64(), l.Uint64())
-			}
+			data := getData(callData, cOff, l)
 
 			mem.Set(mOff.Uint64(), l.Uint64(), data)
 
-			self.Printf(" => [%v, %v, %v] %x", mOff, cOff, l, data)
+			self.Printf(" => [%v, %v, %v]", mOff, cOff, l)
 		case CODESIZE, EXTCODESIZE:
 			var code []byte
 			if op == EXTCODESIZE {
@@ -482,10 +479,7 @@ func (self *Vm) Run(context *Context, callData []byte) (ret []byte, err error) {
 				l    = stack.pop()
 			)
 
-			var codeCopy []byte
-			if cOff.Cmp(big.NewInt(int64(len(code)))) <= 0 {
-				codeCopy = getData(code, cOff.Uint64(), l.Uint64())
-			}
+			codeCopy := getData(code, cOff, l)
 
 			mem.Set(mOff.Uint64(), l.Uint64(), codeCopy)
 
@@ -585,11 +579,11 @@ func (self *Vm) Run(context *Context, callData []byte) (ret []byte, err error) {
 
 			self.Printf(" => 0x%x", val)
 		case MSTORE8:
-			off, val := stack.pop(), stack.pop()
+			off, val := stack.pop().Int64(), stack.pop().Int64()
 
-			mem.store[off.Int64()] = byte(val.Int64() & 0xff)
+			mem.store[off] = byte(val & 0xff)
 
-			self.Printf(" => [%v] 0x%x", off, val)
+			self.Printf(" => [%v] 0x%x", off, mem.store[off])
 		case SLOAD:
 			loc := common.BigToHash(stack.pop())
 			val := common.Bytes2Big(statedb.GetState(context.Address(), loc))