From e64dfdd243a48893e5c0b8d86b63277cb7d9e909 Mon Sep 17 00:00:00 2001
From: Felix Lange <fjl@twurst.com>
Date: Thu, 12 Sep 2024 17:58:59 +0200
Subject: [PATCH] core/types: update deposit test

---
 core/types/deposit_test.go | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/core/types/deposit_test.go b/core/types/deposit_test.go
index ed2e18445d..3d1fc8edd4 100644
--- a/core/types/deposit_test.go
+++ b/core/types/deposit_test.go
@@ -17,8 +17,7 @@
 package types
 
 import (
-	"encoding/binary"
-	"reflect"
+	"bytes"
 	"testing"
 
 	"github.com/ethereum/go-ethereum/accounts/abi"
@@ -71,23 +70,24 @@ func FuzzUnpackIntoDeposit(f *testing.F) {
 		copy(sig[:], s)
 		copy(index[:], i)
 
-		want := Deposit{
-			PublicKey:             pubkey,
-			WithdrawalCredentials: wxCred,
-			Amount:                binary.LittleEndian.Uint64(amount[:]),
-			Signature:             sig,
-			Index:                 binary.LittleEndian.Uint64(index[:]),
-		}
-		out, err := depositABI.Pack("DepositEvent", want.PublicKey[:], want.WithdrawalCredentials[:], amount[:], want.Signature[:], index[:])
+		var enc []byte
+		enc = append(enc, depositRequestType)
+		enc = append(enc, pubkey[:]...)
+		enc = append(enc, wxCred[:]...)
+		enc = append(enc, amount[:]...)
+		enc = append(enc, sig[:]...)
+		enc = append(enc, index[:]...)
+
+		out, err := depositABI.Pack("DepositEvent", pubkey[:], wxCred[:], amount[:], sig[:], index[:])
 		if err != nil {
 			t.Fatalf("error packing deposit: %v", err)
 		}
-		got, err := UnpackIntoDeposit(out[4:])
+		got, err := DepositLogToRequest(out[4:])
 		if err != nil {
 			t.Errorf("error unpacking deposit: %v", err)
 		}
-		if !reflect.DeepEqual(want, *got) {
-			t.Errorf("roundtrip failed: want %v, got %v", want, got)
+		if !bytes.Equal(enc, got) {
+			t.Errorf("roundtrip failed: want %x, got %x", enc, got)
 		}
 	})
 }