mirror of https://github.com/ethereum/go-ethereum
ethclient: add RevertErrorData function and example (#30669)
Here I'm adding a new helper function that extracts the revert reason of a contract call. Unfortunately, this aspect of the API is underspecified. See these spec issues for more detail: - https://github.com/ethereum/execution-apis/issues/232 - https://github.com/ethereum/execution-apis/issues/463 - https://github.com/ethereum/execution-apis/issues/523 The function added here only works with Geth-like servers that return error code `3`. We will not be able to support all possible servers. However, if there is a specific server implementation that makes it possible to extract the same info, we could add it in the same function as well. --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>pull/30661/merge
Felix Lange
2 weeks ago
committed by
GitHub
parent
4bac6e669e
commit
e92e22a7cf
@ -0,0 +1,35 @@ |
||||
// Copyright 2024 The go-ethereum Authors
|
||||
// This file is part of the go-ethereum library.
|
||||
//
|
||||
// The go-ethereum library is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU Lesser General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// The go-ethereum library is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU Lesser General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU Lesser General Public License
|
||||
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package ethclient_test |
||||
|
||||
import ( |
||||
"github.com/ethereum/go-ethereum/node" |
||||
) |
||||
|
||||
var exampleNode *node.Node |
||||
|
||||
// launch example server
|
||||
func init() { |
||||
config := &node.Config{ |
||||
HTTPHost: "127.0.0.1", |
||||
} |
||||
n, _, err := newTestBackend(config) |
||||
if err != nil { |
||||
panic("can't launch node: " + err.Error()) |
||||
} |
||||
exampleNode = n |
||||
} |
||||
@ -0,0 +1,153 @@ |
||||
// Copyright 2016 The go-ethereum Authors
|
||||
// This file is part of the go-ethereum library.
|
||||
//
|
||||
// The go-ethereum library is free software: you can redistribute it and/or modify
|
||||
// it under the terms of the GNU Lesser General Public License as published by
|
||||
// the Free Software Foundation, either version 3 of the License, or
|
||||
// (at your option) any later version.
|
||||
//
|
||||
// The go-ethereum library is distributed in the hope that it will be useful,
|
||||
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
// GNU Lesser General Public License for more details.
|
||||
//
|
||||
// You should have received a copy of the GNU Lesser General Public License
|
||||
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
||||
|
||||
package ethclient |
||||
|
||||
import ( |
||||
"errors" |
||||
"math/big" |
||||
"reflect" |
||||
"testing" |
||||
|
||||
"github.com/ethereum/go-ethereum" |
||||
"github.com/ethereum/go-ethereum/common" |
||||
) |
||||
|
||||
func TestToFilterArg(t *testing.T) { |
||||
blockHashErr := errors.New("cannot specify both BlockHash and FromBlock/ToBlock") |
||||
addresses := []common.Address{ |
||||
common.HexToAddress("0xD36722ADeC3EdCB29c8e7b5a47f352D701393462"), |
||||
} |
||||
blockHash := common.HexToHash( |
||||
"0xeb94bb7d78b73657a9d7a99792413f50c0a45c51fc62bdcb08a53f18e9a2b4eb", |
||||
) |
||||
|
||||
for _, testCase := range []struct { |
||||
name string |
||||
input ethereum.FilterQuery |
||||
output interface{} |
||||
err error |
||||
}{ |
||||
{ |
||||
"without BlockHash", |
||||
ethereum.FilterQuery{ |
||||
Addresses: addresses, |
||||
FromBlock: big.NewInt(1), |
||||
ToBlock: big.NewInt(2), |
||||
Topics: [][]common.Hash{}, |
||||
}, |
||||
map[string]interface{}{ |
||||
"address": addresses, |
||||
"fromBlock": "0x1", |
||||
"toBlock": "0x2", |
||||
"topics": [][]common.Hash{}, |
||||
}, |
||||
nil, |
||||
}, |
||||
{ |
||||
"with nil fromBlock and nil toBlock", |
||||
ethereum.FilterQuery{ |
||||
Addresses: addresses, |
||||
Topics: [][]common.Hash{}, |
||||
}, |
||||
map[string]interface{}{ |
||||
"address": addresses, |
||||
"fromBlock": "0x0", |
||||
"toBlock": "latest", |
||||
"topics": [][]common.Hash{}, |
||||
}, |
||||
nil, |
||||
}, |
||||
{ |
||||
"with negative fromBlock and negative toBlock", |
||||
ethereum.FilterQuery{ |
||||
Addresses: addresses, |
||||
FromBlock: big.NewInt(-1), |
||||
ToBlock: big.NewInt(-1), |
||||
Topics: [][]common.Hash{}, |
||||
}, |
||||
map[string]interface{}{ |
||||
"address": addresses, |
||||
"fromBlock": "pending", |
||||
"toBlock": "pending", |
||||
"topics": [][]common.Hash{}, |
||||
}, |
||||
nil, |
||||
}, |
||||
{ |
||||
"with blockhash", |
||||
ethereum.FilterQuery{ |
||||
Addresses: addresses, |
||||
BlockHash: &blockHash, |
||||
Topics: [][]common.Hash{}, |
||||
}, |
||||
map[string]interface{}{ |
||||
"address": addresses, |
||||
"blockHash": blockHash, |
||||
"topics": [][]common.Hash{}, |
||||
}, |
||||
nil, |
||||
}, |
||||
{ |
||||
"with blockhash and from block", |
||||
ethereum.FilterQuery{ |
||||
Addresses: addresses, |
||||
BlockHash: &blockHash, |
||||
FromBlock: big.NewInt(1), |
||||
Topics: [][]common.Hash{}, |
||||
}, |
||||
nil, |
||||
blockHashErr, |
||||
}, |
||||
{ |
||||
"with blockhash and to block", |
||||
ethereum.FilterQuery{ |
||||
Addresses: addresses, |
||||
BlockHash: &blockHash, |
||||
ToBlock: big.NewInt(1), |
||||
Topics: [][]common.Hash{}, |
||||
}, |
||||
nil, |
||||
blockHashErr, |
||||
}, |
||||
{ |
||||
"with blockhash and both from / to block", |
||||
ethereum.FilterQuery{ |
||||
Addresses: addresses, |
||||
BlockHash: &blockHash, |
||||
FromBlock: big.NewInt(1), |
||||
ToBlock: big.NewInt(2), |
||||
Topics: [][]common.Hash{}, |
||||
}, |
||||
nil, |
||||
blockHashErr, |
||||
}, |
||||
} { |
||||
t.Run(testCase.name, func(t *testing.T) { |
||||
output, err := toFilterArg(testCase.input) |
||||
if (testCase.err == nil) != (err == nil) { |
||||
t.Fatalf("expected error %v but got %v", testCase.err, err) |
||||
} |
||||
if testCase.err != nil { |
||||
if testCase.err.Error() != err.Error() { |
||||
t.Fatalf("expected error %v but got %v", testCase.err, err) |
||||
} |
||||
} else if !reflect.DeepEqual(testCase.output, output) { |
||||
t.Fatalf("expected filter arg %v but got %v", testCase.output, output) |
||||
} |
||||
}) |
||||
} |
||||
} |
||||
Loading…
Reference in new issue