e015c1116f
ethdb: remove unnecessary function wrapper ( #29888 )
6 months ago
06263b1b35
all: fix typos in comments ( #29873 )
...
fix using `a` & `the` simutaneously
6 months ago
3e896c875a
ethdb/pebble: fix pebble metrics registration ( #29699 )
...
ethdb/pebble: use GetOrRegister instead of NewRegistered when creating metrics
7 months ago
27de7dec65
ethdb/pebble: print warning log if pebble performance degrades ( #29478 )
7 months ago
66e1a6ef49
go.mod: bump pebble db to official release ( #29038 )
...
bump pebble
9 months ago
55b483d82a
ethdb/pebble: remove a dependency ( #28627 )
...
The dependency was not really used anyway, so we can get rid of it.
Co-authored-by: Felix Lange <fjl@twurst.com>
12 months ago
6489a0dd1f
ethdb/pebble: don't double-close iterator inside pebbleIterator ( #28566 )
...
Adds 'released' flag to pebbleIterator to avoid double closing cockroachdb/pebble.Iterator as it is an invalid operation.
Fixes #28565
1 year ago
f7dde2a96c
ethdb/pebble: add `Errorf` function to panicLogger ( #28491 )
...
cockroachdb/pebble@422dce9 added Errorf to the Logger interface, this change makes it possible to compile geth with that version of pebble by adding the corresponding method to panicLogger.
1 year ago
f4ac548619
ethdb/pebble: cap memory table size as maxMemTableSize-1 ( #28444 )
1 year ago
509a64ffb9
cmd, core, ethdb: enable Pebble on 32 bits and OpenBSD too ( #28335 )
...
* cmd, core, ethdb: enable Pebble on 32 bits and OpenBSD too
* ethdb/pebble: use Pebble's internal constant calculation
1 year ago
7776a3214a
ethdb/pebble: add level file metrics ( #28271 )
1 year ago
966e50bddb
ethdb/pebble: luv you linter
1 year ago
22dcb7a77b
ethdb/pebble: upgrade pebble to master (aa077af62593) ( #28070 )
...
* ethdb/pebble: upgrade pebble
* ethdb/pebble, go.mod: update pebble to master (aa077af62593)
---------
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
1 year ago
f988b2332e
ethdb, internal/ethapi: support exposing Pebble stats too, beside LevelDB ( #28224 )
...
ethdb, internal/ethapi: support exposing Pebble stats too, besinde LevelDB
1 year ago
f0f8703bf2
core/rawdb, ethdb/pebble: avoid fsync db in tests ( #27836 )
...
Adds an option to disable fsync for database operations.
This is to make tests faster.
1 year ago
4b90c4488d
ethdb/pebble: use sync mode for pebble writes ( #27615 )
1 year ago
713fc8bbe6
ethdb/pebble: fsync for batch writes ( #27522 )
...
This is likely the culprit behind several data corruption issues, e.g. where data has been
written to the freezer, but the deletion from pebble does not go through due to process
crash.
1 year ago
33fdd030b1
ethdb/pebble: fix NewBatchWithSize to set db ( #27350 )
2 years ago
99394adcb8
ethdb/pebble: prevent shutdown-panic ( #27238 )
...
One difference between pebble and leveldb is that the latter returns error when performing Get on a closed database, the former does a panic. This may be triggered during shutdown (see #27237 )
This PR changes the pebble driver so we check that the db is not closed already, for several operations. It also adds tests to the db test-suite, so the previously implicit assumption of "not panic:ing at ops on closed database" is covered by tests.
2 years ago
d3ece3a07c
cmd/utils, node: switch to Pebble as the default db if none exists ( #27136 )
...
* cmd/utils, node: switch to Pebble as the default db if none exists
* node: fall back to LevelDB on platforms not supporting Pebble
* core/rawdb, node: default to Pebble at the node level
* cmd/geth: fix some tests explicitly using leveldb
* ethdb/pebble: allow double closes, makes tests simpler
2 years ago
50317bdace
ethdb/pebble: use atomic type ( #27014 )
2 years ago
19f74fa3c0
core/rawdb, ethdb/pebble: disable pebble on openbsd ( #26801 )
2 years ago
2bb622ce40
ethdb/pebble: fix max memorytable size ( #26776 )
2 years ago
98b0ea62b5
ethdb/pebble: fix range compaction ( #26771 )
...
* ethdb/pebble: fix range compaction
* ethdb/pebble: add comment
2 years ago
5967a2290a
ethdb/pebble: Fix `MemTableStopWritesThreshold` ( #26692 )
...
MemTableStopWritesThreshold was set to the max size of all memtables before blocking writing but should be set to the max number of memtables. This is documented [here](https://github.com/cockroachdb/pebble/blob/master/options.go#L738-L742 ).
2 years ago
0ea65d4020
ethdb: add benchmark test suite ( #26659 )
2 years ago
da3c974c36
ethdb/pebble: fix nil callbacks ( #26650 )
2 years ago
ed51b8c5d3
ethdb: pebble backend (64bit platforms only) ( #26517 )
...
* ethdb: use pebble
Co-authored-by: Gary Rong <garyrong0905@gmail.com>
foo
update
* apply suggested changes
* flags: go format
node: fix ddir lookup mistake
accounts/abi/bind: fix go.mod replacement for generated binding
deps: update pebble + with fix 32-bit build
* ethdb/pebble: respect max memtable size
* core/rawdb, ethdb: enable pebble on non-32bit platforms only
* core/rawdb: fix build tags, fix some review concerns
* core/rawdb: refactor methods for database opening
* core/rawdb: remove erroneous build tag
* cmd/geth: fix the flag default handling + testcase
* cmd/geth: improve testing regarding custom backends
* ethdb/pebble, deps: update pebble dependency
* core/rawdb: replace method with Open
* ethdb/pebble: several updates for pebble (#49 )
* ethdb/pebble: fix size count in batch
* ethdb/pebble: disable seek compaction
* ethdb/pebble: more fixes
* ethdb, core, cmd: polish and fixes (#50 )
* cmd/utils, core/rawdb, ethdb/pebble: address some review concerns
* Update flags.go
* ethdb/pebble: minor refactors
* ethdb/pebble: avoid copy on batch replay
* ethdb: fix compilation flaw
* cmd: fix test fail due to mismatching error message
* cmd/geth, node: rename backingdb to db.engine
---------
Co-authored-by: Jared Wasinger <j-wasinger@hotmail.com>
Co-authored-by: rjl493456442 <garyrong0905@gmail.com>
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
2 years ago
SuiYuan
PolyMa
Maciej Kulawik
rjl493456442
Devon Bear
Marius van der Wijden
Jim McDonald
Péter Szilágyi
Martin Holst Swende
s7v7nislands
Patrick O'Grady