f8d8b56b28
core/vm: optimize copy-less data retrievals
7 years ago
5f7826270c
all: unify big.Int zero checks, use common/math in more places ( #3716 )
...
* common/math: optimize PaddedBigBytes, use it more
name old time/op new time/op delta
PaddedBigBytes-8 71.1ns ± 5% 46.1ns ± 1% -35.15% (p=0.000 n=20+19)
name old alloc/op new alloc/op delta
PaddedBigBytes-8 48.0B ± 0% 32.0B ± 0% -33.33% (p=0.000 n=20+20)
* all: unify big.Int zero checks
Various checks were in use. This commit replaces them all with Int.Sign,
which is cheaper and less code.
eg templates:
func before(x *big.Int) bool { return x.BitLen() == 0 }
func after(x *big.Int) bool { return x.Sign() == 0 }
func before(x *big.Int) bool { return x.BitLen() > 0 }
func after(x *big.Int) bool { return x.Sign() != 0 }
func before(x *big.Int) int { return x.Cmp(common.Big0) }
func after(x *big.Int) int { return x.Sign() }
* common/math, crypto/secp256k1: make ReadBits public in package math
8 years ago
5c8fe28b72
common: move big integer math to common/math ( #3699 )
...
* common: remove CurrencyToString
Move denomination values to params instead.
* common: delete dead code
* common: move big integer operations to common/math
This commit consolidates all big integer operations into common/math and
adds tests and documentation.
There should be no change in semantics for BigPow, BigMin, BigMax, S256,
U256, Exp and their behaviour is now locked in by tests.
The BigD, BytesToBig and Bytes2Big functions don't provide additional
value, all uses are replaced by new(big.Int).SetBytes().
BigToBytes is now called PaddedBigBytes, its minimum output size
parameter is now specified as the number of bytes instead of bits. The
single use of this function is in the EVM's MSTORE instruction.
Big and String2Big are replaced by ParseBig, which is slightly stricter.
It previously accepted leading zeros for hexadecimal inputs but treated
decimal inputs as octal if a leading zero digit was present.
ParseUint64 is used in places where String2Big was used to decode a
uint64.
The new functions MustParseBig and MustParseUint64 are now used in many
places where parsing errors were previously ignored.
* common: delete unused big integer variables
* accounts/abi: replace uses of BytesToBig with use of encoding/binary
* common: remove BytesToBig
* common: remove Bytes2Big
* common: remove BigTrue
* cmd/utils: add BigFlag and use it for error-checked integer flags
While here, remove environment variable processing for DirectoryFlag
because we don't use it.
* core: add missing error checks in genesis block parser
* common: remove String2Big
* cmd/evm: use utils.BigFlag
* common/math: check for 256 bit overflow in ParseBig
This is supposed to prevent silent overflow/truncation of values in the
genesis block JSON. Without this check, a genesis block that set a
balance larger than 256 bits would lead to weird behaviour in the VM.
* cmd/utils: fixup import
8 years ago
c12f4df910
params: core, core/vm, miner: 64bit gas instructions
...
Reworked the EVM gas instructions to use 64bit integers rather than
arbitrary size big ints. All gas operations, be it additions,
multiplications or divisions, are checked and guarded against 64 bit
integer overflows.
In additon, most of the protocol paramaters in the params package have
been converted to uint64 and are now constants rather than variables.
* common/math: added overflow check ops
* core: vmenv, env renamed to evm
* eth, internal/ethapi, les: unmetered eth_call and cancel methods
* core/vm: implemented big.Int pool for evm instructions
* core/vm: unexported intPool methods & verification methods
* core/vm: added memoryGasCost overflow check and test
8 years ago
57f4e90257
Revert "params: core, core/vm, miner: 64bit gas instructions ( #3514 )"
...
This reverts commit 8b57c49490
8 years ago
8b57c49490
params: core, core/vm, miner: 64bit gas instructions ( #3514 )
...
Reworked the EVM gas instructions to use 64bit integers rather than
arbitrary size big ints. All gas operations, be it additions,
multiplications or divisions, are checked and guarded against 64 bit
integer overflows.
In additon, most of the protocol paramaters in the params package have
been converted to uint64 and are now constants rather than variables.
* common/math: added overflow check ops
* core: vmenv, env renamed to evm
* eth, internal/ethapi, les: unmetered eth_call and cancel methods
* core/vm: implemented big.Int pool for evm instructions
* core/vm: unexported intPool methods & verification methods
* core/vm: added memoryGasCost overflow check and test
8 years ago
14013372ae
core: Added EVM configuration options
...
The EVM is now initialised with an additional configured object that
allows you to turn on debugging options.
9 years ago
342ae7ce7d
core, core/vm, tests: changed the initialisation behaviour of the EVM
...
The EVM was previously initialised and created for every CALL, CALLCODE,
DELEGATECALL and CREATE. This PR changes this behaviour so that the same
EVM can be used through the session and beyond as long as the
Environment sticks around.
9 years ago
15780ead07
core/vm, rpc/api: renamed to debug.replayTransaction, migrated to new RPC, integrated feedback
...
Integrated code review suggestions
Integrated last review comments
9 years ago
7c7692933c
cmd/geth, cmd/utils, core, rpc: renamed to blockchain
...
* Renamed ChainManager to BlockChain
* Checkpointing is no longer required and never really properly worked
when the state was corrupted.
9 years ago
361082ec4b
cmd/evm, core/vm, test: refactored VM and core
...
* Moved `vm.Transfer` to `core` package and changed execution to call
`env.Transfer` instead of `core.Transfer` directly.
* core/vm: byte code VM moved to jump table instead of switch
* Moved `vm.Transfer` to `core` package and changed execution to call
`env.Transfer` instead of `core.Transfer` directly.
* Byte code VM now shares the same code as the JITVM
* Renamed Context to Contract
* Changed initialiser of state transition & unexported methods
* Removed the Execution object and refactor `Call`, `CallCode` &
`Create` in to their own functions instead of being methods.
* Removed the hard dep on the state for the VM. The VM now
depends on a Database interface returned by the environment. In the
process the core now depends less on the statedb by usage of the env
* Moved `Log` from package `core/state` to package `core/vm`.
9 years ago
bfbcfbe4a9
all: fix license headers one more time
...
I forgot to update one instance of "go-ethereum" in commit 3f047be5a
9 years ago
3f047be5aa
all: update license headers to distiguish GPL/LGPL
...
All code outside of cmd/ is licensed as LGPL. The headers
now reflect this by calling the whole work "the go-ethereum library".
9 years ago
ea54283b30
all: update license information
10 years ago
a0e44e3281
basic glog
10 years ago
c26c8d3a44
Read most protocol params from common/params.json
...
* Add params package with exported variables generated from
github.com/ethereum/common/blob/master/params.json
* Use params package variables in applicable places
* Add check for minimum gas limit in validation of block's gas limit
* Remove common/params.json from go-ethereum to avoid
outdated version of it
10 years ago
368ebe63a9
Cleanup VM.
...
* CALLDATA use getData
* removed old context get range value
* removed casting big => int for some cases
* pc now big int #457
10 years ago
3b7e4173ce
Cleanup VM
10 years ago
0330077d76
moved state and vm to core
10 years ago
df5901fdc5
Removed more casts
10 years ago
cf45b939a0
fixed tests
10 years ago
4e181c5764
Moved gas
10 years ago
b523441361
Moved ethutil => common
10 years ago
f76cc6699e
Changed context and ADDMOD, MULMOD
...
* Cleaned up VM execution. VM run now takes a context
* ADDMOD/MULMOD - removed incorrect cast
10 years ago
ed84b58af5
Debug option for VM & command line flag
10 years ago
fa831206c6
Updated gast costs
10 years ago
ba0a758d8c
Quad mem & log changes
10 years ago
c1ef19bef9
quad mem
10 years ago
b383ff0b96
New gas prices model
10 years ago
8ccde784f9
Added (disabled) Jit validation
10 years ago
89c69a1d25
VmDebug => StdVm
10 years ago
ba225017c4
JitVm struct stub. Forwards calls to DebugVm.
10 years ago
f0ec751237
Updated tests
10 years ago
b99b2c446c
Precompiled contract & Depth change
...
* Added pre-compiled contract 0x04 (mem cpy)
* Changed depth error to return the gas instead of consuming
10 years ago
198cc69357
Gas corrections and vm fixes
10 years ago
4dbdcaecb1
Moved pre-compiled, moved depth check
...
* Depth check has been moved to the execution
* Pre compiled execution has been moved to the VM
* PrecompiledAddress has been renamed to PrecompiledAccount
10 years ago
25cf0c440c
Accidentally changed max depth during testing & committed
10 years ago
05fd1dafe2
additional log
10 years ago
0d57ca486a
Squashed commit of the following:
...
commit 779f25d36c68175386c0ad322fbb58f989f426184bc65d112912cfae18e3086caf3701e6c92673b94089b809fbcfdca622772e5175ef59f89d#42 from negedzuregal/fix
vmTest fix
commit f59f89d87668da13fe3e2e5175e818b5b9408e648e69fbfa9890f4f942e6c5e5228e0d9c0232a2b93ba0007e86d84be4fe07c8497ab76d2542c8497ab25776d25420e10be275e7571d42d1dd90868c1d42d1d7c6d90868c3071f38c8c6dbcf6b#39 from wanderer/develop
added test for max call depth on creation
commit 6dbcf6b0d66fc07a7f811f38c8c0a2279b284cd85ca1#38 from wanderer/develop
updated test 'jeff' in trietest.json
commit cd85ca17ed279b284c0d89675a76cae937#37 from wanderer/develop
Update trietest.json
commit 6cae937e5e89675a7153f1de1cc32f0c47f1de1cc97a32f0c47c68ab50e763da90d0#36 from wanderer/develop
converted back to arrary format
commit ab50e76652d06b79278f1e4a#35 from ethers/delOld
rename tests since they are valid opcodes that exist
commit 3da90d01f678f1e4a945d06b792cd0d434ecdcc32c06f34cc04b0c3b29ae63bcca76046e0310c1ea30c266c292776330c266caff2927763d68a0fa91b2b86092484fcba866https://github.com/ethereum/tests into develop
commit 60924843f0fcba866721a441074ba40afa72c82b6be83dd5a1c18b8ab2d366c2e1f9a9325866c2e1f6429a9325822e9b4e768e229374f46189527e9b4e768189527e5639b4e7689954669b5694ba567fedaaba185a567fedaa7aaba185ceb79d7cbffa782ae#32 from ethers/indexjs
updates needed per restructure
commit fa782aed9379d7cbfc4a91202741c1ba8d9120274a461c1ba8d161014d3703aebe53#31 from CJentzsch/develop
Restructered tests in folders in accordance to test suites
commit 3aebe532e58a0be2183983643addbc3930ca3a9a014d370b5d155d449be2c9eae764b8ad2a75ac58834c52af64c73a8a89d2b9a8c92422b48ae74af4bee0a4100c5050d20b315da65050d20b4d7516685ba35362#26 from wanderer/develop
Add a package.json for node.js
commit ba35362876751668571e0e687cee4778a78e2e6cb315da618b7a7e1980a76a3a#23 from ethers/fix22
numbers should be strings #22
commit 0a76a3a312#22
commit 1f67385f137a7e19839546eb6283ae8d38d62d10ed6eba7c8e2d72050db1dfe66cab3f45136231a67a961a67a96cffa4f5f45ffd6bc9#18 from CJentzsch/develop
CallToNameRegistratorOutOfGas balance correction
commit ffd6bc97ada4f5f459779d679779d67b8ca4f5f4522849a9f47b6d7cba#17 from CJentzsch/develop
Added A calls B calls A contracts
commit b6d7cba499865cb4049a9f47865cb4083d49a9f47aec3b0ec4394a493b#16 from CJentzsch/develop
corrected amount of used gas for CallToNameRegistratorOutOfGas
commit 94a493b0d972853c43b0ec4372853c43823b0ec436e4aec3252222068b#15 from CJentzsch/develop
corrected tests and different style for storage
commit 222068b9bac169653aec3252c1696531a6aec3252b8e25f9fd5e17a909#14 from CJentzsch/develop
corrected gas limit in vmSystemOperationsTest
commit e17a909f7033fcab525f9fd533fcab572725f9fd542a2d561a5373b0c48fa8d6cb8261a6cae166#13 from CJentzsch/develop
Added comprehensive EVM test suite. All commands are tested.
commit 6cae166f6f4ff906fbc25b3fee68069cdd21808328ed968b46ffbd5a35b554c14f1ff3d0af113aabcb8261a78b4513623da1e8cb5c221d98823c04b3357eb21e4d00cd0cce8fddfa3af45dd659f469a95e83ea8228a09aae0efeec9a044a174bb64615e0123f#10 from romanman/patch-1
Update vmtests.json
commit 5e0123fbe12b6da2f5f24bb646117dbba3898a33b309bba38980bda33b309d9950318217ca57fa655522ea0eb0a8c825bb76b69c74c6d8424e9ea3a602915fc3ac0e92edd3a00c2a5021e0dd83c818d13202714770ffb39345bc13d4a2257f378576dda2257f347178576dd3d3125839e84842e14ec356a329#5 from bkirwi/master
Fix invalid JSON (removed trailing comma) and add test names
commit 356a3296bc42e14ec54f4300197a74a0d01b1a0b6bc2fc740566bc366c31a93c#4 from ethers/master
fix file name that seems to have been a typo
commit c31a93c27a66bc3665c1ede5499da65131429abbf44a859331e1ae4ad4492b6c136ddacbccbf977cedbb8d445a0974edbb8d407e45a0974f6f15dd8fd5fd2a98#3 from autolycus/develop
Fixed formatting and added test cases
commit 5fd2a98fcb4ba150954e15dd8fd79433f80fef21e1f5e12abbf87ce15ad2c006ed4ffd510ff56363a0ec843832660cd26f316ad14c1a15f91ad7b3856da2954462cc42246131c610cc4224675f131c610da6121632b7613302#1 from obscuren/master
Update trietest.txt
commit 7613302b49121632beddef6c5506c3345e4bcfef2c81698e4bbea42c81698f31e4bbea400f
10 years ago
acf4b5753f
Core changes
...
* Code = '' if gas < len(D) * 5
* Sha3 gas 10 + 10 * len(D), rounding up 32 bytes
* Sha256 gas 50 + 50 * len(D), rounding up 32 bytes
* Ripmed gas 50 + 50 * len(D), rounding up 32 bytes
* Accounts and value transfers no longer reverted
10 years ago
b1c247231b
ethlog => logger
10 years ago
48125a25eb
Added missing requires on SSTORE SLOAD
10 years ago
272d58662c
Implemented LOG. Closes #159
10 years ago
29b8a0bc5f
Updated the VM & VM tests
...
* Stack Error shouldn't revert to previous state
* Updated VM Test tool
* Added Transfer method to VM Env
10 years ago
20c742e474
Moved ethvm => vm
10 years ago
311c6f8a3f
Fixed remote Arithmetic tests
10 years ago
c5bd32b0ad
Refactored VM to two separate VMs; std & debug
...
Standard VM should be about 10x faster than the debug VM. Some error
checking has been removed, all of the log statements and therefor quite
some unnecessary if-statements.
10 years ago
1e8b54abfb
Refactored state, state object and vm
...
* The State and StateObject have been moved to their own package
* The VM is moved to it's own package
10 years ago
Péter Szilágyi
Felix Lange
Jeffrey Wilcke
Jeffrey Wilcke
Peter Pratscher
Felix Lange
Gustav Simonsson
Paweł Bylica