go-ethereum

Commit Graph

Author	SHA1	Message	Date
Felix Lange	c213fd1fd8	all: import "context" instead of "golang.org/x/net/context" There is no need to depend on the old context package now that the minimum Go version is 1.7. The move to "context" eliminates our weird vendoring setup. Some vendored code still uses golang.org/x/net/context and it is now vendored in the normal way. This change triggered new vet checks around context.WithTimeout which didn't fire with golang.org/x/net/context.	8 years ago
Péter Szilágyi	d4fd06c3dc	all: blidly swap out glog to our log15, logs need rework	8 years ago
Felix Lange	a2b4abd89a	rpc: send nil on subscription Err channel when Client is closed This change makes client subscriptions compatible with the new Subscription semantics introduced in the previous commit.	8 years ago
Felix Lange	e32925397b	rpc: add context argument to EthSubscribe It's inconsistent not to pass it and most callers will work with contexts anyway.	8 years ago
Felix Lange	f5f042ffdc	rpc: ensure client doesn't block for slow subscribers I initially made the client block if the 100-element buffer was exceeded. It turns out that this is inconvenient for simple uses of the client which subscribe and perform calls on the same goroutine, e.g. client, _ := rpc.Dial(...) ch := make(chan int) // note: no buffer sub, _ := client.EthSubscribe(ch, "something") for event := range ch { client.Call(...) } This innocent looking code will lock up if the server suddenly decides to send 2000 notifications. In this case, the client's main loop won't accept the call because it is trying to deliver a notification to ch. The issue is kind of hard to explain in the docs and few people will actually read them. Buffering is the simple option and works with close to no overhead for subscribers that always listen.	8 years ago
Felix Lange	464660651d	rpc: don't exceed context deadline while waiting for send lock	8 years ago
Felix Lange	91b7690428	rpc: add new client, use it everywhere The new client implementation supports concurrent requests, subscriptions and replaces the various ad hoc RPC clients throughout go-ethereum.	8 years ago

7 Commits (0f4b75bea27b1c39f1dd5c42c3ef472b98f4a7df)