go-ethereum

Commit Graph

Author	SHA1	Message	Date
Martin Holst Swende	edb1937cf7	core: improve shutdown synchronization in BlockChain (#22853 ) This change removes misuses of sync.WaitGroup in BlockChain. Before this change, block insertion modified the WaitGroup counter in order to ensure that Stop would wait for pending operations to complete. This was racy and could even lead to crashes if Stop was called at an unfortunate time. The issue is resolved by adding a specialized 'closable' mutex, which prevents chain modifications after stopping while also synchronizing writers with each other. Co-authored-by: Felix Lange <fjl@twurst.com>	3 years ago

Author

SHA1

Message

Date

Martin Holst Swende

edb1937cf7

core: improve shutdown synchronization in BlockChain (#22853 )

This change removes misuses of sync.WaitGroup in BlockChain. Before this change,
block insertion modified the WaitGroup counter in order to ensure that Stop would wait
for pending operations to complete. This was racy and could even lead to crashes
if Stop was called at an unfortunate time. The issue is resolved by adding a specialized
'closable' mutex, which prevents chain modifications after stopping while also
synchronizing writers with each other.

Co-authored-by: Felix Lange <fjl@twurst.com>

3 years ago

1 Commits (28d076d37e667f26e1f60b97484bed0b5d3cbec2)