129 Commits (6e9f8035a1a49ac096bc2eae6ec4637b48e29048)

Author	SHA1	Message	Date
Felix Lange	eedbb1ee9a	p2p/discover: use rlp.DecodeBytes	10 years ago
Felix Lange	56a48101dc	cmd/rlpdump, cmd/utils, eth, p2p, whisper: use rlp input limit	10 years ago
Felix Lange	5528abc795	p2p: fix the dial timer ... The dial timer was not reset properly when the peer count reached MaxPeers.	10 years ago
obscuren	474aa924ca	p2p: added limiter function to limit package broadcasting	10 years ago
Felix Lange	0217652d1b	p2p/discover: improve timer handling for reply timeouts	10 years ago
Felix Lange	b8aeb04f6f	p2p/discover: remove unused field Node.activeStamp	10 years ago
Felix Lange	b9929d289d	p2p: fix unsynchronized map access during Server shutdown ... removePeer can be called even after listenLoop and dialLoop have returned.	10 years ago
Felix Lange	995fab2ebc	p2p: fix yet another disconnect hang ... Peer.readLoop will only terminate if the connection is closed. Fix the hang by closing the connection before waiting for readLoop to terminate. This also removes the british disconnect procedure where we're waiting for the remote end to close the connection. I have confirmed with @subtly that cpp-ethereum doesn't adhere to it either.	10 years ago
Felix Lange	79a6782c1c	p2p: fix goroutine leak when handshake read fails ... This regression was introduced in b3c058a9e4.	10 years ago
Felix Lange	c5332537f5	p2p: limit number of lingering inbound pre-handshake connections ... This is supposed to apply some back pressure so Server is not accepting more connections than it can actually handle. The current limit is 50. This doesn't really need to be configurable, but we'll see how it behaves in our test nodes and adjust accordingly.	10 years ago
Felix Lange	56977c225e	p2p: use RLock instead of Lock for pre-dial checks	10 years ago
Felix Lange	b3c058a9e4	p2p: improve disconnect signaling at handshake time ... As of this commit, p2p will disconnect nodes directly after the encryption handshake if too many peer connections are active. Errors in the protocol handshake packet are now handled more politely by sending a disconnect packet before closing the connection.	10 years ago
Felix Lange	99a1db2d40	p2p: don't mess with the socket deadline in Peer.readLoop ... netWrapper already sets a read deadline in ReadMsg.	10 years ago
Felix Lange	145330fdf2	p2p: properly decrement peer wait group counter for setup errors	10 years ago
Felix Lange	f1d710af00	p2p: fix Peer shutdown deadlocks ... There were multiple synchronization issues in the disconnect handling, all caused by the odd special-casing of Peer.readLoop errors. Remove the special handling of read errors and make readLoop part of the Peer WaitGroup. Thanks to @Gustav-Simonsson for pointing at arrows in a diagram and playing rubber-duck.	10 years ago
Felix Lange	22d1f0faf1	p2p: improve peer selection logic ... This commit introduces a new (temporary) peer selection strategy based on random lookups. While we're here, also implement the TODOs in dialLoop.	10 years ago
Felix Lange	7be05b4b9d	p2p/discover: don't log packet content	10 years ago
Felix Lange	9cd8c96157	p2p/discover: make packet processing less concurrent	10 years ago
obscuren	688d118c7e	Updated logging	10 years ago
Felix Lange	a77c431e37	p2p/discover: fix off by one error causing buckets to contain duplicates	10 years ago
Felix Lange	de7af720d6	p2p/discover: implement node bonding ... This a fix for an attack vector where the discovery protocol could be used to amplify traffic in a DDOS attack. A malicious actor would send a findnode request with the IP address and UDP port of the target as the source address. The recipient of the findnode packet would then send a neighbors packet (which is 16x the size of findnode) to the victim. Our solution is to require a 'bond' with the sender of findnode. If no bond exists, the findnode packet is not processed. A bond between nodes α and β is created when α replies to a ping from β. This (initial) version of the bonding implementation might still be vulnerable against replay attacks during the expiration time window. We will add stricter source address validation later.	10 years ago
Felix Lange	92928309b2	p2p/discover: add version number to ping packet ... The primary motivation for doing this right now is that old PoC 8 nodes and newer PoC 9 nodes keep discovering each other, causing handshake failures.	10 years ago
zelig	9880f99ccb	fix p2p/testlog_test	10 years ago
obscuren	4f5b362bda	%#x => %x	10 years ago
Felix Lange	b9e0b11e7d	p2p: interrupt MsgPipe payload read/write ... This is better because protocols might not actually read the payload for some errors (msg too big, etc.) which can be a pain to test with the old behaviour.	10 years ago
Felix Lange	a7bced779a	p2p: log disconnect requests ... This helps a lot with debugging.	10 years ago
Felix Lange	5ba51594c7	p2p: use package rlp to encode messages ... Message encoding functions have been renamed to catch any uses. The switch to the new encoder can cause subtle incompatibilities. If there are any users outside of our tree, they will at least be alerted that there was a change. NewMsg no longer exists. The replacements for EncodeMsg are called Send and SendItems.	10 years ago
Felix Lange	4811f460e7	p2p: export ExpectMsg (for eth protocol testing)	10 years ago
obscuren	b523441361	Moved ethutil => common	10 years ago
zelig	e150832734	p2p: server>discover table Self=Node exported	10 years ago
Taylor Gerring	485e37e889	Move MakeName to ethutil	10 years ago
Taylor Gerring	9723191b19	Undo client_version changes	10 years ago
Felix Lange	215c763d53	eth, p2p: delete p2p.Blacklist ... It is unused and untested right now. We can bring it back later if required.	10 years ago
Felix Lange	429828cd92	p2p: reject messages that cannot be written as simple RLPx frames ... Until chunked frames are implemented we cannot send messages with a size overflowing uint24.	10 years ago
Felix Lange	22659a7fea	p2p: restore read/write timeouts ... They got lost in the transition to rlpxFrameRW.	10 years ago
Felix Lange	7964f30dcb	p2p: msg.Payload contains list data ... With RLPx frames, the message code is contained in the frame and is no longer part of the encoded data. EncodeMsg, Msg.Decode have been updated to match. Code that decodes RLP directly from Msg.Payload will need to change.	10 years ago
Felix Lange	21649100b1	p2p: verify protocol handshake node ID	10 years ago
Felix Lange	7d39fd6678	p2p: make encryption handshake code easier to follow ... This mostly changes how information is passed around. Instead of using many function parameters and return values, put the entire state in a struct and pass that. This also adds back derivation of ecdhe-shared-secret. I deleted it by accident in a previous refactoring.	10 years ago
Felix Lange	2c505efd1e	p2p/discover: add NodeID.Pubkey	10 years ago
Felix Lange	d344054e5a	p2p: make RLPx frame MAC 16 bytes as defined in the spec	10 years ago
Felix Lange	d084aed5e9	p2p: delete frameRW	10 years ago
Felix Lange	736e632215	p2p: use RLPx frames for messaging	10 years ago
Felix Lange	51e01cceca	p2p: encrypted and authenticated RLPx frame I/O	10 years ago
Felix Lange	936dd0f3bc	p2p: add basic RLPx frame I/O	10 years ago
Taylor Gerring	e7b33e9ae7	Move p2p.MakeName to ethutil.MakeVersion	10 years ago
Felix Lange	3719db352a	p2p: emit JSON connect/disconnect events	10 years ago
Felix Lange	dd871e791c	p2p: initialize Server.ourHandshake before accepting connections	10 years ago
Felix Lange	3dbd32093c	p2p: enable devp2p ping ... This should prevent connection drops.	10 years ago
Felix Lange	73f94f3755	p2p: disable encryption handshake ... The diff is a bit bigger than expected because the protocol handshake logic has moved out of Peer. This is necessary because the protocol handshake will have custom framing in the final protocol.	10 years ago
Felix Lange	7ea131d4ff	p2p/discover: fix pending replies iteration ... Range expressions capture the length of the slice once before the first iteration. A range expression cannot be used here since the loop modifies the slice variable (including length changes).	10 years ago