151 Commits (8a134014b4b370b4a3632e32a2fc8e84ee2b6947)

Author	SHA1	Message	Date
Felix Lange	7fa2607bd1	p2p/discover: bump maxBondingPingPongs to 16 ... This should increase the speed a bit because all findnode results (up to 16) can be verified at the same time.	10 years ago
Felix Lange	251846d65a	p2p/discover: fix out-of-bounds slicing for chunked neighbors packets ... The code assumed that Table.closest always returns at least 13 nodes. This is not true for small tables (e.g. during bootstrap).	10 years ago
subtly	8eef2b765a	fix test.	10 years ago
subtly	a32693770c	Manual send of multiple neighbours packets. Test receiving multiple neighbours packets.	10 years ago
subtly	7473c93668	UDP Interop. Limit datagrams to 1280bytes. ... We don't have a UDP which specifies any messages that will be 4KB. Aside from being implemented for months and a necessity for encryption and piggy-backing packets, 1280bytes is ideal, and, means this TODO can be completed! Why 1280 bytes? * It's less than the default MTU for most WAN/LAN networks. That means fewer fragmented datagrams (esp on well-connected networks). * Fragmented datagrams and dropped packets suck and add latency while OS waits for a dropped fragment to never arrive (blocking readLoop()) * Most of our packets are < 1280 bytes. * 1280 bytes is minimum datagram size and MTU for IPv6 -- on IPv6, a datagram < 1280bytes will *never* be fragmented. UDP datagrams are dropped. A lot! And fragmented datagrams are worse. If a datagram has a 30% chance of being dropped, then a fragmented datagram has a 60% chance of being dropped. More importantly, we have signed packets and can't do anything with a packet unless we receive the entire datagram because the signature can't be verified. The same is true when we have encrypted packets. So the solution here to picking an ideal buffer size for receiving datagrams is a number under 1400bytes. And the lower-bound value for IPv6 of 1280 bytes make's it a non-decision. On IPv4 most ISPs and 3g/4g/let networks have an MTU just over 1400 -- and *never* over 1500. Never -- that means packets over 1500 (in reality: ~1450) bytes are fragmented. And probably dropped a lot. Just to prove the point, here are pings sending non-fragmented packets over wifi/ISP, and a second set of pings via cell-phone tethering. It's important to note that, if *any* router between my system and the EC2 node has a lower MTU, the message would not go through: On wifi w/normal ISP: localhost:Debug $ ping -D -s 1450 52.6.250.242 PING 52.6.250.242 (52.6.250.242): 1450 data bytes 1458 bytes from 52.6.250.242: icmp_seq=0 ttl=42 time=104.831 ms 1458 bytes from 52.6.250.242: icmp_seq=1 ttl=42 time=119.004 ms ^C --- 52.6.250.242 ping statistics --- 2 packets transmitted, 2 packets received, 0.0% packet loss round-trip min/avg/max/stddev = 104.831/111.918/119.004/7.087 ms localhost:Debug $ ping -D -s 1480 52.6.250.242 PING 52.6.250.242 (52.6.250.242): 1480 data bytes ping: sendto: Message too long ping: sendto: Message too long Request timeout for icmp_seq 0 ping: sendto: Message too long Request timeout for icmp_seq 1 Tethering to O2: localhost:Debug $ ping -D -s 1480 52.6.250.242 PING 52.6.250.242 (52.6.250.242): 1480 data bytes ping: sendto: Message too long ping: sendto: Message too long Request timeout for icmp_seq 0 ^C --- 52.6.250.242 ping statistics --- 2 packets transmitted, 0 packets received, 100.0% packet loss localhost:Debug $ ping -D -s 1450 52.6.250.242 PING 52.6.250.242 (52.6.250.242): 1450 data bytes 1458 bytes from 52.6.250.242: icmp_seq=0 ttl=42 time=107.844 ms 1458 bytes from 52.6.250.242: icmp_seq=1 ttl=42 time=105.127 ms 1458 bytes from 52.6.250.242: icmp_seq=2 ttl=42 time=120.483 ms 1458 bytes from 52.6.250.242: icmp_seq=3 ttl=42 time=102.136 ms	10 years ago
Bas van Kervel	95773b9673	removed redundant newlines in import block	10 years ago
Bas van Kervel	b79dd188d9	replaced several path.* with filepath.* which is platform independent	10 years ago
Felix Lange	bcfd788661	p2p/discover: bump packet timeouts to 500ms	10 years ago
Felix Lange	2adcc31bb4	p2p/discover: new distance metric based on sha3(id) ... The previous metric was pubkey1^pubkey2, as specified in the Kademlia paper. We missed that EC public keys are not uniformly distributed. Using the hash of the public keys addresses that. It also makes it a bit harder to generate node IDs that are close to a particular node.	10 years ago
Felix Lange	72ab6d3255	p2p/discover: track sha3(ID) in Node	10 years ago
Felix Lange	b34a8ef624	p2p, p2p/discover: protocol version 4	10 years ago
Felix Lange	fc747ef4a6	p2p/discover: new endpoint format ... This commit changes the discovery protocol to use the new "v4" endpoint format, which allows for separate UDP and TCP ports and makes it possible to discover the UDP address after NAT.	10 years ago
Péter Szilágyi	b569550a39	p2p/discover: fix api issues caused by leveldb update	10 years ago
Péter Szilágyi	4992765032	p2p/discover: fix goroutine leak due to blocking on sync.Once	10 years ago
Péter Szilágyi	437cf4b3ac	p2p/discover: add node expirer and related tests	10 years ago
Péter Szilágyi	a136e2bb22	p2p/discover: parametrize nodedb version, add persistency tests	10 years ago
Péter Szilágyi	75fd738dea	p2p/discover: drop a superfluous warning	10 years ago
Péter Szilágyi	706da56f75	p2p/discover: wrap the pinger to update the node db too	10 years ago
Péter Szilágyi	85b4b44235	p2p/discover: use iterator based seeding, drop old protocol test	10 years ago
Péter Szilágyi	8de8f61d36	p2p/discover: write the basic tests, catch RLP bug	10 years ago
Péter Szilágyi	0201c04b95	p2p/discovery: fix issues raised in the nodeDb PR	10 years ago
Péter Szilágyi	8646365b42	cmd/bootnode, eth, p2p, p2p/discover: use a fancier db design	10 years ago
Péter Szilágyi	6def110c37	cmd/bootnode, eth, p2p, p2p/discover: clean up the seeder and mesh into eth.	10 years ago
Péter Szilágyi	971702e7a1	p2p/discovery: fix broken tests due to API update	10 years ago
Péter Szilágyi	af923c965f	p2p/discovery: use the seed table for finding nodes, auto drop stale ones	10 years ago
Péter Szilágyi	5f735d6fce	cmd, eth, p2p, p2p/discover: init and clean up the seed cache	10 years ago
Felix Lange	936c8e19ff	p2p/discover: store nodes in leveldb	10 years ago
Felix Lange	eedbb1ee9a	p2p/discover: use rlp.DecodeBytes	10 years ago
Felix Lange	0217652d1b	p2p/discover: improve timer handling for reply timeouts	10 years ago
Felix Lange	b8aeb04f6f	p2p/discover: remove unused field Node.activeStamp	10 years ago
Felix Lange	7be05b4b9d	p2p/discover: don't log packet content	10 years ago
Felix Lange	9cd8c96157	p2p/discover: make packet processing less concurrent	10 years ago
obscuren	688d118c7e	Updated logging	10 years ago
Felix Lange	a77c431e37	p2p/discover: fix off by one error causing buckets to contain duplicates	10 years ago
Felix Lange	de7af720d6	p2p/discover: implement node bonding ... This a fix for an attack vector where the discovery protocol could be used to amplify traffic in a DDOS attack. A malicious actor would send a findnode request with the IP address and UDP port of the target as the source address. The recipient of the findnode packet would then send a neighbors packet (which is 16x the size of findnode) to the victim. Our solution is to require a 'bond' with the sender of findnode. If no bond exists, the findnode packet is not processed. A bond between nodes α and β is created when α replies to a ping from β. This (initial) version of the bonding implementation might still be vulnerable against replay attacks during the expiration time window. We will add stricter source address validation later.	10 years ago
Felix Lange	92928309b2	p2p/discover: add version number to ping packet ... The primary motivation for doing this right now is that old PoC 8 nodes and newer PoC 9 nodes keep discovering each other, causing handshake failures.	10 years ago
obscuren	4f5b362bda	%#x => %x	10 years ago
zelig	e150832734	p2p: server>discover table Self=Node exported	10 years ago
Felix Lange	2c505efd1e	p2p/discover: add NodeID.Pubkey	10 years ago
Felix Lange	7ea131d4ff	p2p/discover: fix pending replies iteration ... Range expressions capture the length of the slice once before the first iteration. A range expression cannot be used here since the loop modifies the slice variable (including length changes).	10 years ago
Felix Lange	cf754b9483	p2p/discover: fix race in ListenUDP ... udp.Table was assigned after the readLoop started, so packets could arrive and be processed before the Table was there.	10 years ago
Felix Lange	170eb3ac68	p2p/discover: map listening port using configured mechanism	10 years ago
Felix Lange	82f0bd9009	p2p/discover: code review fixes	10 years ago
Felix Lange	9915d3c3be	p2p/discover: deflake UDP tests	10 years ago
Felix Lange	028775a086	cmd/ethereum, cmd/mist: add flag for discovery bootstrap nodes	10 years ago
Felix Lange	8564eb9f7e	p2p/discover: add node URL functions, distinguish TCP/UDP ports ... The discovery RPC protocol does not yet distinguish TCP and UDP ports. But it can't hurt to do so in our internal model.	10 years ago
Felix Lange	739066ec56	p2p/discover: add some helper functions	10 years ago
Felix Lange	12224c7f59	p2p/discover: new package implementing the Node Discovery Protocol	10 years ago