50 Commits (8a9a73c99b292bfcb832342877be48856397ee2f)

Author	SHA1	Message	Date
Guillaume Ballet	0c66d971e7	accounts/scwallet: fix keycard data signing error (#25331) ... accounts/scwallet: fix keycard data signing	2 years ago
Felix Lange	b628d72766	build: upgrade to go 1.19 (#25726) ... This changes the CI / release builds to use the latest Go version. It also upgrades golangci-lint to a newer version compatible with Go 1.19. In Go 1.19, godoc has gained official support for links and lists. The syntax for code blocks in doc comments has changed and now requires a leading tab character. gofmt adapts comments to the new syntax automatically, so there are a lot of comment re-formatting changes in this PR. We need to apply the new format in order to pass the CI lint stage with Go 1.19. With the linter upgrade, I have decided to disable 'gosec' - it produces too many false-positive warnings. The 'deadcode' and 'varcheck' linters have also been removed because golangci-lint warns about them being unmaintained. 'unused' provides similar coverage and we already have it enabled, so we don't lose much with this change.	2 years ago
Seungbae.yu	2697e44d81	all: change format `0x%x` to `%#x` (#25221)	2 years ago
Håvard Anda Estensen	07508ac0e9	all: replace uses of ioutil with io and os (#24869)	2 years ago
ucwong	23471288c8	accouts/scwallet: typo fix (#24207)	3 years ago
lightclient	bbfb1e4008	all: add support for EIP-2718, EIP-2930 transactions (#21502) ... This adds support for EIP-2718 typed transactions as well as EIP-2930 access list transactions (tx type 1). These EIPs are scheduled for the Berlin fork. There very few changes to existing APIs in core/types, and several new APIs to deal with access list transactions. In particular, there are two new constructor functions for transactions: types.NewTx and types.SignNewTx. Since the canonical encoding of typed transactions is not RLP-compatible, Transaction now has new methods for encoding and decoding: MarshalBinary and UnmarshalBinary. The existing EIP-155 signer does not support the new transaction types. All code dealing with transaction signatures should be updated to use the newer EIP-2930 signer. To make this easier for future updates, we have added new constructor functions for types.Signer: types.LatestSigner and types.LatestSignerForChainID. This change also adds support for the YoloV3 testnet. Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com>	4 years ago
Guillaume Ballet	9c5729311e	accounts/scwallet: update documentation (#22242)	4 years ago
Felix Lange	ad038b6289	accounts/scwallet: use go-ethereum crypto instead of go-ecdh (#22212) ... * accounts/scwallet: use go-ethereum crypto instead of go-ecdh github.com/wsddn/go-ecdh is a wrapper package for ECDH functionality with any elliptic curve. Since 'generic' ECDH is not required in accounts/scwallet (the curve is always secp256k1), we can just use the standard library functionality and our own crypto libraries to perform ECDH and save a dependency. * Update accounts/scwallet/securechannel.go Co-authored-by: Guillaume Ballet <gballet@gmail.com> * Use the correct key Co-authored-by: Guillaume Ballet <gballet@gmail.com>	4 years ago
Alex Prut	810f9e057d	all: remove redundant conversions and import names (#21903)	4 years ago
mr_franklin	66c3eb2f1a	accouts, consensus, core: fix some comments (#21617)	4 years ago
Martin Michlmayr	4f2784b38f	all: fix typos in comments (#21118)	4 years ago
Felix Lange	c8e9a91672	build: upgrade to golangci-lint 1.24.0 (#20901) ... * accounts/scwallet: remove unnecessary uses of fmt.Sprintf * cmd/puppeth: remove unnecessary uses of fmt.Sprintf * p2p/discv5: remove unnecessary use of fmt.Sprintf * whisper/mailserver: remove unnecessary uses of fmt.Sprintf * core: goimports -w tx_pool_test.go * eth/downloader: goimports -w downloader_test.go * build: upgrade to golangci-lint 1.24.0	5 years ago
Guillaume Ballet	54d332e1db	accounts/scwallet: fix staticcheck warnings (#20370)	5 years ago
Guillaume Ballet	7a22da98b9	accounts/scwallet: flag to specify path to smartcard daemon (#19439) ... * accounts/scwallet: Add a switch to enable smartcard support * accounts: change the meaning of the switch * disable card support in windows until tested * only activate account if pcscd socket file is present * the switch is now the path to the socket file * accounts/scwallet: holiman's review feedback * accounts/scwallet: send the path to go-pcsclite * accounts/scwallet: add default, per platform path * accounts/scwallet: fix error log warning * accounts/scwallet: update pcsc lib to latest * accounts/scwallet: use default path from pcsclite * scwallet: forgot to change switch name * cmd: minor style cleanups (error handling first, then happy path)	5 years ago
Guillaume Ballet	048df258dc	accounts/scwallet: change sc url scheme to keycard (#19632)	5 years ago
Péter Szilágyi	7bc1cb3677	accounts/scwallet: fix public key confirmation regression	5 years ago
Guillaume Ballet	75a860880c	accounts/scwallet: display PUK retry count, validate PIN/PUK length	5 years ago
Martin Holst Swende	fec3b56f7f	accounts, p2p, rpc: make CGO_ENABLED=0 build again (#19593) ... * p2p: remove direct import of cgo-library * accounts, rpc: more nocgo alternatives * rpc: move unix path constant into separate file * accounts/scwallet: address review concerns, remove copy-pasta	5 years ago
Guillaume Ballet	a1c5017bc5	accounts/scwallet: fix card pairing instruction message (#19436)	6 years ago
Péter Szilágyi	ae7344d799	accounts: switch Ledger derivation path to canonical one	6 years ago
Péter Szilágyi	8cf764da89	Revert "Can now specify the number of empty accounts to derive" ... This reverts commit 5b30aa59d6.	6 years ago
Guillaume Ballet	f0b878d56d	accounts/scwallet: Update README for v2.2.1 support (#19425) ... Update the app download link to the latest version, as requested in #19418	6 years ago
Guillaume Ballet	5b30aa59d6	Can now specify the number of empty accounts to derive	6 years ago
Guillaume Ballet	6f21520a82	More review feedback	6 years ago
Guillaume Ballet	fc3000d649	more review feedback	6 years ago
Martin Holst Swende	aae61ab16e	Apply suggestions from code review ... Co-Authored-By: gballet <gballet@gmail.com>	6 years ago
Guillaume Ballet	3b3e1bc07e	Update the card preparation instructions based on review feedback	6 years ago
Guillaume Ballet	8c786a1f99	refresh the account list when initializing the card	6 years ago
Guillaume Ballet	79f4cfac2e	refuse to overwrite the master key of a previously initialized card	6 years ago
Guillaume Ballet	1d1bee528e	fix unnecessary condition linter warning	6 years ago
Guillaume Ballet	714675cd2a	Upgrade to keycard app v2.1.1	6 years ago
Guillaume Ballet	35b80f1865	Fix linter issues	6 years ago
Guillaume Ballet	bcf3c52ac9	PK derivation has to be supported by the card	6 years ago
Guillaume Ballet	189a032987	Add instructions on how to install the card	6 years ago
Guillaume Ballet	ec4fba83d4	Formatting fixes	6 years ago
Guillaume Ballet	21b01f590d	Update a comment to reflect the workings of the updated system	6 years ago
Guillaume Ballet	9b66a8520a	Add some documentation	6 years ago
Guillaume Ballet	e273031dce	Fix key derivation	6 years ago
Guillaume Ballet	7ec6fa03d3	fix wallet status update ... This is a temporary fix, better checks need to be performed once the whole process has been validated.	6 years ago
Guillaume Ballet	42c76a2ba1	Temporary fix to the ADBU status call	6 years ago
Guillaume Ballet	5617dca1c9	Remove the direct dependency on libpcsclite ... Instead, use a go library that communicates with pcscd over a socket. Also update the changes introduced by @gravityblast since this PR's inception	6 years ago
Guillaume Ballet	ae82c58631	Fix some linter issues	6 years ago
Guillaume Ballet	7b230b7ef1	accounts/scwallet: rebase and update	6 years ago
Péter Szilágyi	a900e80a89	accounts/scwallet: fix crypto API change	6 years ago
Péter Szilágyi	7d5886dcf4	accounts, console: frendly card errors, support pin unblock	6 years ago
Péter Szilágyi	386943943f	accounts/scwallet: ordered wallets, tighter events, derivation logs	6 years ago
Péter Szilágyi	114de0fe2a	accounts/scwallet, console: user friendly card opening	6 years ago
Nick Johnson	78375608a4	accounts, internal: Changes in response to review	6 years ago
Nick Johnson	f7027dd68c	accounts, core, internal, node: Add support for smartcard wallets	6 years ago