58 Commits (a6a14f6b712efbfb91a4c0a05eb42998e8dda2ea)

Author	SHA1	Message	Date
Felix Lange	96fb839133	rlp: improve nil pointer handling (#20064) ... * rlp: improve nil pointer handling In both encoder and decoder, the rules for encoding nil pointers were a bit hard to understand, and didn't leave much choice. Since RLP allows two empty values (empty list, empty string), any protocol built on RLP must choose either of these values to represent the null value in a certain context. This change adds choice in the form of two new struct tags, "nilString" and "nilList". These can be used to specify how a nil pointer value is encoded. The "nil" tag still exists, but its implementation is now explicit and defines exactly how nil pointers are handled in a single place. Another important change in this commit is how nil pointers and the Encoder interface interact. The EncodeRLP method was previously called even on nil values, which was supposed to give users a choice of how their value would be handled when nil. It turns out this is a stupid idea. If you create a network protocol containing an object defined in another package, it's better to be able to say that the object should be a list or string when nil in the definition of the protocol message rather than defining the encoding of nil on the object itself. As of this commit, the encoding rules for pointers now take precedence over the Encoder interface rule. I think the "nil" tag will work fine for most cases. For special kinds of objects which are a struct in Go but strings in RLP, code using the object can specify the desired encoding of nil using the "nilString" and "nilList" tags. * rlp: propagate struct field type errors If a struct contained fields of undecodable type, the encoder and decoder would panic instead of returning an error. Fix this by propagating type errors in makeStruct{Writer,Decoder} and add a test.	5 years ago
Felix Lange	8deec2e45a	rlp: fixes for two corner cases and documentation (#19527) ... These changes fix two corner cases related to internal handling of types in package rlp: The "tail" struct tag can only be applied to the last field. The check for this was wrong and didn't allow for private fields after the field with the tag. Unsupported types (e.g. structs containing int) which implement either the Encoder or Decoder interface but not both couldn't be encoded/decoded. Also fixes #19367	6 years ago
Marius van der Wijden	7d881e45bd	rlp: added pooling of streams using sync (#19044) ... Prevents reallocation, improves performance	6 years ago
chenyufeng	2d98099c25	rlp: fix comment typo (#17640)	6 years ago
kiel barry	a42be3b78d	rlp: fix some golint warnings (#16659)	7 years ago
Felix Lange	2499b1b139	rlp: fix string size check in readKind (#15625) ... Issue found by @guidovranken	7 years ago
Péter Szilágyi	63246e2542	rlp: fix decoding long strings into RawValue types	7 years ago
S. Matthew English	061889d4ea	rlp, trie, contracts, compression, consensus: improve comments (#14580)	8 years ago
Felix Lange	eee96a5bb7	rlp: add support for "-" struct tag	8 years ago
Felix Lange	6fdd0893c3	all: fix go vet warnings	9 years ago
Felix Lange	d04a2e7557	all: update license information	9 years ago
Felix Lange	bb07ce3eed	rlp: add "tail" struct tag	9 years ago
Felix Lange	fc8b246109	rlp: move ListSize to raw.go	9 years ago
Felix Lange	24bb68e7cf	rlp: add RawValue	9 years ago
Felix Lange	bc17dba8fb	rlp: add Split functions ... These functions allow destructuring of raw rlp-encoded bytes without the overhead of reflection or copying.	9 years ago
Felix Lange	ac32f52ca6	rlp: fix encReader returning nil buffers to the pool ... The bug can cause crashes if Read is called after EOF has been returned. No code performs such calls right now, but hitting the bug gets more likely as rlp.EncodeToReader gets used in more places.	9 years ago
Péter Szilágyi	1d2420323c	rlp: add support for boolean encoding/decoding	9 years ago
Felix Lange	bfbcfbe4a9	all: fix license headers one more time ... I forgot to update one instance of "go-ethereum" in commit 3f047be5a.	9 years ago
Felix Lange	3f047be5aa	all: update license headers to distiguish GPL/LGPL ... All code outside of cmd/ is licensed as LGPL. The headers now reflect this by calling the whole work "the go-ethereum library".	9 years ago
Felix Lange	345590f27f	rlp: fix check for canonical byte array size ... Decoding did not reject byte arrays of length one with a single element b where 55 < b < 128. Such byte arrays must be rejected because they must be encoded as the single byte b instead.	9 years ago
Felix Lange	cefd948267	rlp: reject trailing data when using DecodeBytes	9 years ago
Felix Lange	ea54283b30	all: update license information	9 years ago
Felix Lange	8743cc1c1c	rlp: add ListSize	10 years ago
Felix Lange	a0566c1058	rlp: remove Flat	10 years ago
Felix Lange	3d0c6a8345	rlp: pool encoder allocations	10 years ago
Felix Lange	dd49c8e43d	rlp: fix list bounds check overflow (found by go-fuzz) ... The list size checking overflowed if the size information for a value was bigger than the list. This is resolved by always performing the check before reading.	10 years ago
Felix Lange	7180699d40	rlp: require declared number of input elements for array types	10 years ago
Felix Lange	4d5a518a0b	rlp: stop accepting lists for byte slices and byte arrays	10 years ago
Felix Lange	cad64fb911	rlp: stricter rules for structs and pointers ... The rules have changed as follows: * When decoding into pointers, empty values no longer produce a nil pointer. This can be overriden for struct fields using the struct tag "nil". * When decoding into structs, the input list must contain an element for each field.	10 years ago
Felix Lange	1e2c93aa2d	rlp: reject non-minimal input strings ... Input strings of length 1 containing a byte < 56 are non-minimal and should be encoded as a single byte instead. Reject such strings.	10 years ago
Felix Lange	6e9f8035a1	rlp: stricter validation of canonical integer format ... All integers (including size information in type tags) need to be encoded using the smallest possible encoding. This commit expands the stricter validation introduced for *big.Int in commit 59597d23a5 to all integer types and size tags.	10 years ago
Felix Lange	6788f955c2	rlp: fix handling of single byte zero when decoding into a pointer ... A single zero byte carries information and should not set the pointer to nil. This is arguably a corner case. While here, fix the comment to explain pointer reuse.	10 years ago
Felix Lange	2750ec47b7	rlp: fix integer overflow in list element size validation ... It is not safe to add anything to s.size.	10 years ago
Felix Lange	c35f4fd0bd	rlp: check top-level value sizes against input limit ... This is a preliminary fix for #420 (SEC-18 RLP decoder unsafe allocation). If a sane input limit is set on the rlp.Stream, it should no longer be possible to cause huge []byte allocations.	10 years ago
obscuren	59597d23a5	Reject integers w/ appended zero's	10 years ago
Felix Lange	181a21c67c	rlp: encode nil array pointers as empty list or string	10 years ago
Felix Lange	a829a56587	rlp: add Stream.Raw	10 years ago
Felix Lange	b41185a68f	rlp: fix nil pointer decoding ... The generic pointer decoder did not advance the input position for empty values. This can lead to strange issues and even infinite loops.	10 years ago
Felix Lange	965c9babe3	rlp: fix encoding of one element strings and byte slices ... The encoder was missing a special case for one element strings whose element is below 0x7f. Such strings must be encoded as a single byte without a string header.	10 years ago
Felix Lange	b94a6a0193	rlp: add DecodeBytes ... Über-convenience.	10 years ago
Felix Lange	cb009a5c4d	rlp: don't panic for nil *big.Int ... All other pointer types can handle nil just fine.	10 years ago
Felix Lange	b94f85de22	rlp: add Flat	10 years ago
Felix Lange	8c3095faf0	rlp: fix encoding of arrays with byte element type	10 years ago
Felix Lange	fc92abec2c	rlp: allow encoding non-empty interface values ... This needs to be supported because []someInterface does occur sometimes. Funny enough, the fix involves changes to the decoder. makeDecoder cannot return an error for non-empty interfaces anymore because the type cache builds both decoder and writer. Do the check at 'runtime' instead.	10 years ago
Felix Lange	29c46cdf34	rlp: fix Decode benchmarks	10 years ago
Felix Lange	552f5b2693	rlp: add functions for encoding ... I'm reasonably confident that the encoding matches the output of ethutil.Encode for values that it supports. Some of the tests have been adpated from the Ethereum testing repository. There are still TODOs in the code.	10 years ago
obscuren	6abf8ef78f	Merge	10 years ago
Felix Lange	6cf4e0329c	rlp: display decoder target type in more error messages ... Decode error messages now say "expected input list for foo.MyStruct" instead of just "expected List".	10 years ago
Felix Lange	829730dec4	rlp: remove dead code	10 years ago
Felix Lange	c084a7daa5	rlp: fix panic in decodeList on go 1.4+ ... The documentation for reflect.Value.Index states that it will panic for out-of-bounds indices. Since go 1.4, it actually panics.	10 years ago