go-ethereum

Author	SHA1	Message	Date
RJ	2ad5dba50a	accounts/abi: differentiate between static and dynamic arrays (#3121 ) solves #3119 Signed-off-by: VoR0220 <rj@erisindustries.com>	8 years ago
Jeffrey Wilcke	91a7a4a786	accounts/abi: fixed unpacking in to already slice interfaces Previously it was assumed that wheneven type `[]interface{}` was given that the interface was empty. The abigen rightfully assumed that interface slices which already have pre-allocated variable sets to be assigned. This PR fixes that by checking that the given `[]interface{}` is larger than zero and assigns each value using the generic `set` function (this function has also been moved to abi/reflect.go) and checks whether the assignment was possible. The generic assignment function `set` now also deals with pointers (useful for interface slice mentioned above) by dereferencing the pointer until it finds a setable type.	8 years ago
Jeffrey Wilcke	5127ec10cb	accouns/abi: refactored ABI package Refactored the abi package parsing and type handling. Relying mostly on package reflect as opposed to most of our own type reflection. Our own type reflection is still used however for cases such as Bytes and FixedBytes (abi: bytes•). This also inclused several fixes for slice handling of arbitrary and fixed size for all supported types. This also further removes implicit type casting such as assigning, for example `[2]T{} = []T{1}` will fail, however `[2]T{} == []T{1, 2}` (notice assigning slice to fixed size array). Assigning arrays to slices will always succeed if they are of the same element type. Incidentally also fixes #2379	9 years ago

Author

SHA1

Message

Date

accounts/abi: differentiate between static and dynamic arrays (#3121 )

solves #3119

Signed-off-by: VoR0220 <rj@erisindustries.com>

8 years ago

Jeffrey Wilcke

91a7a4a786

accounts/abi: fixed unpacking in to already slice interfaces

Previously it was assumed that wheneven type `[]interface{}` was given
that the interface was empty. The abigen rightfully assumed that
interface slices which already have pre-allocated variable sets to be
assigned.

This PR fixes that by checking that the given `[]interface{}` is larger
than zero and assigns each value using the generic `set` function (this
function has also been moved to abi/reflect.go) and checks whether the
assignment was possible.

The generic assignment function `set` now also deals with pointers
(useful for interface slice mentioned above) by dereferencing the
pointer until it finds a setable type.

8 years ago

Jeffrey Wilcke

5127ec10cb

accouns/abi: refactored ABI package

Refactored the abi package parsing and type handling. Relying mostly on
package reflect as opposed to most of our own type reflection. Our own
type reflection is still used however for cases such as Bytes and
FixedBytes (abi: bytes•).

This also inclused several fixes for slice handling of arbitrary and
fixed size for all supported types.

This also further removes implicit type casting such as assigning,
for example `[2]T{} = []T{1}` will fail, however `[2]T{} == []T{1, 2}`
(notice assigning *slice* to fixed size *array*). Assigning arrays to
slices will always succeed if they are of the same element type.

Incidentally also fixes #2379

9 years ago

3 Commits (b792412d3101456bded148e122d9e8c2a0829ba0)