240 Commits (b97e34a8e4d06b315cc495819ba6612f89dec54f)

Author	SHA1	Message	Date
Felix Lange	32dda97602	p2p/discover: ignore packet version numbers ... The strict matching can get in the way of protocol upgrades.	9 years ago
Felix Lange	631bf36102	p2p/discover: remove unused lastLookup field	9 years ago
Felix Lange	b4374436f3	p2p/discover: fix race involving the seed node iterator ... nodeDB.querySeeds was not safe for concurrent use but could be called concurrenty on multiple goroutines in the following case: - the table was empty - a timed refresh started - a lookup was started and initiated refresh These conditions are unlikely to coincide during normal use, but are much more likely to occur all at once when the user's machine just woke from sleep. The root cause of the issue is that querySeeds reused the same leveldb iterator until it was exhausted. This commit moves the refresh scheduling logic into its own goroutine (so only one refresh is ever active) and changes querySeeds to not use a persistent iterator. The seed node selection is now more random and ignores nodes that have not been contacted in the last 5 days.	9 years ago
Péter Szilágyi	c51e153b5c	eth, metrics, p2p: prepare metrics and net packets to eth/62	9 years ago
Jeffrey Wilcke	269c5c7107	Revert "fdtrack: temporary hack for tracking file descriptor usage" ... This reverts commit 5c949d3b3b.	9 years ago
Felix Lange	dd54fef898	p2p/discover: don't attempt to replace nodes that are being replaced ... PR #1621 changed Table locking so the mutex is not held while a contested node is being pinged. If multiple nodes ping the local node during this time window, multiple ping packets will be sent to the contested node. The changes in this commit prevent multiple packets by tracking whether the node is being replaced.	9 years ago
Felix Lange	edccc7ae34	p2p: continue listening after temporary errors	9 years ago
Felix Lange	7d5ff770e2	p2p/discover: continue reading after temporary errors ... Might solve #1579	9 years ago
Felix Lange	0d10d5a0a5	p2p: fix value of DiscSubprotocolError ... We had the wrong value (12) since forever.	9 years ago
Felix Lange	590c99a98f	p2p/discover: fix UDP reply packet timeout handling ... If the timeout fired (even just nanoseconds) before the deadline of the next pending reply, the timer was not rescheduled. The timer would've been rescheduled anyway once the next packet was sent, but there were cases where no next packet could ever be sent due to the locking issue fixed in the previous commit. As timing-related bugs go, this issue had been present for a long time and I could never reproduce it. The test added in this commit did reproduce the issue on about one out of 15 runs.	9 years ago
Felix Lange	01ed3fa1a9	p2p/discover: unlock the table during ping replacement ... Table.mutex was being held while waiting for a reply packet, which effectively made many parts of the whole stack block on that packet, including the net_peerCount RPC call.	9 years ago
Felix Lange	6ee908848c	p2p/nat: disable UPnP test on windows	9 years ago
Felix Lange	b23b4dbd79	p2p/discover: close Table during testing ... Not closing the table used to be fine, but now the table has a database.	9 years ago
Felix Lange	5c949d3b3b	fdtrack: temporary hack for tracking file descriptor usage ... Package fdtrack logs statistics about open file descriptors. This should help identify the source of #1549.	9 years ago
Felix Lange	bfbcfbe4a9	all: fix license headers one more time ... I forgot to update one instance of "go-ethereum" in commit 3f047be5a.	9 years ago
Felix Lange	3f047be5aa	all: update license headers to distiguish GPL/LGPL ... All code outside of cmd/ is licensed as LGPL. The headers now reflect this by calling the whole work "the go-ethereum library".	9 years ago
Ethan Buchman	37efd08b42	p2p: validate recovered ephemeral pubkey against checksum in decodeAuthMsg	9 years ago
Felix Lange	bdae4fd573	all: add some godoc synopsis comments	10 years ago
Felix Lange	ea54283b30	all: update license information	10 years ago
Péter Szilágyi	01fe972113	cmd, core, eth, metrics, p2p: require enabling metrics	10 years ago
Péter Szilágyi	216fc267fa	p2p: fix local/remote cap/protocol mixup	10 years ago
Péter Szilágyi	d84638bd31	p2p: support protocol version negotiation	10 years ago
Péter Szilágyi	6994a3daaa	p2p: instrument P2P networking layer	10 years ago
Felix Lange	6fb810adaa	p2p: throttle all discovery lookups ... Lookup calls would spin out of control when network connectivity was lost. The throttling that was in place only took effect when the table returned zero results, which doesn't happen very often. The new throttling should not have a negative impact when the host is online. Lookups against the network take some time and dials for all results must complete or hit the cache before a new one is started. This usually takes longer than four seconds, leaving online lookups unaffected. Fixes #1296	10 years ago
Felix Lange	70da79f04c	p2p: improve disconnect logging	10 years ago
Felix Lange	8dcbdcad0a	p2p: track write errors and prevent writes during shutdown ... As of this commit, we no longer rely on the protocol handler to report write errors in a timely fashion. When a write fails, shutdown is initiated immediately and no new writes can start. This will also prevent new writes from starting after Server.Stop has been called.	10 years ago
Felix Lange	a8e4cb6dfe	p2p/discover: use separate rand.Source instances in tests ... rand.Source isn't safe for concurrent use.	10 years ago
Felix Lange	261a8077c4	p2p/discover: deflake TestUDP_successfulPing	10 years ago
Péter Szilágyi	1cbbfbe7fa	p2p: fix a close race in the dial test	10 years ago
Felix Lange	3239aca69b	p2p: bump global write timeout to 20s ... The previous value of 5 seconds causes timeouts for legitimate messages if large messages are sent.	10 years ago
Péter Szilágyi	ff84352fb7	p2p: fix close data race	10 years ago
Felix Lange	fc6a5ae3ec	p2p/nat: add timeout for UPnP SOAP requests	10 years ago
Felix Lange	8e4512a5e7	p2p/nat: bump timeout in TestAutoDiscRace	10 years ago
Péter Szilágyi	612f01400f	p2p/discover: bond with seed nodes too (runs only if findnode failed)	10 years ago
Péter Szilágyi	3630432dfb	p2p/discovery: fix a cornercase loop if no seeds or bootnodes are known	10 years ago
Péter Szilágyi	f539ed1e66	p2p/discover: force refresh if the table is empty	10 years ago
Péter Szilágyi	5076170f34	p2p/discover: permit temporary bond failures for previously known nodes	10 years ago
Péter Szilágyi	6078aa08eb	p2p/discover: watch find failures, evacuate on too many, rebond if failed	10 years ago
Péter Szilágyi	64174f196f	p2p/discover: add support for counting findnode failures	10 years ago
Péter Szilágyi	68898a4d6b	p2p: fix Self() panic if listening is disabled	10 years ago
Péter Szilágyi	e1a0ee8fc5	cmd/geth, cmd/utils, eth, p2p: pass and honor a no discovery flag	10 years ago
Péter Szilágyi	278183c7e7	eth, p2p: start the p2p server even if maxpeers == 0	10 years ago
Felix Lange	9e1fd70b50	p2p: decrease frameReadTimeout to 30s ... This detects hanging connections sooner. We send a ping every 15s and other implementation have similar limits.	10 years ago
Felix Lange	1440f9a37a	p2p: new dialer, peer management without locks ... The most visible change is event-based dialing, which should be an improvement over the timer-based system that we have at the moment. The dialer gets a chance to compute new tasks whenever peers change or dials complete. This is better than checking peers on a timer because dials happen faster. The dialer can now make more precise decisions about whom to dial based on the peer set and we can test those decisions without actually opening any sockets. Peer management is easier to test because the tests can inject connections at checkpoints (after enc handshake, after protocol handshake). Most of the handshake stuff is now part of the RLPx code. It could be exported or move to its own package because it is no longer entangled with Server logic.	10 years ago
Felix Lange	9f38ef5d97	p2p/discover: add ReadRandomNodes	10 years ago
Felix Lange	64564da20b	p2p: decrease maximum message size for devp2p to 1kB ... The previous limit was 10MB which is unacceptable for all kinds of reasons, the most important one being that we don't want to allow the remote side to make us allocate 10MB at handshake time.	10 years ago
Felix Lange	dbdc5fd4b3	p2p: delete Server.Broadcast	10 years ago
Péter Szilágyi	cbd3ae6906	p2p/discover: fix #838, evacuate self entries from the node db	10 years ago
Péter Szilágyi	af24c271c7	p2p/discover: fix database presistency test folder	10 years ago
Felix Lange	d2f119cf9b	p2p/discover: limit open files for node database	10 years ago