go-ethereum

Commit Graph

Author	SHA1	Message	Date
Boqin Qin	be6078ad83	all: fix a bunch of inconsequential goroutine leaks (#20667 ) The leaks were mostly in unit tests, and could all be resolved by adding suitably-sized channel buffers or by restructuring the test to not send on a channel after an error has occurred. There is an unavoidable goroutine leak in Console.Interactive: when we receive a signal, the line reader cannot be unblocked and will get stuck. This leak is now documented and I've tried to make it slightly less bad by adding a one-element buffer to the output channels of the line-reading loop. Should the reader eventually awake from its blocked state (i.e. when stdin is closed), at least it won't get stuck trying to send to the interpreter loop which has quit long ago. Co-authored-by: Felix Lange <fjl@twurst.com>	5 years ago
Felföldi Zsolt	a7de796840	les: implement new client pool (#19745 )	5 years ago

Author

SHA1

Message

Date

Boqin Qin

be6078ad83

all: fix a bunch of inconsequential goroutine leaks (#20667 )

The leaks were mostly in unit tests, and could all be resolved by
adding suitably-sized channel buffers or by restructuring the test
to not send on a channel after an error has occurred.

There is an unavoidable goroutine leak in Console.Interactive: when
we receive a signal, the line reader cannot be unblocked and will get
stuck. This leak is now documented and I've tried to make it slightly 
less bad by adding a one-element buffer to the output channels of
the line-reading loop. Should the reader eventually awake from its
blocked state (i.e. when stdin is closed), at least it won't get stuck
trying to send to the interpreter loop which has quit long ago.

Co-authored-by: Felix Lange <fjl@twurst.com>

5 years ago

Felföldi Zsolt

a7de796840

les: implement new client pool (#19745 )

5 years ago

2 Commits (be6078ad831dea01121510dfc9ab1f264a3a189c)