41 Commits (c541b38fb36587d23c60f5e2f2b9b3c8700ec489)

Author	SHA1	Message	Date
Felix Lange	631bf36102	p2p/discover: remove unused lastLookup field	9 years ago
Felix Lange	b4374436f3	p2p/discover: fix race involving the seed node iterator ... nodeDB.querySeeds was not safe for concurrent use but could be called concurrenty on multiple goroutines in the following case: - the table was empty - a timed refresh started - a lookup was started and initiated refresh These conditions are unlikely to coincide during normal use, but are much more likely to occur all at once when the user's machine just woke from sleep. The root cause of the issue is that querySeeds reused the same leveldb iterator until it was exhausted. This commit moves the refresh scheduling logic into its own goroutine (so only one refresh is ever active) and changes querySeeds to not use a persistent iterator. The seed node selection is now more random and ignores nodes that have not been contacted in the last 5 days.	9 years ago
Felix Lange	dd54fef898	p2p/discover: don't attempt to replace nodes that are being replaced ... PR #1621 changed Table locking so the mutex is not held while a contested node is being pinged. If multiple nodes ping the local node during this time window, multiple ping packets will be sent to the contested node. The changes in this commit prevent multiple packets by tracking whether the node is being replaced.	9 years ago
Felix Lange	01ed3fa1a9	p2p/discover: unlock the table during ping replacement ... Table.mutex was being held while waiting for a reply packet, which effectively made many parts of the whole stack block on that packet, including the net_peerCount RPC call.	9 years ago
Felix Lange	b23b4dbd79	p2p/discover: close Table during testing ... Not closing the table used to be fine, but now the table has a database.	9 years ago
Felix Lange	bfbcfbe4a9	all: fix license headers one more time ... I forgot to update one instance of "go-ethereum" in commit 3f047be5a.	9 years ago
Felix Lange	3f047be5aa	all: update license headers to distiguish GPL/LGPL ... All code outside of cmd/ is licensed as LGPL. The headers now reflect this by calling the whole work "the go-ethereum library".	9 years ago
Felix Lange	ea54283b30	all: update license information	9 years ago
Felix Lange	261a8077c4	p2p/discover: deflake TestUDP_successfulPing	10 years ago
Péter Szilágyi	612f01400f	p2p/discover: bond with seed nodes too (runs only if findnode failed)	10 years ago
Péter Szilágyi	3630432dfb	p2p/discovery: fix a cornercase loop if no seeds or bootnodes are known	10 years ago
Péter Szilágyi	f539ed1e66	p2p/discover: force refresh if the table is empty	10 years ago
Péter Szilágyi	5076170f34	p2p/discover: permit temporary bond failures for previously known nodes	10 years ago
Péter Szilágyi	6078aa08eb	p2p/discover: watch find failures, evacuate on too many, rebond if failed	10 years ago
Felix Lange	9f38ef5d97	p2p/discover: add ReadRandomNodes	10 years ago
Péter Szilágyi	cbd3ae6906	p2p/discover: fix #838, evacuate self entries from the node db	10 years ago
Felix Lange	7fa2607bd1	p2p/discover: bump maxBondingPingPongs to 16 ... This should increase the speed a bit because all findnode results (up to 16) can be verified at the same time.	10 years ago
Felix Lange	2adcc31bb4	p2p/discover: new distance metric based on sha3(id) ... The previous metric was pubkey1^pubkey2, as specified in the Kademlia paper. We missed that EC public keys are not uniformly distributed. Using the hash of the public keys addresses that. It also makes it a bit harder to generate node IDs that are close to a particular node.	10 years ago
Felix Lange	72ab6d3255	p2p/discover: track sha3(ID) in Node	10 years ago
Felix Lange	fc747ef4a6	p2p/discover: new endpoint format ... This commit changes the discovery protocol to use the new "v4" endpoint format, which allows for separate UDP and TCP ports and makes it possible to discover the UDP address after NAT.	10 years ago
Péter Szilágyi	4992765032	p2p/discover: fix goroutine leak due to blocking on sync.Once	10 years ago
Péter Szilágyi	437cf4b3ac	p2p/discover: add node expirer and related tests	10 years ago
Péter Szilágyi	a136e2bb22	p2p/discover: parametrize nodedb version, add persistency tests	10 years ago
Péter Szilágyi	706da56f75	p2p/discover: wrap the pinger to update the node db too	10 years ago
Péter Szilágyi	8de8f61d36	p2p/discover: write the basic tests, catch RLP bug	10 years ago
Péter Szilágyi	0201c04b95	p2p/discovery: fix issues raised in the nodeDb PR	10 years ago
Péter Szilágyi	8646365b42	cmd/bootnode, eth, p2p, p2p/discover: use a fancier db design	10 years ago
Péter Szilágyi	6def110c37	cmd/bootnode, eth, p2p, p2p/discover: clean up the seeder and mesh into eth.	10 years ago
Péter Szilágyi	af923c965f	p2p/discovery: use the seed table for finding nodes, auto drop stale ones	10 years ago
Péter Szilágyi	5f735d6fce	cmd, eth, p2p, p2p/discover: init and clean up the seed cache	10 years ago
Felix Lange	936c8e19ff	p2p/discover: store nodes in leveldb	10 years ago
Felix Lange	b8aeb04f6f	p2p/discover: remove unused field Node.activeStamp	10 years ago
Felix Lange	a77c431e37	p2p/discover: fix off by one error causing buckets to contain duplicates	10 years ago
Felix Lange	de7af720d6	p2p/discover: implement node bonding ... This a fix for an attack vector where the discovery protocol could be used to amplify traffic in a DDOS attack. A malicious actor would send a findnode request with the IP address and UDP port of the target as the source address. The recipient of the findnode packet would then send a neighbors packet (which is 16x the size of findnode) to the victim. Our solution is to require a 'bond' with the sender of findnode. If no bond exists, the findnode packet is not processed. A bond between nodes α and β is created when α replies to a ping from β. This (initial) version of the bonding implementation might still be vulnerable against replay attacks during the expiration time window. We will add stricter source address validation later.	10 years ago
zelig	e150832734	p2p: server>discover table Self=Node exported	10 years ago
Felix Lange	82f0bd9009	p2p/discover: code review fixes	10 years ago
Felix Lange	9915d3c3be	p2p/discover: deflake UDP tests	10 years ago
Felix Lange	028775a086	cmd/ethereum, cmd/mist: add flag for discovery bootstrap nodes	10 years ago
Felix Lange	8564eb9f7e	p2p/discover: add node URL functions, distinguish TCP/UDP ports ... The discovery RPC protocol does not yet distinguish TCP and UDP ports. But it can't hurt to do so in our internal model.	10 years ago
Felix Lange	739066ec56	p2p/discover: add some helper functions	10 years ago
Felix Lange	12224c7f59	p2p/discover: new package implementing the Node Discovery Protocol	10 years ago