41 Commits (c91f7beb53ff1ab0376d9aa5fab5a8de8b04631c)

Author	SHA1	Message	Date
Felix Lange	693d9ccbfb	trie: more node iterator improvements (#14615) ... * ethdb: remove Set Set deadlocks immediately and isn't part of the Database interface. * trie: add Err to Iterator This is useful for testing because the underlying NodeIterator doesn't need to be kept in a separate variable just to get the error. * trie: add LeafKey to iterator, panic when not at leaf LeafKey is useful for callers that can't interpret Path. * trie: retry failed seek/peek in iterator Next Instead of failing iteration irrecoverably, make it so Next retries the pending seek or peek every time. Smaller changes in this commit make this easier to test: * The iterator previously returned from Next on encountering a hash node. This caused it to visit the same path twice. * Path returned nibbles with terminator symbol for valueNode attached to fullNode, but removed it for valueNode attached to shortNode. Now the terminator is always present. This makes Path unique to each node and simplifies Leaf. * trie: add Path to MissingNodeError The light client trie iterator needs to know the path of the node that's missing so it can retrieve a proof for it. NodeIterator.Path is not sufficient because it is updated when the node is resolved and actually visited by the iterator. Also remove unused fields. They were added a long time ago before we knew which fields would be needed for the light client.	8 years ago
Felix Lange	4047ccad2f	trie: add start key to NodeIterator constructors ... The 'step' method is split into two parts, 'peek' and 'push'. peek returns the next state but doesn't make it current. The end of iteration was previously tracked by setting 'trie' to nil. End of iteration is now tracked using the 'iteratorEnd' error, which is slightly cleaner and requires less code.	8 years ago
Felix Lange	a13e920af0	trie: clean up iterator constructors ... Make it so each iterator has exactly one public constructor: - NodeIterators can be created through a method. - Iterators can be created through NewIterator on any NodeIterator.	8 years ago
Felix Lange	f1534f5797	trie, whisper/whisperv5: use math/rand Read function	8 years ago
Felix Lange	b9b3efb09f	all: fix ineffectual assignments and remove uses of crypto.Sha3 ... go get github.com/gordonklaus/ineffassign ineffassign .	8 years ago
Felix Lange	8d56bf5ceb	trie: ensure dirty flag is unset for embedded child nodes ... This was caught by the new invariant check.	8 years ago
Felix Lange	177cab5fe7	trie: ensure resolved nodes stay loaded ... Commit 40cdcf1183 broke the optimisation which kept nodes resolved during Get in the trie. The decoder assigned cache generation 0 unconditionally, causing resolved nodes to get flushed on Commit. This commit fixes it and adds two tests.	8 years ago
Felix Lange	40cdcf1183	trie, core/state: improve memory usage and performance (#3135) ... * trie: store nodes as pointers This avoids memory copies when unwrapping node interface values. name old time/op new time/op delta Get 388ns ± 8% 215ns ± 2% -44.56% (p=0.000 n=15+15) GetDB 363ns ± 3% 202ns ± 2% -44.21% (p=0.000 n=15+15) UpdateBE 1.57µs ± 2% 1.29µs ± 3% -17.80% (p=0.000 n=13+15) UpdateLE 1.92µs ± 2% 1.61µs ± 2% -16.25% (p=0.000 n=14+14) HashBE 2.16µs ± 6% 2.18µs ± 6% ~ (p=0.436 n=15+15) HashLE 7.43µs ± 3% 7.21µs ± 3% -2.96% (p=0.000 n=15+13) * trie: close temporary databases in GetDB benchmark * trie: don't keep []byte from DB load around Nodes decoded from a DB load kept hashes and values as sub-slices of the DB value. This can be a problem because loading from leveldb often returns []byte with a cap that's larger than necessary, increasing memory usage. * trie: unload old cached nodes * trie, core/state: use cache unloading for account trie * trie: use explicit private flags (fixes Go 1.5 reflection issue). * trie: fixup cachegen overflow at request of nick * core/state: rename journal size constant	8 years ago
Felix Lange	c3a77d6268	trie: fix delete bug for values contained in fullNode ... Delete crashed if a fullNode contained a valueNode directly. This bug is very unlikely to occur with SecureTrie, but can happen with regular tries. This commit also introduces a randomised test which triggers all trie operations, which should prevent such bugs in the future. Credit for finding this bug goes to Github user @rjl493456442.	8 years ago
Felix Lange	cd791bd855	core, trie: replace state caches with trie journal	8 years ago
Péter Szilágyi	748d1c171d	core, core/state, trie: enterprise hand-tuned multi-level caching	9 years ago
Felix Lange	6fdd0893c3	all: fix go vet warnings	9 years ago
Péter Szilágyi	e90958cd29	cmd, eth, ethdb, node: prioritise chaindata for resources, bump cache	9 years ago
zsfelfoldi	52904ae32f	trie: added error handling ... Created alternate versions of Trie and SecureTrie functions that can return a MissingNodeError (used by ODR services)	9 years ago
Felix Lange	565d9f2306	core, trie: new trie	9 years ago
Felix Lange	6b91a4abe5	trie: improve benchmarks	9 years ago
Felix Lange	bfbcfbe4a9	all: fix license headers one more time ... I forgot to update one instance of "go-ethereum" in commit 3f047be5a.	9 years ago
Felix Lange	3f047be5aa	all: update license headers to distiguish GPL/LGPL ... All code outside of cmd/ is licensed as LGPL. The headers now reflect this by calling the whole work "the go-ethereum library".	9 years ago
Felix Lange	ea54283b30	all: update license information	9 years ago
Jeffrey Wilcke	0a1ff68c11	trie: dirty tracking	10 years ago
obscuren	a40a91d60f	trie: fixed tests	10 years ago
obscuren	d7ab716eea	Fixed mkdnode & added some tests	10 years ago
obscuren	0dd9ac375b	undo	10 years ago
obscuren	d338650089	compilable trie (tests fail)	10 years ago
obscuren	b523441361	Moved ethutil => common	10 years ago
obscuren	357d17ae58	Start at 0	10 years ago
obscuren	bf5365b317	Delet => Delete	10 years ago
obscuren	ae45a39dc1	Secure trie	10 years ago
obscuren	99ebb869bf	Fixed iterator	10 years ago
obscuren	db4aaedcbd	Moved ptrie => trie. Removed old trie	10 years ago
obscuren	fed3e6a808	Refactored ethutil.Config.Db out	10 years ago
obscuren	93e693be72	Fixed tests for 'types'	10 years ago
obscuren	62cd9946ee	j => i	10 years ago
obscuren	e08aba5dd9	added output test	10 years ago
obscuren	3220a32ff0	Added some comparison tests for the new ptrie	10 years ago
Taylor Gerring	ddca18638f	update imports order per goimports	10 years ago
Taylor Gerring	2a9fc7baa9	Merge branch 'develop' of https://github.com/tgerring/go-ethereum	10 years ago
Taylor Gerring	00878e5b6e	Convert trie tests to gocheck	10 years ago
obscuren	60cdb1148c	Transaction execution fixes	10 years ago
obscuren	af34749a6b	ethtrie => trie	10 years ago
obscuren	e02c0fa808	Added generic big to 256 method. Implemented new iterator	10 years ago
obscuren	3debeb7236	ethtrie.NewTrie => ethtrie.New	10 years ago
obscuren	ed3424ff75	Trie fixes	10 years ago
obscuren	09bade6466	Fixed an issue where the trie might crash on missmatching lengths	10 years ago
zelig	707d413761	refactor ethutil/trie to ethtrie	11 years ago
obscuren	c4af1340fa	Updated test	11 years ago
obscuren	34c8045d5b	Fixed issue where JUMPI would do an equally check with 1 instead of GT	11 years ago
obscuren	5cdfee5143	New Trie iterator	11 years ago
obscuren	3ebd7f1166	State snapshotting	11 years ago
Maran	5f49a659c3	More blockchain testing	11 years ago