6 Commits (df182a742cec68adcc034d4747afa5182fc75ca3)

Author	SHA1	Message	Date
Péter Szilágyi	a1d049c1c4	internal/flags: remove low-use type TextMarshalerFlag (#30707) ... Currently we have a custom TextMarshalerFlag. It's a nice idea, allowing anything implementing text marshaller to be used as a flag. That said, we only ever used it in one place because it's not that obvious how to use and it needs some boilerplate on the type itself too, apart of the heavy boilerplate got the custom flag. All in all there's no *need* to drop this feature just now, but while porting the cmds over to cli @v3, all other custom flags worker perfectly, whereas this one started crashing deep inside the cli package. The flag handling in v3 got rebuild on generics and there are a number of new methods needed; and my guess is that maybe one of them doesn't work like this flag currently is designed too. We could definitely try and redesign this flag for cli v3... but all that effort and boilerplate just to use it for 1 flag in 1 location, seems not worth it. So for now I'm suggesting removing it and maybe reconsider a similar feature in cli v3 with however it will work.	3 months ago
Péter Szilágyi	8ec638dc5e	internal/flags: fix --miner.gasprice default listing (#28932)	1 year ago
Péter Szilágyi	ee654626ad	internal/flags: fix loading env vars for custom flags (#28117)	1 year ago
Péter Szilágyi	d9fbb71d63	cmd/geth, internal/flags, go.mod: colorize cli help, support env vars (#28103) ... * cmd/geth, internal/flags, go.mod: colorize cli help, support env vars * internal/flags: use stdout, not stderr for terminal detection	1 year ago
Marius van der Wijden	0e486a56c9	Use filepath.clean instead of path.clean (#26404) ... * internal/flags: use filepath.Clean instead of path.Clean * internal/flags: fix windows pipe issue * internal/flags: modify test for windows * internal/flags: use backticks, fix test	2 years ago
willian.eth	52ed3570c4	cmd: migrate to urfave/cli/v2 (#24751) ... This change updates our urfave/cli dependency to the v2 branch of the library. There are some Go API changes in cli v2: - Flag values can now be accessed using the methods ctx.Bool, ctx.Int, ctx.String, ... regardless of whether the flag is 'local' or 'global'. - v2 has built-in support for flag categories. Our home-grown category system is removed and the categories of flags are assigned as part of the flag definition. For users, there is only one observable difference with cli v2: flags must now strictly appear before regular arguments. For example, the following command is now invalid: geth account import mykey.json --password file.txt Instead, the command must be invoked as follows: geth account import --password file.txt mykey.json	3 years ago