7 Commits (f34f749e8141aa96c25d9ef5d52a7e1235dcad0e)

Author	SHA1	Message	Date
Felix Lange	b8040a430e	cmd/utils: use eth DNS tree for snap discovery (#22808) ... This removes auto-configuration of the snap.*.ethdisco.net DNS discovery tree. Since measurements have shown that > 75% of nodes in all.*.ethdisco.net support snap, we have decided to retire the dedicated index for snap and just use the eth tree instead. The dial iterators of eth and snap now use the same DNS tree in the default configuration, so both iterators should use the same DNS discovery client instance. This ensures that the record cache and rate limit are shared. Records will not be requested multiple times. While testing the change, I noticed that duplicate DNS requests do happen even when the client instance is shared. This is because the two iterators request the tree root, link tree root, and first levels of the tree in lockstep. To avoid this problem, the change also adds a singleflight.Group instance in the client. When one iterator attempts to resolve an entry which is already being resolved, the singleflight object waits for the existing resolve call to finish and returns the entry to both places.	4 years ago
Felix Lange	ab8fd4d005	p2p/dnsdisc: rate limit resolving before checking cache (#22566) ... This makes the rate limit apply regardless of whether the node is already cached.	4 years ago
Felix Lange	d36276d85e	p2p/dnsdisc: fix hot-spin when all trees are empty (#22313) ... In the random sync algorithm used by the DNS node iterator, we first pick a random tree and then perform one sync action on that tree. This happens in a loop until any node is found. If no trees contain any nodes, the iterator will enter a hot loop spinning at 100% CPU. The fix is complicated. The iterator now checks if a meaningful sync action can be performed on any tree. If there is nothing to do, it waits for the next root record recheck time to arrive and then tries again. Fixes #22306	4 years ago
Martin Michlmayr	4f2784b38f	all: fix typos in comments (#21118)	5 years ago
Felix Lange	191364c350	p2p/dnsdisc: add enode.Iterator API (#20437) ... * p2p/dnsdisc: add support for enode.Iterator This changes the dnsdisc.Client API to support the enode.Iterator interface. * p2p/dnsdisc: rate-limit DNS requests * p2p/dnsdisc: preserve linked trees across root updates This improves the way links are handled when the link root changes. Previously, sync would simply remove all links from the current tree and garbage-collect all unreachable trees before syncing the new list of links. This behavior isn't great in certain cases: Consider a structure where trees A, B, and C reference each other and D links to A. If D's link root changed, the sync code would first remove trees A, B and C, only to re-sync them later when the link to A was found again. The fix for this problem is to track the current set of links in each clientTree and removing old links only AFTER all links are synced. * p2p/dnsdisc: deflake iterator test * cmd/devp2p: adapt dnsClient to new p2p/dnsdisc API * p2p/dnsdisc: tiny comment fix	5 years ago
Felix Lange	7300365956	p2p/dnsdisc: update to latest EIP-1459 spec (#20168) ... This updates the DNS TXT record format to the latest changes in ethereum/EIPs#2313.	5 years ago
Felix Lange	0568e81701	p2p/dnsdisc: add implementation of EIP-1459 (#20094) ... This adds an implementation of node discovery via DNS TXT records to the go-ethereum library. The implementation doesn't match EIP-1459 exactly, the main difference being that this implementation uses separate merkle trees for tree links and ENRs. The EIP will be updated to match p2p/dnsdisc. To maintain DNS trees, cmd/devp2p provides a frontend for the p2p/dnsdisc library. The new 'dns' subcommands can be used to create, sign and deploy DNS discovery trees.	5 years ago