Merge pull request #280 from trilene/voip

Ignore empty remote ICE candidates
4 years ago · a7b979084f
parent d38a4dcf5d 124952a11c
commit a7b979084f
1 changed files with 6 additions and 2 deletions
--- a/src/WebRTCSession.cpp
+++ b/src/WebRTCSession.cpp
@ -426,8 +426,12 @@ WebRTCSession::acceptICECandidates(
                for (const auto &c : candidates) {
                        nhlog::ui()->debug(
                          "WebRTC: remote candidate: (m-line:{}):{}", c.sdpMLineIndex, c.candidate);
-                        g_signal_emit_by_name(
-                          webrtc_, "add-ice-candidate", c.sdpMLineIndex, c.candidate.c_str());
+                        if (!c.candidate.empty()) {
+                                g_signal_emit_by_name(webrtc_,
+                                                      "add-ice-candidate",
+                                                      c.sdpMLineIndex,
+                                                      c.candidate.c_str());
+                        }
                }
        }
 }