From 2f0471fff2b6ebdc6e2851756d0ab1aff87f7ea0 Mon Sep 17 00:00:00 2001 From: Jorge Izquierdo Date: Mon, 23 Jan 2017 19:18:41 +0100 Subject: [PATCH] Make test cases that use assertJump fail if they dont fail --- test/BasicToken.js | 3 ++- test/LimitBalance.js | 6 ++++-- test/SafeMath.js | 9 ++++++--- test/StandardToken.js | 6 ++++-- 4 files changed, 16 insertions(+), 8 deletions(-) diff --git a/test/BasicToken.js b/test/BasicToken.js index b899fb026..7516e2737 100644 --- a/test/BasicToken.js +++ b/test/BasicToken.js @@ -25,8 +25,9 @@ contract('BasicToken', function(accounts) { try { let transfer = await token.transfer(accounts[1], 101); } catch(error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); }); diff --git a/test/LimitBalance.js b/test/LimitBalance.js index 2ada59445..be0a6e8ca 100644 --- a/test/LimitBalance.js +++ b/test/LimitBalance.js @@ -26,8 +26,9 @@ contract('LimitBalance', function(accounts) { try { let limDeposit = await lb.limitedDeposit({value: amount}); } catch(error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); it("should allow multiple sends below limit", async function() { @@ -49,8 +50,9 @@ contract('LimitBalance', function(accounts) { try { await lb.limitedDeposit({value: amount+1}) } catch(error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); }); diff --git a/test/SafeMath.js b/test/SafeMath.js index d65b0acc7..3dcd381eb 100644 --- a/test/SafeMath.js +++ b/test/SafeMath.js @@ -40,8 +40,9 @@ contract('SafeMath', function(accounts) { try { let subtract = await safeMath.subtract(a, b); } catch(error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); it("should throw an error on addition overflow", async function() { @@ -50,8 +51,9 @@ contract('SafeMath', function(accounts) { try { let add = await safeMath.add(a, b); } catch(error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); it("should throw an error on multiplication overflow", async function() { @@ -60,8 +62,9 @@ contract('SafeMath', function(accounts) { try { let multiply = await safeMath.multiply(a, b); } catch(error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); }); diff --git a/test/StandardToken.js b/test/StandardToken.js index 293810ee3..76bc0a82b 100644 --- a/test/StandardToken.js +++ b/test/StandardToken.js @@ -32,8 +32,9 @@ contract('StandardToken', function(accounts) { try { let transfer = await token.transfer(accounts[1], 101); } catch(error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); it("should return correct balances after transfering from another account", async function() { @@ -57,8 +58,9 @@ contract('StandardToken', function(accounts) { try { let transfer = await token.transferFrom(accounts[0], accounts[2], 100, {from: accounts[1]}); } catch (error) { - assertJump(error); + return assertJump(error); } + assert.fail('should have thrown before'); }); });