diff --git a/contracts/crowdsale/FinalizableCrowdsale.sol b/contracts/crowdsale/FinalizableCrowdsale.sol index 1a736083c..b9920baca 100644 --- a/contracts/crowdsale/FinalizableCrowdsale.sol +++ b/contracts/crowdsale/FinalizableCrowdsale.sol @@ -16,8 +16,10 @@ contract FinalizableCrowdsale is Crowdsale, Ownable { event Finalized(); - // should be called after crowdsale ends, to do - // some extra finalization work + /** + * @dev Must be called after crowdsale ends, to do some extra finalization + * work. Calls the contract's finalization function. + */ function finalize() onlyOwner { require(!isFinalized); require(hasEnded()); @@ -28,12 +30,11 @@ contract FinalizableCrowdsale is Crowdsale, Ownable { isFinalized = true; } - // end token minting on finalization - // override this with custom logic if needed + /** + * @dev Can be overriden to add finalization logic. The overriding function + * should call super.finalization() to ensure the chain of finalization is + * executed entirely. + */ function finalization() internal { - token.finishMinting(); } - - - } diff --git a/test/FinalizableCrowdsale.js b/test/FinalizableCrowdsale.js index a7e76bfbf..f2266df74 100644 --- a/test/FinalizableCrowdsale.js +++ b/test/FinalizableCrowdsale.js @@ -60,11 +60,4 @@ contract('FinalizableCrowdsale', function ([_, owner, wallet, thirdparty]) { should.exist(event) }) - it('finishes minting of token', async function () { - await increaseTimeTo(this.afterEndTime) - await this.crowdsale.finalize({from: owner}) - const finished = await this.token.mintingFinished() - finished.should.equal(true) - }) - })