From 6ae041bca61ff2d6c25acc865b0152cf54122528 Mon Sep 17 00:00:00 2001
From: Aniket <30843294+Aniket-Engg@users.noreply.github.com>
Date: Mon, 1 Oct 2018 20:53:47 +0530
Subject: [PATCH] Fix/#1355 test helper to check balance difference (#1368)

* signing prefix added

* Minor improvement

* Tests changed

* Successfully tested

* Minor improvements

* Minor improvements

* Revert "Dangling commas are now required. (#1359)"

This reverts commit a6889776f46adca374b6ebf014aa7b0038112a9d.

* fixex #1355

* linting

* suggested changes

* Update BreakInvariantBounty.test.js
---
 test/BreakInvariantBounty.test.js |  9 +++------
 test/helpers/balanceDiff.js       | 10 ++++++++++
 2 files changed, 13 insertions(+), 6 deletions(-)
 create mode 100644 test/helpers/balanceDiff.js

diff --git a/test/BreakInvariantBounty.test.js b/test/BreakInvariantBounty.test.js
index 4c1f8b06c..ff8e0f7bd 100644
--- a/test/BreakInvariantBounty.test.js
+++ b/test/BreakInvariantBounty.test.js
@@ -1,5 +1,6 @@
 const { ethGetBalance, ethSendTransaction } = require('./helpers/web3');
 const { sendEther } = require('./helpers/sendTransaction');
+const { balanceDifference } = require('./helpers/balanceDiff');
 const expectEvent = require('./helpers/expectEvent');
 const { assertRevert } = require('./helpers/assertRevert');
 
@@ -72,12 +73,8 @@ contract('BreakInvariantBounty', function ([_, owner, researcher, anyone, nonTar
 
           it('sends the reward to the researcher', async function () {
             await this.bounty.claim(this.target.address, { from: anyone });
-
-            const researcherPreBalance = await ethGetBalance(researcher);
-            await this.bounty.withdrawPayments(researcher);
-            const researcherPostBalance = await ethGetBalance(researcher);
-
-            researcherPostBalance.sub(researcherPreBalance).should.be.bignumber.equal(reward);
+            (await balanceDifference(researcher, () => this.bounty.withdrawPayments(researcher)))
+              .should.be.bignumber.equal(reward);
             (await ethGetBalance(this.bounty.address)).should.be.bignumber.equal(0);
           });
 
diff --git a/test/helpers/balanceDiff.js b/test/helpers/balanceDiff.js
new file mode 100644
index 000000000..8f88ba400
--- /dev/null
+++ b/test/helpers/balanceDiff.js
@@ -0,0 +1,10 @@
+async function balanceDifference (account, promise) {
+  const balanceBefore = web3.eth.getBalance(account);
+  await promise();
+  const balanceAfter = web3.eth.getBalance(account);
+  return balanceAfter.minus(balanceBefore);
+}
+
+module.exports = {
+  balanceDifference,
+};