Remove redundant getVotes call in Governor (#4940)

Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com> Co-authored-by: ernestognw <ernestognw@gmail.com>
11 months ago · 7417c5946f
parent 0a3f880753
commit 7417c5946f
1 changed files with 5 additions and 3 deletions
--- a/contracts/governance/Governor.sol
+++ b/contracts/governance/Governor.sol
@ -286,10 +286,12 @@ abstract contract Governor is Context, ERC165, EIP712, Nonces, IGovernor, IERC72
        }

        // check proposal threshold
-        uint256 proposerVotes = getVotes(proposer, clock() - 1);
        uint256 votesThreshold = proposalThreshold();
-        if (proposerVotes < votesThreshold) {
-            revert GovernorInsufficientProposerVotes(proposer, proposerVotes, votesThreshold);
+        if (votesThreshold > 0) {
+            uint256 proposerVotes = getVotes(proposer, clock() - 1);
+            if (proposerVotes < votesThreshold) {
+                revert GovernorInsufficientProposerVotes(proposer, proposerVotes, votesThreshold);
+            }
        }

        return _propose(targets, values, calldatas, description, proposer);