From 0da886c9c47a9032a508eaef092d0da214c50e28 Mon Sep 17 00:00:00 2001 From: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com> Date: Thu, 8 Aug 2019 10:34:53 +1000 Subject: [PATCH 1/3] Update ReentrancyGuard.sol (#1862) Fix typo --- contracts/utils/ReentrancyGuard.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/utils/ReentrancyGuard.sol b/contracts/utils/ReentrancyGuard.sol index 7e2149732..4015cdec6 100644 --- a/contracts/utils/ReentrancyGuard.sol +++ b/contracts/utils/ReentrancyGuard.sol @@ -4,7 +4,7 @@ pragma solidity ^0.5.0; * @dev Contract module that helps prevent reentrant calls to a function. * * Inheriting from `ReentrancyGuard` will make the {nonReentrant} modifier - * available, which can be aplied to functions to make sure there are no nested + * available, which can be applied to functions to make sure there are no nested * (reentrant) calls to them. * * Note that because there is a single `nonReentrant` guard, functions marked as From 1c1fa5d968b3727b79f0b68dc3c2e94e2f05c992 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Venturo?= Date: Wed, 7 Aug 2019 21:35:04 -0300 Subject: [PATCH 2/3] Silence false positive warning on preValidatePurchase (#1857) --- contracts/crowdsale/Crowdsale.sol | 1 + 1 file changed, 1 insertion(+) diff --git a/contracts/crowdsale/Crowdsale.sol b/contracts/crowdsale/Crowdsale.sol index 824ba83cf..03fda95a5 100644 --- a/contracts/crowdsale/Crowdsale.sol +++ b/contracts/crowdsale/Crowdsale.sol @@ -138,6 +138,7 @@ contract Crowdsale is ReentrancyGuard { function _preValidatePurchase(address beneficiary, uint256 weiAmount) internal view { require(beneficiary != address(0), "Crowdsale: beneficiary is the zero address"); require(weiAmount != 0, "Crowdsale: weiAmount is 0"); + this; // silence state mutability warning without generating bytecode - see https://github.com/ethereum/solidity/issues/2691 } /** From e59ded9134cd1024bb84881c1b86a357eadb161d Mon Sep 17 00:00:00 2001 From: Francisco Giordano Date: Wed, 7 Aug 2019 22:31:28 -0300 Subject: [PATCH 3/3] Manually specify commit hash to codecov --- scripts/coverage.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coverage.sh b/scripts/coverage.sh index ceff90785..ceb215def 100755 --- a/scripts/coverage.sh +++ b/scripts/coverage.sh @@ -3,5 +3,5 @@ SOLIDITY_COVERAGE=true scripts/test.sh if [ "$CI" = true ]; then - curl -s https://codecov.io/bash | bash -s + curl -s https://codecov.io/bash | bash -s -- -C "$CIRCLE_SHA1" fi