From 9c22fb5f33ece00e35ed1be4a4a3eb82c6aefeaa Mon Sep 17 00:00:00 2001 From: ernestognw Date: Mon, 16 Oct 2023 15:51:33 -0600 Subject: [PATCH] Clarify is fine relying on the storage slot --- contracts/proxy/transparent/TransparentUpgradeableProxy.sol | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contracts/proxy/transparent/TransparentUpgradeableProxy.sol b/contracts/proxy/transparent/TransparentUpgradeableProxy.sol index b2021c74b..c4488f99f 100644 --- a/contracts/proxy/transparent/TransparentUpgradeableProxy.sol +++ b/contracts/proxy/transparent/TransparentUpgradeableProxy.sol @@ -50,7 +50,8 @@ interface ITransparentUpgradeableProxy is IERC1967 { * IMPORTANT: This contract avoids unnecessary storage reads by setting the admin only during construction as an * immutable variable, preventing any changes thereafter. However, the admin slot defined in ERC-1967 can still be * overwritten by the implementation logic pointed to by this proxy. In such cases, the contract may end up in an - * undesirable state where the admin slot is different from the actual admin. + * undesirable state where the admin slot is different from the actual admin. Relying in the value of the admin slot + * is generally fine if the implementation is trusted. * * WARNING: It is not recommended to extend this contract to add additional external functions. If you do so, the * compiler will not check that there are no selector conflicts, due to the note above. A selector clash between any new