Ignore reentrancy in`executeBatch` and update Slither config (#3955)

Co-authored-by: Francisco <fg@frang.io>
pull/3957/head
alpharush 2 years ago committed by GitHub
parent d89e51ac42
commit a5af0adce4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      .github/workflows/checks.yml
  2. 3
      contracts/governance/TimelockController.sol
  3. 3
      slither.config.json

@ -76,10 +76,7 @@ jobs:
- uses: actions/checkout@v3
- name: Set up environment
uses: ./.github/actions/setup
- run: rm foundry.toml
- uses: crytic/slither-action@v0.2.0
with:
slither-version: 0.9.1
codespell:
if: github.repository != 'OpenZeppelin/openzeppelin-contracts-upgradeable'

@ -311,6 +311,9 @@ contract TimelockController is AccessControl, IERC721Receiver, IERC1155Receiver
*
* - the caller must have the 'executor' role.
*/
// This function can reenter, but it doesn't pose a risk because _afterCall checks that the proposal is pending,
// thus any modifications to the operation during reentrancy should be caught.
// slither-disable-next-line reentrancy-eth
function executeBatch(
address[] calldata targets,
uint256[] calldata values,

@ -1,4 +1,5 @@
{
"detectors_to_run": "reentrancy-eth,reentrancy-no-eth,reentrancy-unlimited-gas",
"filter_paths": "contracts/mocks"
"filter_paths": "contracts/mocks",
"compile_force_framework": "hardhat"
}
Loading…
Cancel
Save