diff --git a/contracts/Bounty.sol b/contracts/Bounty.sol index f3b3cd0b9..a36e61d9c 100644 --- a/contracts/Bounty.sol +++ b/contracts/Bounty.sol @@ -18,7 +18,7 @@ contract Bounty is PullPayment, Destructible { /** * @dev Fallback function allowing the contract to receive funds, if they haven't already been claimed. */ - function() payable { + function() public payable { require(!claimed); } diff --git a/contracts/DayLimit.sol b/contracts/DayLimit.sol index 9964bd536..bf3f3cbf0 100644 --- a/contracts/DayLimit.sol +++ b/contracts/DayLimit.sol @@ -15,7 +15,7 @@ contract DayLimit { * @dev Constructor that sets the passed value as a dailyLimit. * @param _limit uint256 to represent the daily limit. */ - function DayLimit(uint256 _limit) { + function DayLimit(uint256 _limit) public { dailyLimit = _limit; lastDay = today(); } diff --git a/contracts/LimitBalance.sol b/contracts/LimitBalance.sol index a32974184..b7f3d2fee 100644 --- a/contracts/LimitBalance.sol +++ b/contracts/LimitBalance.sol @@ -15,7 +15,7 @@ contract LimitBalance { * @dev Constructor that sets the passed value as a limit. * @param _limit uint256 to represent the limit. */ - function LimitBalance(uint256 _limit) { + function LimitBalance(uint256 _limit) public { limit = _limit; } diff --git a/contracts/MerkleProof.sol b/contracts/MerkleProof.sol index e638c8e9d..d8ab71795 100644 --- a/contracts/MerkleProof.sol +++ b/contracts/MerkleProof.sol @@ -13,7 +13,7 @@ library MerkleProof { * @param _root Merkle root * @param _leaf Leaf of Merkle tree */ - function verifyProof(bytes _proof, bytes32 _root, bytes32 _leaf) pure returns (bool) { + function verifyProof(bytes _proof, bytes32 _root, bytes32 _leaf) public pure returns (bool) { // Check if proof length is a multiple of 32 if (_proof.length % 32 != 0) return false; diff --git a/contracts/crowdsale/CappedCrowdsale.sol b/contracts/crowdsale/CappedCrowdsale.sol index 972c1fc1b..c894cdbf5 100644 --- a/contracts/crowdsale/CappedCrowdsale.sol +++ b/contracts/crowdsale/CappedCrowdsale.sol @@ -12,7 +12,7 @@ contract CappedCrowdsale is Crowdsale { uint256 public cap; - function CappedCrowdsale(uint256 _cap) { + function CappedCrowdsale(uint256 _cap) public { require(_cap > 0); cap = _cap; } diff --git a/contracts/crowdsale/Crowdsale.sol b/contracts/crowdsale/Crowdsale.sol index 27ccac3f0..5565a973b 100644 --- a/contracts/crowdsale/Crowdsale.sol +++ b/contracts/crowdsale/Crowdsale.sol @@ -40,7 +40,7 @@ contract Crowdsale { event TokenPurchase(address indexed purchaser, address indexed beneficiary, uint256 value, uint256 amount); - function Crowdsale(uint256 _startTime, uint256 _endTime, uint256 _rate, address _wallet) { + function Crowdsale(uint256 _startTime, uint256 _endTime, uint256 _rate, address _wallet) public { require(_startTime >= now); require(_endTime >= _startTime); require(_rate > 0); @@ -61,7 +61,7 @@ contract Crowdsale { // fallback function can be used to buy tokens - function () payable { + function () public payable { buyTokens(msg.sender); } diff --git a/contracts/crowdsale/RefundVault.sol b/contracts/crowdsale/RefundVault.sol index 62d7599dd..a5de66bdb 100644 --- a/contracts/crowdsale/RefundVault.sol +++ b/contracts/crowdsale/RefundVault.sol @@ -22,7 +22,7 @@ contract RefundVault is Ownable { event RefundsEnabled(); event Refunded(address indexed beneficiary, uint256 weiAmount); - function RefundVault(address _wallet) { + function RefundVault(address _wallet) public { require(_wallet != address(0)); wallet = _wallet; state = State.Active; diff --git a/contracts/crowdsale/RefundableCrowdsale.sol b/contracts/crowdsale/RefundableCrowdsale.sol index c468fcf34..9b683b12e 100644 --- a/contracts/crowdsale/RefundableCrowdsale.sol +++ b/contracts/crowdsale/RefundableCrowdsale.sol @@ -21,7 +21,7 @@ contract RefundableCrowdsale is FinalizableCrowdsale { // refund vault used to hold funds while crowdsale is running RefundVault public vault; - function RefundableCrowdsale(uint256 _goal) { + function RefundableCrowdsale(uint256 _goal) public { require(_goal > 0); vault = new RefundVault(wallet); goal = _goal; diff --git a/contracts/examples/SampleCrowdsale.sol b/contracts/examples/SampleCrowdsale.sol index a83b8856d..3c7672219 100644 --- a/contracts/examples/SampleCrowdsale.sol +++ b/contracts/examples/SampleCrowdsale.sol @@ -30,7 +30,7 @@ contract SampleCrowdsaleToken is MintableToken { */ contract SampleCrowdsale is CappedCrowdsale, RefundableCrowdsale { - function SampleCrowdsale(uint256 _startTime, uint256 _endTime, uint256 _rate, uint256 _goal, uint256 _cap, address _wallet) + function SampleCrowdsale(uint256 _startTime, uint256 _endTime, uint256 _rate, uint256 _goal, uint256 _cap, address _wallet) public CappedCrowdsale(_cap) FinalizableCrowdsale() RefundableCrowdsale(_goal) diff --git a/contracts/examples/SimpleToken.sol b/contracts/examples/SimpleToken.sol index 2381a7162..51edf0873 100644 --- a/contracts/examples/SimpleToken.sol +++ b/contracts/examples/SimpleToken.sol @@ -21,7 +21,7 @@ contract SimpleToken is StandardToken { /** * @dev Constructor that gives msg.sender all of existing tokens. */ - function SimpleToken() { + function SimpleToken() public { totalSupply = INITIAL_SUPPLY; balances[msg.sender] = INITIAL_SUPPLY; } diff --git a/contracts/lifecycle/Destructible.sol b/contracts/lifecycle/Destructible.sol index e1b3174bc..6ac2ff827 100644 --- a/contracts/lifecycle/Destructible.sol +++ b/contracts/lifecycle/Destructible.sol @@ -10,7 +10,7 @@ import "../ownership/Ownable.sol"; */ contract Destructible is Ownable { - function Destructible() payable { } + function Destructible() public payable { } /** * @dev Transfers the current balance to the owner and terminates the contract. diff --git a/contracts/lifecycle/TokenDestructible.sol b/contracts/lifecycle/TokenDestructible.sol index 1c3324fea..8eaad04fd 100644 --- a/contracts/lifecycle/TokenDestructible.sol +++ b/contracts/lifecycle/TokenDestructible.sol @@ -12,7 +12,7 @@ import "../token/ERC20Basic.sol"; */ contract TokenDestructible is Ownable { - function TokenDestructible() payable { } + function TokenDestructible() public payable { } /** * @notice Terminate contract and refund to owner diff --git a/contracts/ownership/HasNoEther.sol b/contracts/ownership/HasNoEther.sol index 3f8309677..238424ad9 100644 --- a/contracts/ownership/HasNoEther.sol +++ b/contracts/ownership/HasNoEther.sol @@ -21,7 +21,7 @@ contract HasNoEther is Ownable { * constructor. By doing it this way we prevent a payable constructor from working. Alternatively * we could use assembly to access msg.value. */ - function HasNoEther() payable { + function HasNoEther() public payable { require(msg.value == 0); } diff --git a/contracts/ownership/HasNoTokens.sol b/contracts/ownership/HasNoTokens.sol index cce530bf6..f7f7e348a 100644 --- a/contracts/ownership/HasNoTokens.sol +++ b/contracts/ownership/HasNoTokens.sol @@ -18,6 +18,9 @@ contract HasNoTokens is CanReclaimToken { * @param data_ Bytes The data passed from the caller. */ function tokenFallback(address from_, uint256 value_, bytes data_) external { + from_; + value_; + data_; revert(); } diff --git a/contracts/ownership/Ownable.sol b/contracts/ownership/Ownable.sol index 67ac79ff1..0e2744914 100644 --- a/contracts/ownership/Ownable.sol +++ b/contracts/ownership/Ownable.sol @@ -17,7 +17,7 @@ contract Ownable { * @dev The Ownable constructor sets the original `owner` of the contract to the sender * account. */ - function Ownable() { + function Ownable() public { owner = msg.sender; } diff --git a/contracts/payment/SplitPayment.sol b/contracts/payment/SplitPayment.sol index 78538e3ec..054d36ab5 100644 --- a/contracts/payment/SplitPayment.sol +++ b/contracts/payment/SplitPayment.sol @@ -20,7 +20,7 @@ contract SplitPayment { /** * @dev Constructor */ - function SplitPayment(address[] _payees, uint256[] _shares) { + function SplitPayment(address[] _payees, uint256[] _shares) public { require(_payees.length == _shares.length); for (uint256 i = 0; i < _payees.length; i++) { diff --git a/contracts/token/CappedToken.sol b/contracts/token/CappedToken.sol index 508669172..c0c2e6fa8 100644 --- a/contracts/token/CappedToken.sol +++ b/contracts/token/CappedToken.sol @@ -11,7 +11,7 @@ contract CappedToken is MintableToken { uint256 public cap; - function CappedToken(uint256 _cap) { + function CappedToken(uint256 _cap) public { require(_cap > 0); cap = _cap; } diff --git a/contracts/token/DetailedERC20.sol b/contracts/token/DetailedERC20.sol index a08236305..28bcbaeef 100644 --- a/contracts/token/DetailedERC20.sol +++ b/contracts/token/DetailedERC20.sol @@ -7,7 +7,7 @@ contract DetailedERC20 is ERC20 { string public symbol; uint8 public decimals; - function DetailedERC20(string _name, string _symbol, uint8 _decimals) { + function DetailedERC20(string _name, string _symbol, uint8 _decimals) public { name = _name; symbol = _symbol; decimals = _decimals; diff --git a/contracts/token/TokenTimelock.sol b/contracts/token/TokenTimelock.sol index 557fc6ed6..fdd9ca495 100644 --- a/contracts/token/TokenTimelock.sol +++ b/contracts/token/TokenTimelock.sol @@ -21,7 +21,7 @@ contract TokenTimelock { // timestamp when token release is enabled uint64 public releaseTime; - function TokenTimelock(ERC20Basic _token, address _beneficiary, uint64 _releaseTime) { + function TokenTimelock(ERC20Basic _token, address _beneficiary, uint64 _releaseTime) public { require(_releaseTime > now); token = _token; beneficiary = _beneficiary; diff --git a/contracts/token/TokenVesting.sol b/contracts/token/TokenVesting.sol index 14373d15b..f311dfad5 100644 --- a/contracts/token/TokenVesting.sol +++ b/contracts/token/TokenVesting.sol @@ -39,7 +39,7 @@ contract TokenVesting is Ownable { * @param _duration duration in seconds of the period in which the tokens will vest * @param _revocable whether the vesting is revocable or not */ - function TokenVesting(address _beneficiary, uint256 _start, uint256 _cliff, uint256 _duration, bool _revocable) { + function TokenVesting(address _beneficiary, uint256 _start, uint256 _cliff, uint256 _duration, bool _revocable) public { require(_beneficiary != address(0)); require(_cliff <= _duration);