Fixed a broken payment test (+ another small fix) (#1318)

* Fixed a broken payment test

* In PR template, npm run lint:fix, not lint:all:fix

* In SplitPayment test, replaced an await-in-loop with Promise.all
pull/1316/head
dwardu 7 years ago committed by Nicolás Venturo
parent d8cbd5554f
commit b79196f911
  1. 2
      .github/PULL_REQUEST_TEMPLATE.md
  2. 6
      test/payment/SplitPayment.test.js

@ -14,4 +14,4 @@ Fixes #
- [ ] 📘 I've reviewed the [OpenZeppelin Contributor Guidelines](../blob/master/CONTRIBUTING.md)
- [ ] ✅ I've added tests where applicable to test my new functionality.
- [ ] 📖 I've made sure that my contracts are well-documented.
- [ ] 🎨 I've run the JS/Solidity linters and fixed any issues (`npm run lint:all:fix`).
- [ ] 🎨 I've run the JS/Solidity linters and fixed any issues (`npm run lint:fix`).

@ -51,10 +51,10 @@ contract('SplitPayment', function ([_, owner, payee1, payee2, payee3, nonpayee1,
});
it('should have payees', async function () {
this.payees.forEach(async (payee, index) => {
(await this.payee(index)).should.be.equal(payee);
await Promise.all(this.payees.map(async (payee, index) => {
(await this.contract.payee(index)).should.be.equal(payee);
(await this.contract.released(payee)).should.be.bignumber.equal(0);
});
}));
});
it('should accept payments', async function () {

Loading…
Cancel
Save