From cfef58361f8c79daf684f084d04faac6e294dba2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Venturo?= Date: Wed, 17 Oct 2018 17:00:12 -0300 Subject: [PATCH] Removed default value assignments. (#1432) --- contracts/drafts/ERC1046/TokenMetadata.sol | 2 +- contracts/payment/SplitPayment.sol | 2 -- contracts/utils/ReentrancyGuard.sol | 2 ++ 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contracts/drafts/ERC1046/TokenMetadata.sol b/contracts/drafts/ERC1046/TokenMetadata.sol index 85b6ec671..9057711d9 100644 --- a/contracts/drafts/ERC1046/TokenMetadata.sol +++ b/contracts/drafts/ERC1046/TokenMetadata.sol @@ -13,7 +13,7 @@ contract ERC20TokenMetadata is IERC20 { } contract ERC20WithMetadata is ERC20TokenMetadata { - string private _tokenURI = ""; + string private _tokenURI; constructor(string tokenURI) public diff --git a/contracts/payment/SplitPayment.sol b/contracts/payment/SplitPayment.sol index 9c716e7ad..960772182 100644 --- a/contracts/payment/SplitPayment.sol +++ b/contracts/payment/SplitPayment.sol @@ -24,8 +24,6 @@ contract SplitPayment { require(payees.length == shares.length); require(payees.length > 0); - _totalShares = 0; - _totalReleased = 0; for (uint256 i = 0; i < payees.length; i++) { _addPayee(payees[i], shares[i]); } diff --git a/contracts/utils/ReentrancyGuard.sol b/contracts/utils/ReentrancyGuard.sol index 689c97205..4c10dc775 100644 --- a/contracts/utils/ReentrancyGuard.sol +++ b/contracts/utils/ReentrancyGuard.sol @@ -12,6 +12,8 @@ contract ReentrancyGuard { uint256 private _guardCounter; constructor() public { + // The counter starts at one to prevent changing it from zero to a non-zero + // value, which is a more expensive operation. _guardCounter = 1; }