From f79ad4e2f6f9ef9161561b1473a4e97f7e9a3c94 Mon Sep 17 00:00:00 2001 From: Manuel Araoz Date: Mon, 19 Dec 2016 17:43:02 -0300 Subject: [PATCH] add 2 lines between top level definitions --- contracts/Claimable.sol | 1 - contracts/LimitBalance.sol | 9 +++++++++ contracts/Migrations.sol | 3 +++ contracts/examples/BadArrayUse.sol | 4 +++- contracts/examples/BadFailEarly.sol | 3 ++- contracts/examples/BadPushPayments.sol | 3 ++- contracts/examples/GoodArrayUse.sol | 3 +++ contracts/examples/GoodFailEarly.sol | 1 + contracts/examples/GoodPullPayments.sol | 2 ++ contracts/examples/ProofOfExistence.sol | 1 + contracts/examples/PullPaymentBid.sol | 2 ++ contracts/examples/StoppableBid.sol | 2 ++ contracts/test-helpers/BasicTokenMock.sol | 3 +++ contracts/test-helpers/LimitBalanceMock.sol | 3 +++ contracts/test-helpers/PullPaymentMock.sol | 3 +++ contracts/test-helpers/SafeMathMock.sol | 3 +++ contracts/test-helpers/StandardTokenMock.sol | 3 +++ contracts/test-helpers/StoppableMock.sol | 3 +++ contracts/token/StandardToken.sol | 4 +++- 19 files changed, 51 insertions(+), 5 deletions(-) diff --git a/contracts/Claimable.sol b/contracts/Claimable.sol index e7490e05d..89a375d7f 100644 --- a/contracts/Claimable.sol +++ b/contracts/Claimable.sol @@ -1,7 +1,6 @@ pragma solidity ^0.4.0; - import './Ownable.sol'; diff --git a/contracts/LimitBalance.sol b/contracts/LimitBalance.sol index d8c29baec..c03cb03e0 100644 --- a/contracts/LimitBalance.sol +++ b/contracts/LimitBalance.sol @@ -1,4 +1,13 @@ pragma solidity ^0.4.4; + + +/** + * LimitBalance + * Simple contract to limit the balance of child contract. + * Note this doesn't prevent other contracts to send funds + * by using selfdestruct(address); + * See: https://github.com/ConsenSys/smart-contract-best-practices#remember-that-ether-can-be-forcibly-sent-to-an-account + */ contract LimitBalance { uint public limit; diff --git a/contracts/Migrations.sol b/contracts/Migrations.sol index c8d890bef..010f551fc 100644 --- a/contracts/Migrations.sol +++ b/contracts/Migrations.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import './Ownable.sol'; + contract Migrations is Ownable { uint public lastCompletedMigration; diff --git a/contracts/examples/BadArrayUse.sol b/contracts/examples/BadArrayUse.sol index d5c1c7b7b..dd8a65344 100644 --- a/contracts/examples/BadArrayUse.sol +++ b/contracts/examples/BadArrayUse.sol @@ -1,8 +1,10 @@ pragma solidity ^0.4.4; + + import '../PullPayment.sol'; -// UNSAFE CODE, DO NOT USE! +// UNSAFE CODE, DO NOT USE! contract BadArrayUse is PullPayment { address[] employees; diff --git a/contracts/examples/BadFailEarly.sol b/contracts/examples/BadFailEarly.sol index 0ad95a92e..ee26bdd1d 100644 --- a/contracts/examples/BadFailEarly.sol +++ b/contracts/examples/BadFailEarly.sol @@ -1,6 +1,7 @@ pragma solidity ^0.4.4; -// UNSAFE CODE, DO NOT USE! + +// UNSAFE CODE, DO NOT USE! contract BadFailEarly { uint constant DEFAULT_SALARY = 50000; diff --git a/contracts/examples/BadPushPayments.sol b/contracts/examples/BadPushPayments.sol index 510b39473..2d85ffeec 100644 --- a/contracts/examples/BadPushPayments.sol +++ b/contracts/examples/BadPushPayments.sol @@ -1,6 +1,7 @@ pragma solidity ^0.4.4; -// UNSAFE CODE, DO NOT USE! + +// UNSAFE CODE, DO NOT USE! contract BadPushPayments { address highestBidder; diff --git a/contracts/examples/GoodArrayUse.sol b/contracts/examples/GoodArrayUse.sol index ce450293e..8995702a8 100644 --- a/contracts/examples/GoodArrayUse.sol +++ b/contracts/examples/GoodArrayUse.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import '../PullPayment.sol'; + contract GoodArrayUse is PullPayment { address[] employees; mapping(address => uint) bonuses; diff --git a/contracts/examples/GoodFailEarly.sol b/contracts/examples/GoodFailEarly.sol index 7a3ec9e60..dce0eac44 100644 --- a/contracts/examples/GoodFailEarly.sol +++ b/contracts/examples/GoodFailEarly.sol @@ -1,5 +1,6 @@ pragma solidity ^0.4.4; + contract GoodFailEarly { uint constant DEFAULT_SALARY = 50000; diff --git a/contracts/examples/GoodPullPayments.sol b/contracts/examples/GoodPullPayments.sol index 9236d0a4f..1469eb57f 100644 --- a/contracts/examples/GoodPullPayments.sol +++ b/contracts/examples/GoodPullPayments.sol @@ -1,4 +1,6 @@ pragma solidity ^0.4.4; + + contract GoodPullPayments { address highestBidder; uint highestBid; diff --git a/contracts/examples/ProofOfExistence.sol b/contracts/examples/ProofOfExistence.sol index a4ec0d45f..0bf7ca220 100644 --- a/contracts/examples/ProofOfExistence.sol +++ b/contracts/examples/ProofOfExistence.sol @@ -1,5 +1,6 @@ pragma solidity ^0.4.4; + /* * Proof of Existence example contract * see https://medium.com/zeppelin-blog/the-hitchhikers-guide-to-smart-contracts-in-ethereum-848f08001f05 diff --git a/contracts/examples/PullPaymentBid.sol b/contracts/examples/PullPaymentBid.sol index 01c91c991..ad4b612b5 100644 --- a/contracts/examples/PullPaymentBid.sol +++ b/contracts/examples/PullPaymentBid.sol @@ -1,7 +1,9 @@ pragma solidity ^0.4.4; + import '../PullPayment.sol'; + contract PullPaymentBid is PullPayment { address public highestBidder; uint public highestBid; diff --git a/contracts/examples/StoppableBid.sol b/contracts/examples/StoppableBid.sol index 0edbd8b3e..61b9d43aa 100644 --- a/contracts/examples/StoppableBid.sol +++ b/contracts/examples/StoppableBid.sol @@ -1,8 +1,10 @@ pragma solidity ^0.4.4; + import '../PullPayment.sol'; import '../Stoppable.sol'; + contract StoppableBid is Stoppable, PullPayment { address public highestBidder; uint public highestBid; diff --git a/contracts/test-helpers/BasicTokenMock.sol b/contracts/test-helpers/BasicTokenMock.sol index 9f19e47ea..5b6447c8a 100644 --- a/contracts/test-helpers/BasicTokenMock.sol +++ b/contracts/test-helpers/BasicTokenMock.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import '../token/BasicToken.sol'; + // mock class using BasicToken contract BasicTokenMock is BasicToken { diff --git a/contracts/test-helpers/LimitBalanceMock.sol b/contracts/test-helpers/LimitBalanceMock.sol index c0f05ba8b..bcb862ef9 100644 --- a/contracts/test-helpers/LimitBalanceMock.sol +++ b/contracts/test-helpers/LimitBalanceMock.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import '../LimitBalance.sol'; + // mock class using LimitBalance contract LimitBalanceMock is LimitBalance(1000) { diff --git a/contracts/test-helpers/PullPaymentMock.sol b/contracts/test-helpers/PullPaymentMock.sol index 1dac2ce53..2d6ca1e2f 100644 --- a/contracts/test-helpers/PullPaymentMock.sol +++ b/contracts/test-helpers/PullPaymentMock.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import '../PullPayment.sol'; + // mock class using PullPayment contract PullPaymentMock is PullPayment { diff --git a/contracts/test-helpers/SafeMathMock.sol b/contracts/test-helpers/SafeMathMock.sol index 9cd618214..430343b81 100644 --- a/contracts/test-helpers/SafeMathMock.sol +++ b/contracts/test-helpers/SafeMathMock.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import '../SafeMath.sol'; + contract SafeMathMock is SafeMath { uint public result; diff --git a/contracts/test-helpers/StandardTokenMock.sol b/contracts/test-helpers/StandardTokenMock.sol index 5b222be9a..1e6741f24 100644 --- a/contracts/test-helpers/StandardTokenMock.sol +++ b/contracts/test-helpers/StandardTokenMock.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import '../token/StandardToken.sol'; + // mock class using StandardToken contract StandardTokenMock is StandardToken { diff --git a/contracts/test-helpers/StoppableMock.sol b/contracts/test-helpers/StoppableMock.sol index 6d3464bdf..44c12bbcf 100644 --- a/contracts/test-helpers/StoppableMock.sol +++ b/contracts/test-helpers/StoppableMock.sol @@ -1,6 +1,9 @@ pragma solidity ^0.4.4; + + import '../Stoppable.sol'; + // mock class using Stoppable contract StoppableMock is Stoppable { bool public drasticMeasureTaken; diff --git a/contracts/token/StandardToken.sol b/contracts/token/StandardToken.sol index 2f3e301d6..b457808ee 100644 --- a/contracts/token/StandardToken.sol +++ b/contracts/token/StandardToken.sol @@ -1,10 +1,12 @@ pragma solidity ^0.4.4; + import './ERC20.sol'; import '../SafeMath.sol'; + /** - * ERC20 token + * Standard ERC20 token * * https://github.com/ethereum/EIPs/issues/20 * Based on code by FirstBlood: