onlineSoftwareDevOK
cd2da98d4d
Refactor magic constant in TimelocController test ( #3397 )
3 years ago
Niccolò Petti
d4e6236b2b
Fix deprecated expectEvent.inLogs #3332 ( #3333 )
3 years ago
Mihir Wadekar
76eee35971
Improve revert message in Governor ( #3275 )
...
* Fixed typo
* fix testing and adding changelog
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
3 years ago
Ashwin Yardi
76fca3aec8
Add ERC721 and ERC1155 receiver support in Governor, Timelock ( #3230 )
...
* add ERC721 and ERC1155 receiver support in Governor, Timelock and MinimalForwarder (#3174 )
* revert the nft receiver hooks from MinimalForwarder and linting updates
* add ERC165 support & simplify test
* add changelog entry
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
3 years ago
Pandapip1
faf5820f03
Fix many spelling errors ( #3274 )
3 years ago
Hadrien Croubois
6a5bbfc4cb
Refactor governor testing ( #3194 )
...
* starting a governor test refactor
* improve governor tests
* refactor compatibility tests using the governor helper
* improve governor helper
* improve governor helper
* refactor governor tests
* refactor testing
* fix testing (still TODO)
* fix tests
* fix tests
* fix spelling
* use different instances of GovernorHelper
* add vote with params support
* coverage
* simplify ERC165 helper
* remove unused proposal argument
* refactor setProposal
* lint
* refactor setProposal return values
* add a data default value
* improve proposal reconstruction and storage in helper
* proposal object refactoring
* lint
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
8b162e39b5
Add a canceller role to the TimelockController ( #3165 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Ben DiFrancesco
fd07cc6290
Extend Governor with parameterized votes ( #3043 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
3 years ago
Hadrien Croubois
af7ec04b78
Improve security of the onlyGovernance modifier ( #3147 )
...
* add a protection mechanism to prevent relaying transaction that are not
part of an execute operation
* more accurate relay authorization
* force reset the relay authorizations after executions
* refactor of the onlyGovernor modifier
* only whitelist when executor is not governor itself
* fix lint
* add private function for call permission management
* use deque
* fix lint
* remove unecessary dependency
* remove unecessary dependency
* comment rephrasing
* Update contracts/governance/Governor.sol
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
* cache keccak256(_msgData())
* use Context
* lint
* conditionnal clear
* add test to cover queue.clear()
* lint
* write more extended docs for onlyGovernance
* add changelog entry
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
c366de3626
Fix encoding of signature+calldata in GovernorCompatibilityBravo ( #3100 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
JulissaDantes
b42b05311b
Add ERC721Votes for NFT-based governance ( #2944 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien@openzeppelin.com>
3 years ago
Hadrien Croubois
abf6024faf
Add a governor module to protect against late quorum ( #2973 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
6089f11c2f
Add a relay mechanism in the governor ( #2926 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
a57e638f57
Improve GovernorTimelockControl.state() to detect direct cancel ( #2977 )
3 years ago
Hadrien Croubois
b12af48a7d
Add Governor module for governance-settable parameters ( #2904 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Hadrien Croubois
abeb0fbf5c
Delay the Pending state until strictly after proposal.voteStart ( #2892 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
Francisco Giordano
494cc6d3a5
Fix typo casted -> cast
...
(cherry picked from commit b174f067df
)
4 years ago
Francisco Giordano
b174f067df
Fix typo casted -> cast
4 years ago
Francisco Giordano
4b152bd8ce
Improve Governor ( #2794 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
4 years ago
Hadrien Croubois
6c1a634053
Add Governor contracts ( #2672 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
Hadrien Croubois
e0a2b195e4
Add modifier & internal function with standard revert message in AccessControl ( #2609 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
Hadrien Croubois
cd443f0d5b
Add tests to extend code coverage ( #2586 )
4 years ago
Hadrien Croubois
24a0bc23cf
Reorganize the repo structure ( #2503 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago