12533bcb2b
ERC721 bugfix + gas optimizations ( #1549 )
...
* Now only swapping when needed.
* Removed _addTokenTo and _removeTokenFrom
* Removed removeTokenFrom test.
* Added tests for ERC721 _mint and _burn
* _burn now uses the same swap and pop mechanism as _removeFromOwner
* Gas optimization on burn
6 years ago
7142e25e78
Add back WhitelistedCrowdsale ( #1525 )
...
* Added WhitelisterRole.
* Added WhitelisteeRole and WhitelistedCrowdsale.
* Added WhitelistedCrowdsale tests.
* Whitelisters can now remove Whitelistees.
* PublicRole.behavior now supports a manager account, added Whitelistee tests.
* Rephrased tests, added test for whitelistees doing invalid purchases.
* Fixed linter error.
* Fixed typos
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Working around JS quirks
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Update PublicRole.behavior.js
* Renamed WhitelisteeRole to WhitelistedRole.
* Renamed WhitelistedCrowdsale to WhitelistCrowdsale.
* Now using the new test helper.
* Added basic documentation.
6 years ago
dd2e947976
Deprecated ERC721._burn(address, uint256) ( #1550 )
...
* Deprecated ERC721._burn(address, uint256)
* Added missing natspec comment.
6 years ago
357fded2b5
Refundable post delivery crowdsale ( #1543 )
...
* Fixed unnecessary dependency of RefundableCrowdsaleImpl on ERC20Mintable.
* Added PostDeliveryRefundableCrowdsale.
* Renamed to RefundablePostDeliveryCrowdsale.
* Added deprecation warning.
6 years ago
5caecf548c
getter added for an array of tokens held by an owner ( #1522 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1512
* Update test/token/ERC721/ERC721Full.test.js
Co-Authored-By: Aniket-Engg <30843294+Aniket-Engg@users.noreply.github.com>
6 years ago
c0bda4db88
Updated sendTransaction, added tests. ( #1528 )
...
* Renamed sendTransaction to send, improved API.
* Added send tests.
* Now using promisified web3
6 years ago
9faebb5365
Added makeInterfaceId tests. ( #1530 )
6 years ago
c2de8ffd14
Now testing events in constructors! ( #1511 )
...
* Added inTransaction tests.
* Added expectEvent.inConstructor.
* Changed inTransaction, removed decodeLogs.
* Flipped comparison to improve the error message.
* Improved expectEvent tests.
* Migrated tests to use expectEvent.
* Added roles constructor tests.
* Fixed linter errors.
* Made lodash a dev dependency.
* Added more inLogs tests.
* Update expectEvent.test.js
* Removed lodash.
* Moved role constructor tests to public role behavior.
* Revert "Flipped comparison to improve the error message."
This reverts commit 438c57833d
6 years ago
f0e12d5301
ether and shouldFail tests ( #1513 )
...
* Added ether tests.
* Added shouldFail base function and tests.
* Updated test descriptions.
* Reduced gas limit on out-of-gas tests.
6 years ago
5471fc808a
Updated code style to 4 space indentation and 120 characters per line. ( #1508 )
...
* Updated code style to 4 spaces and 120 max characters per line.
* Update contracts/token/ERC721/ERC721Pausable.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Update contracts/token/ERC721/IERC721.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
6 years ago
5ee55c4af3
Internal crowdsales ( #1439 )
...
* Made some internal crowdsale methods internal.
* Made all Crowdsale constructors internal.
(cherry picked from commit d9fdffe88e
6 years ago
1b27b4bb34
Improved SafeERC20 allowance handling ( #1407 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* allowance methods in library
* Improved SafeERC20 tests.
* Fixed test coverage.
(cherry picked from commit 315f426f5c
6 years ago
ab932e1873
Added leading underscore to internal functions, renamed supportsInterfaces. ( #1435 )
...
(cherry picked from commit 0231fac514
6 years ago
422b42bb6a
Made some inherit-only contracts internal. ( #1433 )
...
* Made some inherit-only contracts internal.
* Added OwnableMock.
(cherry picked from commit 96d6103e0b
6 years ago
c5a8680a9c
Moved Escrows into an escrow subdirectory, improved docs. ( #1430 )
...
* Moved Escrows into an escrow subdirectory, improved docs.
* Fixed escrow mock.
* Fixed some more imports.
(cherry picked from commit f3df2dab3d
6 years ago
2c40ffa011
Improve encapsulation on ERC165 and update code style guide ( #1379 )
...
* use prefix underscore for internal state variables
* make _supportedInterfaces private
(cherry picked from commit 03dfb2965c
6 years ago
10a5864fdf
First test helpers tests ( #1369 )
...
* Removed unused advanceToBlock.
* Added advanceBlock tests.
* Fixed advanceToBlock tests.
* Added single argument tests.
* Finished inLogs tests.
* Fixed linter errors.
* Fixed linter errors.
(cherry picked from commit 9f822906b8
6 years ago
62ed8e2fe4
Removed BreakInvariantBounty. ( #1424 )
...
(cherry picked from commit 9be0f100c4
6 years ago
e7aa8dedbc
Turn off blank-lines Solium rule ( #1284 )
...
* turn off blank-lines rule
* remove triple newlines
(cherry picked from commit 9b37104655
6 years ago
f8b0cec15b
Add unit test specific to Address utils ( #1251 ) ( #1316 )
...
(cherry picked from commit 7825caa1fd
6 years ago
8d6250cd5a
Add Arrays library with unit tests ( #1209 ) ( #1375 )
...
* Add Arrays library with unit tests (#1209 )
* prepared due to snapshot token requirements
* add library with method to find upper bound
* add unit test for basic and edge cases
* Imporove documentation for Arrays library
Simplify Arrays.test.js to use short arrays as test date
* Added comment for uint256 mid variable.
* Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.
(cherry picked from commit f7e53d90fa
6 years ago
41e74dd8d8
Removed old, unused mocks. ( #1382 )
...
(cherry picked from commit b17de011dc
6 years ago
d9fdffe88e
Internal crowdsales ( #1439 )
...
* Made some internal crowdsale methods internal.
* Made all Crowdsale constructors internal.
6 years ago
315f426f5c
Improved SafeERC20 allowance handling ( #1407 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* allowance methods in library
* Improved SafeERC20 tests.
* Fixed test coverage.
6 years ago
0231fac514
Added leading underscore to internal functions, renamed supportsInterfaces. ( #1435 )
6 years ago
96d6103e0b
Made some inherit-only contracts internal. ( #1433 )
...
* Made some inherit-only contracts internal.
* Added OwnableMock.
6 years ago
f3df2dab3d
Moved Escrows into an escrow subdirectory, improved docs. ( #1430 )
...
* Moved Escrows into an escrow subdirectory, improved docs.
* Fixed escrow mock.
* Fixed some more imports.
6 years ago
9be0f100c4
Removed BreakInvariantBounty. ( #1424 )
6 years ago
03dfb2965c
Improve encapsulation on ERC165 and update code style guide ( #1379 )
...
* use prefix underscore for internal state variables
* make _supportedInterfaces private
6 years ago
9f822906b8
First test helpers tests ( #1369 )
...
* Removed unused advanceToBlock.
* Added advanceBlock tests.
* Fixed advanceToBlock tests.
* Added single argument tests.
* Finished inLogs tests.
* Fixed linter errors.
* Fixed linter errors.
6 years ago
f7e53d90fa
Add Arrays library with unit tests ( #1209 ) ( #1375 )
...
* Add Arrays library with unit tests (#1209 )
* prepared due to snapshot token requirements
* add library with method to find upper bound
* add unit test for basic and edge cases
* Imporove documentation for Arrays library
Simplify Arrays.test.js to use short arrays as test date
* Added comment for uint256 mid variable.
* Explaned why uint256 mid variable calculated as Math.average is safe to use as index of array.
6 years ago
b17de011dc
Removed old, unused mocks. ( #1382 )
6 years ago
bd8345a153
Separate ERC721Mintable ( #1365 )
...
* separate part of ERC721Mintable into ERC721MetadataMintable
* remove mint and burn from 721 tests
* Fixed linter error.
* fix ERC721 mint tests
* Minor fixes.
(cherry picked from commit 744f567f40
6 years ago
744f567f40
Separate ERC721Mintable ( #1365 )
...
* separate part of ERC721Mintable into ERC721MetadataMintable
* remove mint and burn from 721 tests
* Fixed linter error.
* fix ERC721 mint tests
* Minor fixes.
6 years ago
8c394de450
Add SignatureBouncer test for when msg.data is too short ( #1360 )
...
* add test for msg.data too short
* fix test to hit that branch
* Update SignatureBouncer.test.js
(cherry picked from commit 1a4e5346ed
6 years ago
1a4e5346ed
Add SignatureBouncer test for when msg.data is too short ( #1360 )
...
* add test for msg.data too short
* fix test to hit that branch
* Update SignatureBouncer.test.js
6 years ago
fa5ecd03cb
Improved bounty tests. ( #1350 )
...
* Improved bounty tests.
* Fixed linter errors.
* Addressed review comments.
(cherry picked from commit ae109f69cc
6 years ago
ae109f69cc
Improved bounty tests. ( #1350 )
...
* Improved bounty tests.
* Fixed linter errors.
* Addressed review comments.
6 years ago
9b37104655
Turn off blank-lines Solium rule ( #1284 )
...
* turn off blank-lines rule
* remove triple newlines
6 years ago
f22adbb742
Fixed relative imports. ( #1321 )
...
(cherry picked from commit 225b492109
6 years ago
35d92fddaa
update Math.sol path ( #1319 )
...
(cherry picked from commit d8cbd5554f
6 years ago
fa739d8af0
Move BreakInvariantBounty to drafts ( #1334 )
...
* move BreakInvariantBounty to drafts
* fix bad imports
6 years ago
6c36bc71a7
Changes to Counter ( #1332 )
...
* rename Index.currentId to current
* use += operator for clarity
* rename Counter.Index to Counter.Counter
* move Counter to drafts
(cherry picked from commit 3e55408cb5
6 years ago
658af64edd
Rename AutoIncrementing to Counter ( #1307 )
...
(cherry picked from commit b4f87bb8fc
6 years ago
3e55408cb5
Changes to Counter ( #1332 )
...
* rename Index.currentId to current
* use += operator for clarity
* rename Counter.Index to Counter.Counter
* move Counter to drafts
6 years ago
b4f87bb8fc
Rename AutoIncrementing to Counter ( #1307 )
7 years ago
225b492109
Fixed relative imports. ( #1321 )
7 years ago
7825caa1fd
Add unit test specific to Address utils ( #1251 ) ( #1316 )
7 years ago
d8cbd5554f
update Math.sol path ( #1319 )
7 years ago
4b33eaefa2
Improved ERC721 granularity ( #1304 )
...
* Split enumerable and metadata implementations.
* Renamed ERC721Basic to ERC721, and ERC721 to ERC721Full.
* Fixed linter errors.
7 years ago
Nicolás Venturo
Aniket
Mikhail Melnik
Francisco Giordano
Jakub Bogacz
Guillaume
Leo Arias