barakman
a3e02be459
Initialize `MAX_UINT` more neatly ( #1166 )
...
Use 2 ^ 256 - 1 instead that huge constant value.
7 years ago
Francisco Giordano
d124f18dde
add note about next tag in releasing document ( #1153 )
7 years ago
barakman
17309e5924
Change `uint` to `uint256` ( #1160 )
...
This is a minor change, aligning to the same convention used in the other contracts.
7 years ago
Nicolás Venturo
94797978bb
SplitPayment now requires payees. ( #1131 )
...
* SplitPayment now requires payees.
* Improved test phrasing.
7 years ago
yaronvel
31ac59b224
reentrancy mutex gas optimization ( #1155 )
...
* reentrancy mutex gas optimization
* 1) uint => uint256 2) ++ to += 1
7 years ago
Francisco Giordano
bf34911857
Remove Math.min64 and Math.max64 ( #1156 )
...
* remove Math.min64 and Math.max64
* refactor Math tests to use return values
* enhance Math coverage
7 years ago
Francisco Giordano
59cb2e2d0f
release candidate v1.12.0-rc.2
7 years ago
Nicolás Venturo
ba85aef95e
Renamed behaviour to behavior. ( #1151 )
7 years ago
Nicolás Venturo
448a7b3048
Fixed HasNoTokens test. ( #1149 )
7 years ago
Doug Crescenzi
ef347ffccc
Consolidated ERC20 Interface and Implementation Files ( #1125 )
...
* Consolidted ERC20 Interface and Implementation Files
* Fixed CanReclaimToken's tests to use StandardTokenMock instead of BasicTokenMock
* Changed token's variable type in TokenTimelock to ERC20
* Merged the StandardBurnableToken with BurnableToken since it now inherits from StandardToken; Fixed TokenTimelock so it uses SafeERC20 for ERC20
* Fixed variable type for _token in TokenTimelock constructor
* Fixed linting warning in BurnableToken
* Added back burnFrom tests.
7 years ago
Nicolás Venturo
418a6b5791
Crowdsale inheritance order ( #1128 )
...
* Changed Crowdsale inheritance order.
* Changed FinalizableCrowdsale inheritance order.
(cherry picked from commit 3d86c58d2c
)
7 years ago
Nicolás Venturo
3d86c58d2c
Crowdsale inheritance order ( #1128 )
...
* Changed Crowdsale inheritance order.
* Changed FinalizableCrowdsale inheritance order.
7 years ago
Nicolás Venturo
e77d70f8c1
Remove .babelrc
7 years ago
Nicolás Venturo
4544df47da
All tests now use account names, and dont use accounts[0] (except ERC… ( #1137 )
...
* All tests now use account names, and dont use accounts[0] (except ERC721)
* Added account names to some missing contracts.
7 years ago
Leo Arias
f49721576f
Remove abbreviations from parameters ( #1142 )
...
* Add an initial document for our code style
* Remove abbreviations from parameters
* Rename the param in AddressUtils
* fix comment
7 years ago
Shishir Sonekar
7fdca7b025
updated the typo in Readme ( #1143 )
7 years ago
Leo Arias
1dcefa6bd3
Add an initial document for our release process ( #1140 )
...
* Add an initial document for our release process
* add more detail and explanation to releasing guide
* fix details of the RELEASING.md document
* Update RELEASING.md
* Update RELEASING.md
* Update RELEASING.md
* Update RELEASING.md
7 years ago
Leo Arias
89ccb03e6e
Add an initial document for our code style ( #1141 )
...
* Add an initial document for our code style
* add parameter types
7 years ago
Nicolás Venturo
5ae8aa4e2e
Updated package-lock.json
7 years ago
Francisco Giordano
3806d6128e
release candidate v1.12.0-rc.1
7 years ago
Nicolás Venturo
052fd3425d
Made the visibility-first rule mandatory.
7 years ago
Nicolás Venturo
4d799f3cbe
Sorted .soliumrc.json rules.
7 years ago
Nicolás Venturo
07a27f0e5e
Disabled Solium's error-reason rule. ( #1138 )
7 years ago
Vittorio Minacori
ca9e317259
Update Truffle and Solium ( #1105 )
...
* fixed visibility warnings
* solved visibility and line length warning
* change a test assertion that fails due to chai dependence update
* linter, constructor style and solved visibility warnings
* Changed Windows line endings to Unix.
7 years ago
Nicolás Venturo
9638ecd87a
Typo fix.
7 years ago
Roman Storm
56735a706c
Use address(this) instead of this ( #1134 )
...
* Use address(this) instead of this
It's preferred to use `address(this)` vs `this`
* Change to address(this) vs this
7 years ago
Leo Arias
2765350248
Prefix all parameters with underscore ( #1133 )
7 years ago
Alex
1200969eb6
Refactor/reentrancy guard gas optimization #1056 ( #1057 )
...
* optimizing ReentrancyGuard gas usage
* style fixed
7 years ago
Brendan Chou
90b98a7bef
Add pure to tokenFallback function ( #1122 )
...
Silences warning
7 years ago
Dave Hoover
16429b1522
Making visibility explicit for storage variables ( #759 )
...
* Making visibility explicit for storage variables
* Made BasicToken's variables internal.
7 years ago
Justus Perlwitz
ae2980b072
Add EditorConfig ( #1119 )
...
* Add EditorConfig file.
This allows users with a wide variety of editors to easily code in
OpenZeppelin's preferred 2 space indentation code style.
See https://editorconfig.org for more information.
* Eslint: Always disallow trailing space
* Eslint: Error on missing EOL at file end
7 years ago
Doug Crescenzi
f5b0bb3246
Added more comprehensive usage information to the Getting Started guide: ( #1089 )
...
* Added an Architecture section that speaks to the different types of contracts
* Added a Tests section that provides high-level visibility into what is used for unit testing
* Added a How To Use and Modify OpenZeppelin Contracts section
* Added development principles to the existing Security section
7 years ago
Matt Condon
4c6575bf2f
fix: solium linting errors ( #1113 )
...
* fix: solium linting errors, fixes #1092
* fix: remove uppercase requirement
7 years ago
Justus Perlwitz
2f6c8b05f6
Test/assertRevert: Fix late return bug ( #1123 )
...
We now ensure that if an exception is thrown while awaiting the promise,
the exception _has_ to be a revert. We throw 'Expected revert not
received' only afterwards. This solves any problems with confusing the
word 'revert'.
Fix #775
7 years ago
Nicolás Venturo
567b773242
Prefer const in test files ( #1117 )
...
* Removed all instances of var.
* Sorted eslintrc rules.
* Made eslint rule severity explicit.
* Now prefering const over let.
7 years ago
Matt Condon
6e19ed47be
fix: bounty tests, superceeds #799 ( #1112 )
...
* fix: bounty tests, superceeds #799
* fix: updates from PR notes
7 years ago
Justus Perlwitz
e6c15b34da
Remove chai-as-promised ( #1116 )
...
* Test: Remove chai-as-promised calls
* Test/Helpers: expectThrow accepts optional message
* NPM: Remove chai-as-promised
* Contracts/DestructibleMock: Fix lint
7 years ago
Matt Condon
afe9113b18
fix: move RBAC to //access ( #1114 )
7 years ago
Nicolás Venturo
73be06412f
Remove payable from Destructible constructor ( #1107 )
...
* Destructible no longer has a payable constructor.
* Fixed linter errors.
7 years ago
Doug Crescenzi
23074676c4
Improved documentation for _preValidatePurchase method in Crowdsale ( #1101 )
...
* Improved documentation for _preValidatePurchase in Crowdsale
* Added newline at EOF
7 years ago
Nicolás Venturo
3c69cf658c
Removed JSHint (unused). ( #1088 )
7 years ago
Yong Zhen Yu
6bd8842ab5
removed and tested unecessary gas cost ( #1017 )
...
* removed and tested unecessary gas cost
* linted
* Revert package-lock.json update.
This reverts commit 054598ce7f
.
* Added clarifying comments.
7 years ago
Amir Bandeali
d20d03c149
Remove redundant modifiers from safeTransferFrom ( #1029 ) ( #1030 )
7 years ago
zaryab
ebd4b5e73d
decrease approval condition fix (greater than and equal to) ( #1063 )
...
* decrease approval condition fix (greater than and equal to)
* sol lint fixed
* Improved standard token decreaseApprovalTests.
7 years ago
Lucas Gleba
1ecda54449
Input check sequence modification for gas efficiency ( #1043 )
...
* Update StandardToken.sol
* Slight improvement in gas efficiency
Users tend to attempt to over-spend more than they attempt to burn non-burnable tokens. If the contract checks for overspending before assuring tokens are not being burnt a slight amount of gas might be saved in the long term.
7 years ago
Nicolás Venturo
67b67b791e
Changed before for beforeAll, refactored Bouncer tests. ( #1094 )
...
* Changed before for beforeAll, refactored Bouncer tests.
* Fixed linter errors.
* fix: updates for SignatureBouncer tests and voucher construction
7 years ago
Doug Crescenzi
ce0c3274ee
made remaining public fallback functions external ( #1080 )
7 years ago
Doug Crescenzi
90b3050ad7
minor RBAC.sol documentation fix ( #1060 )
7 years ago
Leo Arias
c95ea5125d
Fix MerkleProof natspec comments ( #1083 )
7 years ago
Leo Arias
11266b0d56
Fix ReentrancyGuard comments ( #1084 )
7 years ago