94797978bb
SplitPayment now requires payees. ( #1131 )
...
* SplitPayment now requires payees.
* Improved test phrasing.
7 years ago
31ac59b224
reentrancy mutex gas optimization ( #1155 )
...
* reentrancy mutex gas optimization
* 1) uint => uint256 2) ++ to += 1
7 years ago
bf34911857
Remove Math.min64 and Math.max64 ( #1156 )
...
* remove Math.min64 and Math.max64
* refactor Math tests to use return values
* enhance Math coverage
7 years ago
ef347ffccc
Consolidated ERC20 Interface and Implementation Files ( #1125 )
...
* Consolidted ERC20 Interface and Implementation Files
* Fixed CanReclaimToken's tests to use StandardTokenMock instead of BasicTokenMock
* Changed token's variable type in TokenTimelock to ERC20
* Merged the StandardBurnableToken with BurnableToken since it now inherits from StandardToken; Fixed TokenTimelock so it uses SafeERC20 for ERC20
* Fixed variable type for _token in TokenTimelock constructor
* Fixed linting warning in BurnableToken
* Added back burnFrom tests.
7 years ago
418a6b5791
Crowdsale inheritance order ( #1128 )
...
* Changed Crowdsale inheritance order.
* Changed FinalizableCrowdsale inheritance order.
(cherry picked from commit 3d86c58d2c
7 years ago
3d86c58d2c
Crowdsale inheritance order ( #1128 )
...
* Changed Crowdsale inheritance order.
* Changed FinalizableCrowdsale inheritance order.
7 years ago
f49721576f
Remove abbreviations from parameters ( #1142 )
...
* Add an initial document for our code style
* Remove abbreviations from parameters
* Rename the param in AddressUtils
* fix comment
7 years ago
ca9e317259
Update Truffle and Solium ( #1105 )
...
* fixed visibility warnings
* solved visibility and line length warning
* change a test assertion that fails due to chai dependence update
* linter, constructor style and solved visibility warnings
* Changed Windows line endings to Unix.
7 years ago
9638ecd87a
Typo fix.
7 years ago
56735a706c
Use address(this) instead of this ( #1134 )
...
* Use address(this) instead of this
It's preferred to use `address(this)` vs `this`
* Change to address(this) vs this
7 years ago
2765350248
Prefix all parameters with underscore ( #1133 )
7 years ago
1200969eb6
Refactor/reentrancy guard gas optimization #1056 ( #1057 )
...
* optimizing ReentrancyGuard gas usage
* style fixed
7 years ago
90b98a7bef
Add pure to tokenFallback function ( #1122 )
...
Silences warning
7 years ago
16429b1522
Making visibility explicit for storage variables ( #759 )
...
* Making visibility explicit for storage variables
* Made BasicToken's variables internal.
7 years ago
4c6575bf2f
fix: solium linting errors ( #1113 )
...
* fix: solium linting errors, fixes #1092
* fix: remove uppercase requirement
7 years ago
e6c15b34da
Remove chai-as-promised ( #1116 )
...
* Test: Remove chai-as-promised calls
* Test/Helpers: expectThrow accepts optional message
* NPM: Remove chai-as-promised
* Contracts/DestructibleMock: Fix lint
7 years ago
afe9113b18
fix: move RBAC to //access ( #1114 )
7 years ago
73be06412f
Remove payable from Destructible constructor ( #1107 )
...
* Destructible no longer has a payable constructor.
* Fixed linter errors.
7 years ago
23074676c4
Improved documentation for _preValidatePurchase method in Crowdsale ( #1101 )
...
* Improved documentation for _preValidatePurchase in Crowdsale
* Added newline at EOF
7 years ago
6bd8842ab5
removed and tested unecessary gas cost ( #1017 )
...
* removed and tested unecessary gas cost
* linted
* Revert package-lock.json update.
This reverts commit 054598ce7f
7 years ago
d20d03c149
Remove redundant modifiers from safeTransferFrom ( #1029 ) ( #1030 )
7 years ago
ebd4b5e73d
decrease approval condition fix (greater than and equal to) ( #1063 )
...
* decrease approval condition fix (greater than and equal to)
* sol lint fixed
* Improved standard token decreaseApprovalTests.
7 years ago
1ecda54449
Input check sequence modification for gas efficiency ( #1043 )
...
* Update StandardToken.sol
* Slight improvement in gas efficiency
Users tend to attempt to over-spend more than they attempt to burn non-burnable tokens. If the contract checks for overspending before assuring tokens are not being burnt a slight amount of gas might be saved in the long term.
7 years ago
67b67b791e
Changed before for beforeAll, refactored Bouncer tests. ( #1094 )
...
* Changed before for beforeAll, refactored Bouncer tests.
* Fixed linter errors.
* fix: updates for SignatureBouncer tests and voucher construction
7 years ago
ce0c3274ee
made remaining public fallback functions external ( #1080 )
7 years ago
90b3050ad7
minor RBAC.sol documentation fix ( #1060 )
7 years ago
c95ea5125d
Fix MerkleProof natspec comments ( #1083 )
7 years ago
11266b0d56
Fix ReentrancyGuard comments ( #1084 )
7 years ago
45d6943913
Fix typos ( #1082 )
7 years ago
5f6d511af9
Fix typo in Crowdsale.sol ( #1035 )
7 years ago
3318b91697
feat: add AutoIncrementing contract ( #1023 )
...
* feat: add AutoIncrementing contract
* feat: allow multiple counters per instance
* fix: some linting errors
* feat: use recommended implementaiton
* fix: remove .only in tests
* fix: PR notes
* fix: add note about incrementing counter
7 years ago
99e4b081dc
ECRecover test should revert because of wrong calldata size ( #1050 )
...
* Assume that token is mintable.
* ECRecover test should revert because of wrong calldata size
* fix: use expectThrow
* fix: ignore failing test until solc^0.5.0
7 years ago
b120b9aff7
moved ERC165 interface IDs from ERC721 implementation files to the interface file ( #1070 )
7 years ago
8fd072cf8e
Escrows ( #1014 )
...
* Added basic Escrow
* PullPayment now uses an Escrow, removing all trust from the contract
* Abstracted the Escrow tests to a behaviour
* Added ConditionalEscrow
* Added RefundableEscrow.
* RefundableCrowdsale now uses a RefundEscrow, removed RefundVault.
* Renaming after code review.
* Added log test helper.
* Now allowing empty deposits and withdrawals.
* Style fixes.
* Minor review comments.
* Add Deposited and Withdrawn events, removed Refunded
* The base Escrow is now Ownable, users of it (owners) must provide methods to access it.
7 years ago
c2ad8c3f57
Update the use of call() with selector only. ( #1033 )
7 years ago
7d8e3ca8b2
Align ERC721 Receiver with current ERC721 standard. ( #1047 )
...
* Align ERC721 Receiver with current ERC721 standard.
Adds a second address field to onERC721Received
onERC721Received(address,address,uint256,bytes)
Updates the function signature to 0x150b7a02 from 0xf0b9e5ba
* Add _operator to onERC721Received
* Fix error caused by formatOnSave
* Fixed comments on ERC721Receiver
Removed "Must use 50,000 gas or less"
Corrected the function signature
7 years ago
6b37ba36a1
Remove ERC827 token. ( #1045 )
...
Implementing this token is unsafe as per comments here:
https://github.com/ethereum/EIPs/issues/827#issuecomment-397857455
7 years ago
dc1e352cc4
Don't emit Approval event when approval is cleared on transfer ( #1039 )
7 years ago
f18c3bc438
feat: initial implementation of ERC1046 ( #933 )
...
* feat: initial implementation of ERC1046
7 years ago
74a62a1314
using SafeERC20 to implement safeTransfer in Crowdsale ( #1006 )
...
* introduced safeTransfer to Crowdsale
* Removed .node-xmlhttprequest-sync-7601
7 years ago
92b695f2fb
Fix/whitelisted crowdsale ( #981 )
...
* fix: swithc WhitelistedCrowdsale to use Whitelist.sol
* feat: refactor whitelist.sol, rbac.sol and whitelistedcrowdsale.sol
* feat: add event arg assets and update whitelist
* fix: update modifier comment and also test isWhitelisted
* fix: remove onlyWhitelisted backwards compat attempt, fix explicit inheritance
* fix: remove underscore prefix from event args
* fix: user access/Whitelist
7 years ago
ee78f67985
fixing comment - changing '_to' to '_spender' ( #1007 )
7 years ago
07020e9544
Remove redundant @dev tags ( #995 )
...
* Remove redundant @dev tags
* Remove redundant @notice tags
7 years ago
b4406d385f
Use abi.encodeWithSignature together with raw call() ( #1008 )
7 years ago
78e39aa2ad
Do not use implicit type conversion for address literals ( #1002 )
...
Uses the explicit address(0) for the zero address
7 years ago
e4ed8f0705
Added explicit integer sizes to uint variables in StandardToken ( #1004 )
7 years ago
5daaf60d11
Make contracts 4.24 compatible ( #951 )
...
* Make contracts 4.24 compatible
7 years ago
e1dc1411fc
WIP: Fix/erc721 ( #993 )
...
* fix: defer lookup-specific info to implementations
* fix: change inheritance order, fix import
7 years ago
9f1d294ba4
Move Whitelist contract to access directory ( #994 )
7 years ago
9951acf6d8
Added aflesher as an author to SignatureBouncer.sol ( #996 )
7 years ago
Nicolás Venturo
yaronvel
Francisco Giordano
Doug Crescenzi
Leo Arias
Vittorio Minacori
Roman Storm
Alex
Brendan Chou
Dave Hoover
Matt Condon
Justus Perlwitz
Yong Zhen Yu
Amir Bandeali
zaryab
Lucas Gleba
Hoon Choi
Leonardo
Alex Beregszaszi
Paul Barclay
Maciej Górski
Rob
Arun Kumar
chriseth
artiebits
Adam Flesher