Balaji Pachai
|
3682c6575c
|
Added message string for require() (#1704)
* Error handling in ERC20 and ERC721
* Added message string for require.
* Fixed solhint errors.
* Updated PR as per issue #1709
* changes as per #1709 and openzeppelin forum.
* Changes in require statement
* Changes in require statement
* build pipeline fix
* Changes as per @nventuro's comment.
* Update revert reason strings.
* Fianal update of revert reason strings.
* WIP: Updating reason strings in test cases
* WIP: Added changes to ERC20 and ERC721
* Fixes linting errors in *.tes.js files
* Achieved 100% code coverage
* Updated the test cases with shouldFail.reverting.withMessage()
* Fix package-lock.
* address review comments
* fix linter issues
* fix remaining revert reasons
|
6 years ago |
Nicolás Venturo
|
308a4c9907
|
Draft EIP 1820 (#1677)
* Add barebones EIP1820 support.
* Update openzeppelin-test-helpers dependency to have ERC1820 support.
* Add tests for ERC1820.
* Improve inline documentation.
* Add changelog entry.
* Update test-helpers, refactor tests to use new helpers.
* Rename ERC1820 to ERC1820Implementer.
* Improve implementer docstring.
* Remove _implementsInterfaceForAddress.
* update openzeppelin-test-helpers to 0.2.0
* Update contracts/drafts/ERC1820Implementer.sol
Co-Authored-By: nventuro <nicolas.venturo@gmail.com>
* Fix how solidity coverage is run to allow for free events.
* Fix coverage testing script.
|
6 years ago |
|
Nicolás Venturo
|
3e82db2f6f
|
Migration to truffle 5 (and web3 1.0 (and BN)) (#1601)
* Now compiling using truffle 5.
* Migrated some test files, missing BN scientific notation usage.
* Now using BN time values.
* Migrate ERC20 tests.
* Migrate all ERC20 tests.
* Migrate utils, payment and ownership tests.
* All tests save ERC721 migrated.
* Migrated ERC721 tests.
* Fix lint errors.
* Delete old test helpers.
* Fix remaining crowdsale tests.
* Fix signature bouncer tests.
* Update how constants is used.
* Compile script pre-removes the build dir.
* Fix SafeMath tests.
* Revert "Compile script pre-removes the build dir."
This reverts commit 247e745113.
* Fix linter errors.
* Upgrade openzeppelin-test-helpers dependency.
* Update openzeppelin-test-helpers dependency.
* Define math constants globally.
* Remove unnecessary ether unit.
* Roll back reduced ether amounts in tests.
* Remove unnecessary toNumber conversions.
* Delete compile script.
* Fixed failing test.
|
6 years ago |
Aniket
|
70fd243e3b
|
Test setup helper added (#1482)
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359)"
This reverts commit a6889776f4.
* updates
* fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1205
* minor change
* suggested changes
* reviewed changes
* final update
|
6 years ago |
|
Nicolás Venturo
|
b9793abec6
|
balanceDifference tests and application (#1514)
* Added balanceDifference tests.
* Added balanceDifference tests.
* Now using balanceDifference in all (most) tests.
* Fixed typo.
|
6 years ago |
|
Nicolás Venturo
|
c5a8680a9c
|
Moved Escrows into an escrow subdirectory, improved docs. (#1430)
* Moved Escrows into an escrow subdirectory, improved docs.
* Fixed escrow mock.
* Fixed some more imports.
(cherry picked from commit f3df2dab3d)
|
6 years ago |
|
Nicolás Venturo
|
f3df2dab3d
|
Moved Escrows into an escrow subdirectory, improved docs. (#1430)
* Moved Escrows into an escrow subdirectory, improved docs.
* Fixed escrow mock.
* Fixed some more imports.
|
6 years ago |
