bb7ca7d151
Prevent setting address(0) as the initialAdmin in AccessManager ( #4570 )
...
Co-authored-by: Francisco <fg@frang.io>
1 year ago
ff9d089dad
Add a boolean to AccessManager.GrantGroup ( #4569 )
1 year ago
33cab7cd25
AccessManager: Remove classes ( #4562 )
1 year ago
9d2adccf87
Add a minimum delay on all admin update operations ( #4557 )
...
Co-authored-by: Francisco <fg@frang.io>
1 year ago
b5a3e693e7
Improve AccessManager ( #4520 )
2 years ago
9bb8008c23
Access Manager ( #4416 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco Giordano <fg@frang.io>
2 years ago
5ae630684a
Add a bool return to _grantRole and _revokeRole ( #4241 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
9cf873ea14
Change access folder structure ( #4359 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
d6a8b2ccd7
Fix details AccessControl-test ( #4391 )
2 years ago
b425a72240
Replace revert strings with custom errors ( #4261 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
13d5e0466a
Make Ownable's initial owner explicit ( #4267 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
0f10efe232
Remove code in preparation for v5.0 ( #4258 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
3ec4307c8a
Fix bug allowing anyone to cancel an admin renounce ( #4238 )
...
Co-authored-by: Francisco Giordano <fg@frang.io>
2 years ago
3e1b25a5cf
Clean up pending admin schedule on renounce in DefaultAdminRules ( #4230 )
2 years ago
72ed4ca67a
Ensure AccessControlDefaultAdminRules's initialDefaultAdmin is non-zero ( #4220 )
...
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
d23f818a59
Fix AccessControlDefaultAdminRules admin consistency ( #4177 )
...
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
a522187b50
Implement suggestions from audit of AccessManager ( #4178 )
...
Co-authored-by: Francisco Giordano <fg@frang.io>
2 years ago
ca822213f2
Make AccessControlDefaultAdminRules delay configurable ( #4079 )
...
Co-authored-by: Francisco <fg@frang.io>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
fa112be682
Add AccessManager contracts ( #4121 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Ernesto García <ernestognw@gmail.com>
2 years ago
dad73159df
Add AccessControlDefaultAdminRules ( #4009 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
a28aafdc85
Use Prettier for JS files ( #3913 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
c1d9da4052
Use hardhat-exposed to reduce the need for mocks ( #3666 )
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
2336bd3e8e
Simplify ESLint config ( #3903 )
2 years ago
1f0e7cdf04
Add Ownable2Step extension with 2-step transfer ( #3620 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <frangio.1@gmail.com>
2 years ago
668a648bc6
Add utilities for CrossChain messaging ( #3183 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
e0a2b195e4
Add modifier & internal function with standard revert message in AccessControl ( #2609 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
b1e0aa487d
Fix AccessControlEnumerable not tracking renounceRole ( #2572 )
...
* Fix AccessControlEnumerable not tracking renounceRole
* Updated changelog
(cherry picked from commit 7adf0d88a0
4 years ago
7adf0d88a0
Fix AccessControlEnumerable not tracking renounceRole ( #2572 )
...
* Fix AccessControlEnumerable not tracking renounceRole
* Updated changelog
4 years ago
f07c39be8a
Add ERC165 interface detection to AccessControl ( #2562 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
(cherry picked from commit 29ffe6f426
4 years ago
29ffe6f426
Add ERC165 interface detection to AccessControl ( #2562 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
4 years ago
24a0bc23cf
Reorganize the repo structure ( #2503 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
e341bdc1b7
Remove enumerable from AccessControl and add AccessControlEnumerable extension ( #2512 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
f06738828b
Migrate to Hardhat ( #2397 )
4 years ago
7f3eee750a
Add TimelockController ( #2354 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
ace35fdeda
Update all dependencies transitively ( #2363 )
4 years ago
0b489f4d79
Improve test descriptions #1157 ( #2334 )
...
Co-authored-by: Paolo Dibitonto <p.dibitonto@almaviva.it>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
5 years ago
ccfd370b89
Update Test Helpers to 0.5.6 ( #2261 )
...
* update test-helpers to 0.5.6-rc.0
* remove comment that no longer applies
* fix uses of expectEvent.notEmitted
* remove mocha only
* update to final version
* Update test/token/ERC777/ERC777.test.js
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
5 years ago
4cbcaf35e4
Fix linter errors
5 years ago
73baf0b635
Feature/Adding RoleAdminChanged event in AccessControl ( #2214 )
...
* Emit new event RoleAdminChanged
* Adding new RoleAdminChanged event in Tests
* Update suggested comments on new Event
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
* Adding PreviousAdminRole to event
* Update AccessControl.test.js
* Update CHANGELOG.md
Co-authored-by: Nicolás Venturo <nicolas.venturo@gmail.com>
5 years ago
c7705712ba
Remove in-constructor requirements ( #2195 )
...
* Remove isConstructor requirement from _setupRole
* Remove isConstructor requirement from _setupDecimals
* Update contracts/access/AccessControl.sol
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
5 years ago
5b5d91c9d4
Remove 'external' functions ( #2162 )
...
* Remove _grantRole and _revokeRole, replace with _setupRole
* Make all external AccessControl functions public
* Remove Ownable._transferOwnership
* Rename ERC721's _safeTransferFrom and _transferFrom to _safeTransfer and _transfer
* Make all ERC721 external functions public
* Make all miscelaneous external functions public instead
* Add changelog entry
* Move calldata arguments to memory
* Update contracts/access/AccessControl.sol
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
* Restrict setupRole to the constructor
* Replace isConstructor for !isContract
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
5 years ago
c173392e15
Revamped Access Control ( #2112 )
...
* Remove Roles
* Add AccessControl and tests
* Removed IAccessControl
* Add RoleGranted and RoleRevoked events
* Make roles grantable and revokable regardless of their previous status
* Fix typo
* Add documentation
* Cleanup tests
* Add enumeration tests
* Add _setRoleAdmin tests
* Fix lint error
* Fix AccessControl link in docs
* WIP on access control guide
* Rename getRoleMembersCount
* Add tests for new role admin
* Make AccessControl GSN compatible
* Update access control guide
* Rename admin to adminRole
* Rename roleIds to roles
* Add 'operator' to RoleGranted and RoleRevoked events.
* Only emit events if the roles were not previously granted/revoked
* Uncomment expectEvent.not tests
* Rename operator to sender
* Add changelog entry
5 years ago
8176a901a9
Cleanup of Ownership directory ( #2120 )
...
* Remove Ownable.isOwner.
* Remove ownable behavior from tests
* Make Escrow use Ownable instead of Secondary
* Migrate GSNRecipientERC20Fee to Ownable
* Remove Secondary
* Move Ownable to access directory
* Remove mentions of Secondary
* Add changelog entry
* Move Ownable tests to access
* Remove unused mock
5 years ago
5dfe7215a9
Migrate Contracts to Solidity v0.6 ( #2080 )
...
* Initial migration to Solidity 0.6.x - v3.0 first steps (#2063 )
* Initial migration, missing GSN, 721, 777 and Crowdsales.
* Add _beforeTokenOperation and _afterTokenOperation.
* Add documentation for hooks.
* Add hooks doc
* Add missing drafts
* Add back ERC721 with hooks
* Bring back ERC777
* Notes on hooks
* Bring back GSN
* Make functions virtual
* Make GSN overrides explicit
* Fix ERC20Pausable tests
* Remove virtual from some view functions
* Update linter
* Delete examples
* Remove unnecessary virtual
* Remove roles from Pausable
* Remove roles
* Remove users of roles
* Adapt ERC20 tests
* Fix ERC721 tests
* Add all ERC721 hooks
* Add ERC777 hooks
* Fix remaining tests
* Bump compiler version
* Move 721BurnableMock into mocks directory
* Remove _before hooks
* Fix tests
* Upgrade linter
* Put modifiers last
* Remove _beforeTokenApproval and _beforeOperatorApproval hooks
5 years ago
5f92adc2e7
Migrate from truffle to test-environment ( #2007 )
...
* Sketch
* Migrate all tests to test-env
* Finish migration to test-env
* Add config
* Work on GSN tests
* Migrate to newer test-env version and loader syntax
* Add GSN setup
* Finish test-env migration
* Setup coverage using test-env
* Migrate to npm package
* Fix package.json
* Add compile step to CI
* Add comment on coverage setup
* Remove dependency on @truffle/contract
* Fix package-lock merge
* Fix linter errors
* Upgrade test-environment, depend locally on ganche-coverage
* Improve coverage script
* Improve sign.js API
* Move accounts destructuring to describe block
* Switch to prebuilt ethereumjs-vm package
* Upgrade test-enviroment version
* use workspace in circleci config
* remove unnecessary npx
5 years ago
3274d9db00
Upgrade to @openzeppelin/test-helpers@0.5.1 ( #1942 )
5 years ago
489d2e85f1
Replace chai.should with chai.expect ( #1780 )
...
* changed exxpect to expect wherever applicable
* Merged with latest branch
* Updated merkleTree helper to latest master branch
* Made linting fixes
* Fix for test build
* updated for Coverage
* Updated Address.test.js
* Undo package-lock changes.
6 years ago
a71c3bce32
Update test-helpers to v0.4.0. ( #1770 )
6 years ago
3682c6575c
Added message string for require() ( #1704 )
...
* Error handling in ERC20 and ERC721
* Added message string for require.
* Fixed solhint errors.
* Updated PR as per issue #1709
* changes as per #1709 and openzeppelin forum.
* Changes in require statement
* Changes in require statement
* build pipeline fix
* Changes as per @nventuro's comment.
* Update revert reason strings.
* Fianal update of revert reason strings.
* WIP: Updating reason strings in test cases
* WIP: Added changes to ERC20 and ERC721
* Fixes linting errors in *.tes.js files
* Achieved 100% code coverage
* Updated the test cases with shouldFail.reverting.withMessage()
* Fix package-lock.
* address review comments
* fix linter issues
* fix remaining revert reasons
6 years ago
19c705d928
Fix/rename anyone account #1357 ( #1718 )
...
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* changing anyone to other
* changing anyone to other
6 years ago
Hadrien Croubois
Francisco
Renan Souza
Ernesto García
Helder Sepulveda
Brandon Valosek
Francisco Giordano
dibi91
Nicolás Venturo
Julian M. Rodriguez
Yohann Pereira
Balaji Pachai
ckshei