a72c9561b9
Finalize test migration: remove legacy dependencies and test helpers ( #4797 )
1 year ago
9702b67ce1
Migrate utils-cryptography to ethers ( #4749 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: ernestognw <ernestognw@gmail.com>
1 year ago
0053ee040a
Move `ECDSA` message hash methods to its own `MessageHashUtils` library ( #4430 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
b425a72240
Replace revert strings with custom errors ( #4261 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco <fg@frang.io>
2 years ago
53235263a3
Implement `0x00` version of EIP-191 in ECDSA Library ( #4063 )
2 years ago
a28aafdc85
Use Prettier for JS files ( #3913 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
2 years ago
c1d9da4052
Use hardhat-exposed to reduce the need for mocks ( #3666 )
...
Co-authored-by: Francisco <fg@frang.io>
2 years ago
324eda228c
Remove redundant ECDSA constraint ( #3591 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
3 years ago
d693d89d99
Fix ECDSA signature malleability ( #3610 )
3 years ago
faf5820f03
Fix many spelling errors ( #3274 )
3 years ago
5b28259dac
#890 : Add ECDSA.toEthSignedMessageHash(bytes) for abritrary length message hashing ( #2865 )
...
* #890 : Add ECDSA#toEthSignedMessage for bytes type
* refactor
* add test, refactor
* select overloaded function explicitly
* use short test message string
* add changelog entry
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
3 years ago
541e82144f
Optimize EOA signature verification ( #2661 )
...
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
1488d4f678
Improve ECDSA tests and docs ( #2619 )
4 years ago
555be63c90
Add support for EIP2098 "short signatures" in the ECDSA library ( #2582 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
24a0bc23cf
Reorganize the repo structure ( #2503 )
...
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
4 years ago
f06738828b
Migrate to Hardhat ( #2397 )
4 years ago
ace35fdeda
Update all dependencies transitively ( #2363 )
4 years ago
65e4ffde58
Make ECDSA.recover revert on error. ( #2114 )
...
* Make ECDSA.recover revert on error
* Removed unused test
* Remove duplicate line
* Add tests for invalid signatures
* Fix linter errors
* Add changelog entry
5 years ago
5f92adc2e7
Migrate from truffle to test-environment ( #2007 )
...
* Sketch
* Migrate all tests to test-env
* Finish migration to test-env
* Add config
* Work on GSN tests
* Migrate to newer test-env version and loader syntax
* Add GSN setup
* Finish test-env migration
* Setup coverage using test-env
* Migrate to npm package
* Fix package.json
* Add compile step to CI
* Add comment on coverage setup
* Remove dependency on @truffle/contract
* Fix package-lock merge
* Fix linter errors
* Upgrade test-environment, depend locally on ganche-coverage
* Improve coverage script
* Improve sign.js API
* Move accounts destructuring to describe block
* Switch to prebuilt ethereumjs-vm package
* Upgrade test-enviroment version
* use workspace in circleci config
* remove unnecessary npx
5 years ago
3274d9db00
Upgrade to @openzeppelin/test-helpers@0.5.1 ( #1942 )
5 years ago
226c6bd8f1
Remove SignatureBouncer from drafts ( #1879 )
...
* Remove SignatureBouncer
* Update changelog entry
* Fix coverage
* Update CHANGELOG.md
6 years ago
489d2e85f1
Replace chai.should with chai.expect ( #1780 )
...
* changed exxpect to expect wherever applicable
* Merged with latest branch
* Updated merkleTree helper to latest master branch
* Made linting fixes
* Fix for test build
* updated for Coverage
* Updated Address.test.js
* Undo package-lock changes.
6 years ago
a71c3bce32
Update test-helpers to v0.4.0. ( #1770 )
6 years ago
3682c6575c
Added message string for require() ( #1704 )
...
* Error handling in ERC20 and ERC721
* Added message string for require.
* Fixed solhint errors.
* Updated PR as per issue #1709
* changes as per #1709 and openzeppelin forum.
* Changes in require statement
* Changes in require statement
* build pipeline fix
* Changes as per @nventuro's comment.
* Update revert reason strings.
* Fianal update of revert reason strings.
* WIP: Updating reason strings in test cases
* WIP: Added changes to ERC20 and ERC721
* Fixes linting errors in *.tes.js files
* Achieved 100% code coverage
* Updated the test cases with shouldFail.reverting.withMessage()
* Fix package-lock.
* address review comments
* fix linter issues
* fix remaining revert reasons
6 years ago
19c705d928
Fix/rename anyone account #1357 ( #1718 )
...
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* replacing all instances of from: anyone with from: other
* changing anyone to other
* changing anyone to other
6 years ago
79dd498b16
Signature Malleability: ( #1622 )
...
* Transaction Malleability:
If you allow for both values 0/1 and 27/28, you allow two different
signatures both resulting in a same valid recovery. (r,s,0/1) and
(r,s,27/28) would both be valid, recover the same public key and sign
the same data. Furthermore, given (r,s,0/1), (r,s,27/28) can be
constructed by anyone.
* Transaction Malleability:
EIP-2 still allows signature malleabality for ecrecover(), remove this
possibility and force the signature to be unique.
* Added a reference to appendix F to the yellow paper and improved
comment.
* better test description for testing the version 0, which returns
a zero address
* Check that the conversion from 0/1 to 27/28 only happens if its 0/1
* improved formatting
* Refactor ECDSA code a bit.
* Refactor ECDSA tests a bit.
* Add changelog entry.
* Add high-s check test.
6 years ago
3e82db2f6f
Migration to truffle 5 (and web3 1.0 (and BN)) ( #1601 )
...
* Now compiling using truffle 5.
* Migrated some test files, missing BN scientific notation usage.
* Now using BN time values.
* Migrate ERC20 tests.
* Migrate all ERC20 tests.
* Migrate utils, payment and ownership tests.
* All tests save ERC721 migrated.
* Migrated ERC721 tests.
* Fix lint errors.
* Delete old test helpers.
* Fix remaining crowdsale tests.
* Fix signature bouncer tests.
* Update how constants is used.
* Compile script pre-removes the build dir.
* Fix SafeMath tests.
* Revert "Compile script pre-removes the build dir."
This reverts commit 247e745113
6 years ago
70fd243e3b
Test setup helper added ( #1482 )
...
* signing prefix added
* Minor improvement
* Tests changed
* Successfully tested
* Minor improvements
* Minor improvements
* Revert "Dangling commas are now required. (#1359 )"
This reverts commit a6889776f4fixes #1404
* approve failing test
* suggested changes done
* ISafeERC20 removed
* conflict fixes
* fixes #1205
* minor change
* suggested changes
* reviewed changes
* final update
6 years ago
26f9cc8e74
Moved some test files around to better reflect the directory layout. ( #1428 )
...
(cherry picked from commit d8ab8a00f2
6 years ago
7cd0d5a452
Replaced assertJump, assertRevert and expectThrow with shouldFail. ( #1363 )
...
* Replaced assertJump, assertRevert and expectThrow with shouldFail.
* Fixed linter errors.
* Fixed typo.
* Made the helpers async.
(cherry picked from commit b0da0fded0
6 years ago
d8ab8a00f2
Moved some test files around to better reflect the directory layout. ( #1428 )
6 years ago
b0da0fded0
Replaced assertJump, assertRevert and expectThrow with shouldFail. ( #1363 )
...
* Replaced assertJump, assertRevert and expectThrow with shouldFail.
* Fixed linter errors.
* Fixed typo.
* Made the helpers async.
6 years ago
08bf6bbed9
Add missing tests to ECSDA ( #1248 )
...
* fix: refactor sign.js and related tests
* fix: remove unused dep
* fix: update package.json correctly
* Add missing tests to ECRecovery
* fix lint
* Reorganize the tests
* Reuse signature
* fix static errors
* Apply suggestions by @frangion and @nventuro
* Remove only
* More suggestions
* Remove unnecessary max-len
* remove only
(cherry picked from commit 75c0a59bb4
6 years ago
75c0a59bb4
Add missing tests to ECSDA ( #1248 )
...
* fix: refactor sign.js and related tests
* fix: remove unused dep
* fix: update package.json correctly
* Add missing tests to ECRecovery
* fix lint
* Reorganize the tests
* Reuse signature
* fix static errors
* Apply suggestions by @frangion and @nventuro
* Remove only
* More suggestions
* Remove unnecessary max-len
* remove only
6 years ago
2441fd7d17
Move contracts to subdirectories ( #1253 )
...
* Move contracts to subdirectories
Fixes #1177 .
This Change also removes the LimitBalance contract.
* fix import
* move MerkleProof to cryptography
* Fix import
7 years ago
1c57637fd5
fix: refactor sign.js and related tests ( #1243 )
...
* fix: refactor sign.js and related tests
* fix: remove unused dep
* fix: update package.json correctly
7 years ago
4fb9bb7020
Minor test style improvements ( #1219 )
...
* Changed .eq to .equal
* Changed equal(bool) to .to.be.bool
* Changed be.bool to equal(bool), disallowed unused expressions.
7 years ago
64c324e37c
remove arrow functions from js tests ( #1225 )
7 years ago
20cf885430
No longer assigning awaits to temporary variables. ( #1216 )
7 years ago
ac91af9a6a
Replace all asserts with chai.should ( #1183 )
...
* Moving towards chai.should.
* Fixed failing tests.
* Fixed linter errors.
* Revert package-lock.json changes.
* Fixed failing tests.
* s/eq/equal
* Addressed review comment
7 years ago
4544df47da
All tests now use account names, and dont use accounts[0] (except ERC… ( #1137 )
...
* All tests now use account names, and dont use accounts[0] (except ERC721)
* Added account names to some missing contracts.
7 years ago
567b773242
Prefer const in test files ( #1117 )
...
* Removed all instances of var.
* Sorted eslintrc rules.
* Made eslint rule severity explicit.
* Now prefering const over let.
7 years ago
e6c15b34da
Remove chai-as-promised ( #1116 )
...
* Test: Remove chai-as-promised calls
* Test/Helpers: expectThrow accepts optional message
* NPM: Remove chai-as-promised
* Contracts/DestructibleMock: Fix lint
7 years ago
67b67b791e
Changed before for beforeAll, refactored Bouncer tests. ( #1094 )
...
* Changed before for beforeAll, refactored Bouncer tests.
* Fixed linter errors.
* fix: updates for SignatureBouncer tests and voucher construction
7 years ago
cea2a85a42
Remove Babel ( #1074 )
...
* Test helpers no longer rely on Babel.
* Behaviours are no longer imported.
* Removed Babel dependency.
* Fixed linter errors.
7 years ago
99e4b081dc
ECRecover test should revert because of wrong calldata size ( #1050 )
...
* Assume that token is mintable.
* ECRecover test should revert because of wrong calldata size
* fix: use expectThrow
* fix: ignore failing test until solc^0.5.0
7 years ago
6a7114fdb4
Bouncer contract implementation ( #883 )
...
* feat: implement bouncer contracts
* fix: rename Bouncer to SignatureBouncer
7 years ago
a7e91856f3
Update to Truffle 4.1.5 and Ganache 6.1.0 ( #876 )
...
* Update to ganache-cli v6.1.0 and truffle v4.1.0
* Update to stable version of ganache-cli
* fix: update event emission warning
- Fix event emission warnings for solidity 4.21 after truffle has been
updated to use this version
* fix pr review comments
* update to truffle v4.1.5
* update package-lock
* add additional emit keywords
* update solidity-coverage to 0.4.15
* update to solium 1.1.6
* fix MerkleProof coverage analysis by testing through wrapper
* change version pragma to ^0.4.21
* fix solium linting errors
7 years ago
e299a7950e
Change ECRecovery recover method's visibility to internal ( #818 )
...
* Change ECRecovery recover method's visibility to internal
* Adopt the test
* Remove unused imports
7 years ago
f4228f1b49
fix: reference contract name rather than filepath ( #698 )
7 years ago
Hadrien Croubois
Renan Souza
Ernesto García
Yamen Merhi
Francisco
t11s
Francisco
Pandapip1
td-bn
Anton Bukov
Nicolás Venturo
Yohann Pereira
Balaji Pachai
ckshei
Thomas Bocek
Aniket
Leo Arias
Matt Condon
jacob
Justus Perlwitz
Leonardo
Chenyang Wu