From cc5f88d3eb5433009e20b7d50f3a621889e68ce7 Mon Sep 17 00:00:00 2001 From: yann300 Date: Wed, 8 Jul 2020 11:12:30 +0200 Subject: [PATCH 1/2] resolve with compilation error instead of rejecting --- src/app/compiler/compiler-helpers.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/app/compiler/compiler-helpers.js b/src/app/compiler/compiler-helpers.js index d0c7e13fdd..d4783fe413 100644 --- a/src/app/compiler/compiler-helpers.js +++ b/src/app/compiler/compiler-helpers.js @@ -12,7 +12,7 @@ export const compile = async (compilationTargets, settings) => { compiler.set('language', settings.language) compiler.loadVersion(canUseWorker(settings.version), urlFromVersion(settings.version)) compiler.event.register('compilationFinished', (success, compilationData, source) => { - if (!success) return reject(compilationData) + if (!success) return resolve({ compilationData, source }) resolve(new CompilerAbstract(settings.version, compilationData, source)) }) compiler.event.register('compilerLoaded', _ => compiler.compile(compilationTargets, '')) From d957d0e560415a31cc146c5ec57dd70baa868ddc Mon Sep 17 00:00:00 2001 From: yann300 Date: Wed, 8 Jul 2020 11:18:59 +0200 Subject: [PATCH 2/2] always resolve with compiler abstract --- src/app/compiler/compiler-helpers.js | 1 - 1 file changed, 1 deletion(-) diff --git a/src/app/compiler/compiler-helpers.js b/src/app/compiler/compiler-helpers.js index d4783fe413..95eebcad26 100644 --- a/src/app/compiler/compiler-helpers.js +++ b/src/app/compiler/compiler-helpers.js @@ -12,7 +12,6 @@ export const compile = async (compilationTargets, settings) => { compiler.set('language', settings.language) compiler.loadVersion(canUseWorker(settings.version), urlFromVersion(settings.version)) compiler.event.register('compilationFinished', (success, compilationData, source) => { - if (!success) return resolve({ compilationData, source }) resolve(new CompilerAbstract(settings.version, compilationData, source)) }) compiler.event.register('compilerLoaded', _ => compiler.compile(compilationTargets, ''))