From 10fb0e52e0e9e65b1216ed4f44a3090aafe8bbb7 Mon Sep 17 00:00:00 2001 From: yann300 Date: Thu, 14 Feb 2019 17:47:19 +0100 Subject: [PATCH] remix-tabs --- package.json | 1 + src/app/panels/tab-proxy.js | 80 ++++++++++++++++++------------------- 2 files changed, 39 insertions(+), 42 deletions(-) diff --git a/package.json b/package.json index 90e937e818..570831afab 100644 --- a/package.json +++ b/package.json @@ -45,6 +45,7 @@ "remix-lib": "0.4.1", "remix-plugin": "latest", "remix-solidity": "0.3.1", + "remix-tabs": "^1.0.0", "remix-tests": "0.1.1", "remixd": "0.1.8-alpha.6", "request": "^2.83.0", diff --git a/src/app/panels/tab-proxy.js b/src/app/panels/tab-proxy.js index fdcb1eb0fd..dad1234045 100644 --- a/src/app/panels/tab-proxy.js +++ b/src/app/panels/tab-proxy.js @@ -2,6 +2,8 @@ var yo = require('yo-yo') var $ = require('jquery') const EventEmitter = require('events') +require('remix-tabs') + var styles = require('./styles/editor-panel-styles') var css = styles.css @@ -11,7 +13,6 @@ export class TabProxy { this.fileManager = fileManager this.appManager = appManager this.editor = editor - this.activeEntity this.entities = {} this.data = {} this._view = {} @@ -26,27 +27,26 @@ export class TabProxy { }) fileManager.event.register('currentFileChanged', (file) => { - const filesEl = document.querySelector('#files') - if (!filesEl.querySelector(`li[path="${file}"]`)) { - this.addTab(file, () => { - this.fileManager.switchFile(file) - this.event.emit('switchFile', file) - }, - () => { - this.fileManager.closeFile(file) - this.event.emit('closeFile', file) - }) - } - this.active(file) // this put the css class "active" + this.addTab(file, () => { + this.fileManager.switchFile(file) + this.event.emit('switchFile', file) + }, + () => { + this.fileManager.closeFile(file) + this.event.emit('closeFile', file) + }) }) fileManager.event.register('fileRenamed', (oldName, newName) => { - const filesEl = document.querySelector('#files') - var file = filesEl.querySelector(`li[path="${oldName}"]`) - if (file) { - filesEl.setAttribute('path', file) - file.querySelector(`.name`).innerHTML = newName - } + this.removeTab(oldName) + this.addTab(newName, () => { + this.fileManager.switchFile(newName) + this.event.emit('switchFile', newName) + }, + () => { + this.fileManager.closeFile(newName) + this.event.emit('closeFile', newName) + }) }) appStore.event.on('activate', (name) => { @@ -67,31 +67,20 @@ export class TabProxy { } addTab (name, switchTo, close, kind) { - const filesEl = document.querySelector('#files') - filesEl.appendChild(yo`
  • ${name}
  • `) + var slash = name.split('/') + let title = name.indexOf('/') !== -1 ? slash[slash.length - 1] : name + this._view.filetabs.addTab({ + id: name, + title, + icon: '', + tooltip: name + }) this._handlers[name] = { switchTo, close } } removeTab (name) { - const filesEl = document.querySelector('#files') - var file = filesEl.querySelector(`li[path="${name}"]`) - if (file) { - filesEl.removeChild(file) - delete this._handlers[name] - } - } - - active (name) { - var filesEl = document.querySelector('#files') - let file = filesEl.querySelector(`li[path="${this.activeEntity}"]`) - if (file) $(file).removeClass('active') - if (name) { - let active = filesEl.querySelector(`li[path="${name}"]`) - if (active) { - $(active).addClass('active') - this.activeEntity = name - } - } + this._view.filetabs.closeTab(name) + delete this._handlers[name] } addHandler (type, fn) { @@ -99,7 +88,15 @@ export class TabProxy { } renderTabsbar () { - this._view.filetabs = yo`` + this._view.filetabs = yo`` + this._view.filetabs.addEventListener('tabClosed', (id) => { + if (this._handlers[id]) this._handlers[id].close() + }) + this._view.filetabs.addEventListener('tabActivated', (id) => { + if (this._handlers[id]) this._handlers[id].switchTo() + }) + + this._view.filetabs.canAdd = false this._view.tabs = yo`
    @@ -133,7 +130,6 @@ export class TabProxy { ev.preventDefault() var name = $(this).find('.name').text() self._handlers[name].switchTo() - self.active(name) return false })