Merge pull request #1335 from ethereum/copyfix

href shouldn't work
pull/5370/head
bunsenstraat 3 years ago committed by GitHub
commit 161a217eaa
  1. 6
      libs/remix-ui/clipboard/src/lib/copy-to-clipboard/copy-to-clipboard.tsx

@ -6,7 +6,7 @@ import './copy-to-clipboard.css'
export const CopyToClipboard = ({ content, tip='Copy', icon='fa-copy', ...otherProps }) => { export const CopyToClipboard = ({ content, tip='Copy', icon='fa-copy', ...otherProps }) => {
const [message, setMessage] = useState(tip) const [message, setMessage] = useState(tip)
const handleClick = () => { const handleClick = (event) => {
if (content && content !== '') { // module `copy` keeps last copied thing in the memory, so don't show tooltip if nothing is copied, because nothing was added to memory if (content && content !== '') { // module `copy` keeps last copied thing in the memory, so don't show tooltip if nothing is copied, because nothing was added to memory
try { try {
if (typeof content !== 'string') { if (typeof content !== 'string') {
@ -20,6 +20,8 @@ export const CopyToClipboard = ({ content, tip='Copy', icon='fa-copy', ...otherP
} else { } else {
setMessage('Cannot copy empty content!') setMessage('Cannot copy empty content!')
} }
event.preventDefault()
return false
} }
const reset = () => { const reset = () => {
@ -27,7 +29,7 @@ export const CopyToClipboard = ({ content, tip='Copy', icon='fa-copy', ...otherP
} }
return ( return (
<a href="#" onClick={handleClick} onMouseLeave={reset}> <a href='#' onClick={handleClick} onMouseLeave={reset}>
<OverlayTrigger placement="right" overlay={ <OverlayTrigger placement="right" overlay={
<Tooltip id="overlay-tooltip"> <Tooltip id="overlay-tooltip">
{ message } { message }

Loading…
Cancel
Save