From 38f29e25a7ff5ab4d68d82cc47e6bcc3e541f7dc Mon Sep 17 00:00:00 2001 From: Joseph Izang Date: Tue, 26 Oct 2021 02:02:29 +0100 Subject: [PATCH] address review comments from @ioedeveloper --- .eslintrc.json | 35 ------------------- .../src/lib/components/Icon.tsx | 3 +- .../src/lib/remix-ui-vertical-icons-panel.tsx | 7 ++-- 3 files changed, 4 insertions(+), 41 deletions(-) delete mode 100644 .eslintrc.json diff --git a/.eslintrc.json b/.eslintrc.json deleted file mode 100644 index 06cc47d9a2..0000000000 --- a/.eslintrc.json +++ /dev/null @@ -1,35 +0,0 @@ -{ - "root": true, - "ignorePatterns": ["**/*"], - "plugins": ["@nrwl/nx"], - "overrides": [ - { - "files": ["*.ts", "*.tsx", "*.js", "*.jsx"], - "rules": { - "@nrwl/nx/enforce-module-boundaries": [ - "error", - { - "enforceBuildableLibDependency": true, - "allow": [], - "depConstraints": [ - { - "sourceTag": "*", - "onlyDependOnLibsWithTags": ["*"] - } - ] - } - ] - } - }, - { - "files": ["*.ts", "*.tsx"], - "extends": ["plugin:@nrwl/nx/typescript"], - "rules": {} - }, - { - "files": ["*.js", "*.jsx"], - "extends": ["plugin:@nrwl/nx/javascript"], - "rules": {} - } - ] -} diff --git a/libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx b/libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx index f47946fd36..5bc02b636f 100644 --- a/libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx +++ b/libs/remix-ui/vertical-icons-panel/src/lib/components/Icon.tsx @@ -3,8 +3,9 @@ // eslint-disable-next-line @typescript-eslint/no-unused-vars import VerticalIconsContextMenu from '../vertical-icons-context-menu' // eslint-disable-next-line @typescript-eslint/no-unused-vars -import React, { Fragment, SyntheticEvent, useRef, useState } from 'react' +import React, { Fragment, SyntheticEvent, useEffect, useRef, useState } from 'react' import { VerticalIcons } from 'libs/remix-ui/vertical-icons-panel/types/vertical-icons-panel' +// import * as helper from '../../../../../../apps/remix-ide/src/lib/helper' interface IconProps { verticalIconPlugin: VerticalIcons diff --git a/libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.tsx b/libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.tsx index 746472b194..0080d3e230 100644 --- a/libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.tsx +++ b/libs/remix-ui/vertical-icons-panel/src/lib/remix-ui-vertical-icons-panel.tsx @@ -1,11 +1,9 @@ /* eslint-disable no-use-before-define */ /* eslint-disable @typescript-eslint/no-unused-vars */ -import React, { +import { Fragment, useEffect, - useReducer, - useRef, - useState + useRef } from 'react' import './remix-ui-vertical-icons-panel.css' @@ -25,7 +23,6 @@ export function RemixUiVerticalIconsPanel ({ }: RemixUiVerticalIconsPanelProps) { const scrollableRef = useRef() const iconPanelRef = useRef() - // const [first] = useState(localStorage.getItem('firstTime')) function onThemeChanged (themeType: any) { const invert = themeType === 'dark' ? 1 : 0