From 4adce90817f356c4a9c87f72b038beb9f959856e Mon Sep 17 00:00:00 2001 From: LianaHus Date: Thu, 29 Nov 2018 16:33:00 +0100 Subject: [PATCH] fixes tests --- src/app/staticanalysis/staticAnalysisView.js | 4 ++-- src/app/tabs/test-tab.js | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js index 3f3e8bfc2e..38c464d207 100644 --- a/src/app/staticanalysis/staticAnalysisView.js +++ b/src/app/staticanalysis/staticAnalysisView.js @@ -150,9 +150,9 @@ staticAnalysisView.prototype.checkAll = function (event) { return } var checkBoxes = this.view.querySelectorAll('[name="staticanalysismodule"]') - var selectionsCount = this.view.querySelectorAll('[name="staticanalysismodule"]:checked').length; + var selectionsCount = this.view.querySelectorAll('[name="staticanalysismodule"]:checked').length // checks/unchecks all - checkBoxes.forEach(checkbox => checkbox.checked = !selectionsCount) + checkBoxes.forEach((checkbox) => { checkbox.checked = !selectionsCount }) event.target.checked = !selectionsCount } diff --git a/src/app/tabs/test-tab.js b/src/app/tabs/test-tab.js index a70bfdcc96..598ab2d711 100644 --- a/src/app/tabs/test-tab.js +++ b/src/app/tabs/test-tab.js @@ -137,10 +137,11 @@ module.exports = class TestTab { } function toggleCheckbox (eChecked, test) { - if (!self.data.selectedTests) + if (!self.data.selectedTests) { self.data.selectedTests = document.querySelectorAll('.singleTest:checked') + } let selectedTests = self.data.selectedTests - selectedTests = eChecked ? [...selectedTests, test] : selectedTests.filter(el => {el !== test}) + selectedTests = eChecked ? [...selectedTests, test] : selectedTests.filter(el => el !== test) self.data.selectedTests = selectedTests let checkAll = document.querySelector('[id="checkAllTests"]') if (eChecked) { @@ -152,11 +153,11 @@ module.exports = class TestTab { function checkAll (event) { let checkBoxes = document.querySelectorAll('.singleTest') - const checkboxesLabels = document.querySelectorAll(".singleTestLabel") + const checkboxesLabels = document.querySelectorAll('.singleTestLabel') const selectionsCount = document.querySelectorAll('.singleTest:checked').length // checks/unchecks all for (let i = 0; i < checkBoxes.length; i++) { - checkBoxes[i].checked = !selectionsCount; + checkBoxes[i].checked = !selectionsCount toggleCheckbox(!selectionsCount, checkboxesLabels[i].innerText) } event.target.checked = !selectionsCount