Merge pull request #1967 from ethereum/issue#1966-createvmaccount_api

Use an object for createVMAccount

src/universal-dapp.js

@@ -82,13 +82,18 @@ module.exports = class UniversalDApp extends UdappApi {
     this.transactionContextAPI = transactionContextAPI
   }
 
-  createVMAccount (privateKey, balance, cb) {
+  /**
-    return new Promise((resolve, reject) => {
+   * Create a VM Account
-      if (executionContext.getProvider() !== 'vm') return reject('plugin API does not allow creating a new account through web3 connection. Only vm mode is allowed')
+   * @param {{privateKey: string, balance: string}} newAccount The new account to create
-      this._addAccount(privateKey, balance)
+   */
-      privateKey = Buffer.from(privateKey, 'hex')
+  createVMAccount (newAccount) {
-      resolve('0x' + ethJSUtil.privateToAddress(privateKey).toString('hex'))
+    const { privateKey, balance } = newAccount
-    })
+    if (executionContext.getProvider() !== 'vm') {
+      throw new Error('plugin API does not allow creating a new account through web3 connection. Only vm mode is allowed')
+    }
+    this._addAccount(privateKey, balance)
+    const privKey = Buffer.from(privateKey, 'hex')
+    return '0x' + ethJSUtil.privateToAddress(privKey).toString('hex')
   }
 
   newAccount (password, passwordPromptCb, cb) {

test-browser/plugin/plugin.js

@@ -44,7 +44,10 @@ window.onload = function () {
   })
 
   document.querySelector('input#testaccountcreation').addEventListener('click', function () {
-    extension.call('udapp', 'createVMAccount', ['71975fbf7fe448e004ac7ae54cad0a383c3906055a75468714156a07385e96ce', '0x56BC75E2D63100000'],
+    extension.call('udapp', 'createVMAccount', [{
+      privateKey: '71975fbf7fe448e004ac7ae54cad0a383c3906055a75468714156a07385e96ce',
+      balance: '0x56BC75E2D63100000'
+    }],
     function (error, result) { console.log(error, result) })
   })
 

test-browser/plugin/remix.js

@@ -64,7 +64,10 @@ window.onload = function () {
       action: 'request',
       key: 'udapp',
       type: 'createVMAccount',
-      value: ['71975fbf7fe448e004ac7ae54cad0a383c3906055a75468714156a07385e96ce', '0x56BC75E2D63100000'],
+      value: [{
+        privateKey: '71975fbf7fe448e004ac7ae54cad0a383c3906055a75468714156a07385e96ce',
+        balance: '0x56BC75E2D63100000'
+      }],
       id: 38
     }), '*')
   })