Merge pull request #2725 from ethereum/firefox-libraryDeployment

Fix Failing Library Deployment Test

src/app/ui/universal-dapp-ui.js

@@ -54,7 +54,7 @@ UniversalDAppUI.prototype.renderInstanceFromABI = function (contractABI, address
   let self = this
   address = (address.slice(0, 2) === '0x' ? '' : '0x') + address.toString('hex')
   address = ethJSUtil.toChecksumAddress(address)
-  var instance = yo`<div class="instance run-instance border-dark ${css.instance} ${css.hidesub}" id="instance${address}"></div>`
+  var instance = yo`<div class="instance run-instance border-dark ${css.instance} ${css.hidesub}" id="instance${address}" data-shared="universalDappUiInstance"></div>`
   const context = this.blockchain.context()
 
   var shortAddress = helper.shortenAddress(address)

test-browser/commands/getAddressAtPosition.js

@@ -14,9 +14,12 @@ class GetAddressAtPosition extends EventEmitter {
 }
 
 function getAddressAtPosition (browser, index, callback) {
-  index = index + 2
-  browser.execute(function (index) {
-    return document.querySelector('.instance:nth-of-type(' + index + ')').getAttribute('id').replace('instance', '')
+  browser.waitForElementPresent('*[data-shared="universalDappUiInstance"]')
+  .execute(function (index) {
+    const deployedContracts = document.querySelectorAll('*[data-shared="universalDappUiInstance"]')
+    const id = deployedContracts[index].getAttribute('id')
+
+    return id.replace('instance', '')
   }, [index], function (result) {
     callback(result.value)
   })

test-browser/tests/libraryDeployment.js

@@ -52,6 +52,7 @@ module.exports = {
               })
             })
           })
+          .end()
   },
   tearDown: sauce
 }