From b360ebe02a01d16697eded0fd8e190718037cbd3 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Fri, 26 Apr 2019 13:31:54 +0200
Subject: [PATCH 01/11] remove status

---
 src/app/components/vertical-icons-component.js | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/app/components/vertical-icons-component.js b/src/app/components/vertical-icons-component.js
index 0d6a44743e..b85d84fc6c 100644
--- a/src/app/components/vertical-icons-component.js
+++ b/src/app/components/vertical-icons-component.js
@@ -90,7 +90,7 @@ class VerticalIconComponent {
       let key = helper.checkSpecialChars(status.key) ? '' : status.key
       let type = helper.checkSpecialChars(status.type) ? '' : status.type
       let title = helper.checkSpecialChars(status.title) ? '' : status.title
-      el.appendChild(yo`<span title="${title}" class="fas fa-${key} ${css.status} text-${type}" aria-hidden="true"></span>`)
+      el.appendChild(yo`<span title="${title}" class="badge badge-pill badge-${type} ${css.status}" aria-hidden="true">3</span>`)
 
       // el.classList = "" doesn't work on all browser use instead
       var classList = el.classList
@@ -99,8 +99,8 @@ class VerticalIconComponent {
       }
 
       el.classList.add(`${css.icon}`)
-      el.classList.add('border')
-      el.classList.add(`border-${type}`)
+      //el.classList.add('border')
+      //el.classList.add(`border-${type}`)
     }
   }
 

From 640882f851bf04d8bcb662fc4af318bbde03dfa5 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Thu, 2 May 2019 22:45:45 +0200
Subject: [PATCH 02/11] new satus icons

---
 src/app/tabs/analysis-tab.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/app/tabs/analysis-tab.js b/src/app/tabs/analysis-tab.js
index 196252d45a..54cd001f05 100644
--- a/src/app/tabs/analysis-tab.js
+++ b/src/app/tabs/analysis-tab.js
@@ -29,10 +29,12 @@ class AnalysisTab extends BaseApi {
   render () {
     if (!this.staticanalysis) this.staticanalysis = new StaticAnalysis()
     this.staticanalysis.event.register('staticAnaysisWarning', (count) => {
-      if (count) {
-        this.events.emit('statusChanged', {key: 'exclamation-triangle', title: count + ' warnings', type: 'warning'})
-      } else {
+      if (count > 0) {
+        this.events.emit('statusChanged', {key: count.toString(), title: count + ' warnings', type: 'warning'})
+      } else if (count === 0) {
         this.events.emit('statusChanged', {key: 'check', title: 'no warning', type: 'success'})
+      } else {
+        this.events.emit('statusChanged', {key: '', title: '', type: ''})
       }
     })
     this.registry.put({api: this.staticanalysis, name: 'staticanalysis'})

From 1844d2dd05ece3ac8ff6e1ad0b84fed6953ceabc Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Fri, 26 Apr 2019 20:04:14 +0200
Subject: [PATCH 03/11] new satus icons

---
 .../components/vertical-icons-component.js    | 33 ++++++++++++++++---
 src/app/staticanalysis/staticAnalysisView.js  |  8 +++--
 src/app/tabs/compile-tab.js                   |  2 +-
 3 files changed, 34 insertions(+), 9 deletions(-)

diff --git a/src/app/components/vertical-icons-component.js b/src/app/components/vertical-icons-component.js
index b85d84fc6c..41c41b9067 100644
--- a/src/app/components/vertical-icons-component.js
+++ b/src/app/components/vertical-icons-component.js
@@ -52,7 +52,14 @@ class VerticalIconComponent {
   listenOnStatus (api) {
     if (!api.events) return
     const fn = (status) => {
-      this.setIconStatus(api.profile.name, status)
+      if (
+        status.type === 'warning' ||
+        status.type === 'danger' ||
+        status.key === 'code' ||
+        status.key === 'check' ||
+        (status.key === '' && status.type === '' && status.title === '')) {
+        this.setIconStatus(api.profile.name, status)
+      }
     }
     this.iconStatus[api.profile.name] = fn
     api.events.on('statusChanged', this.iconStatus[api.profile.name])
@@ -90,17 +97,33 @@ class VerticalIconComponent {
       let key = helper.checkSpecialChars(status.key) ? '' : status.key
       let type = helper.checkSpecialChars(status.type) ? '' : status.type
       let title = helper.checkSpecialChars(status.title) ? '' : status.title
-      el.appendChild(yo`<span title="${title}" class="badge badge-pill badge-${type} ${css.status}" aria-hidden="true">3</span>`)
+
+      let classes = css.status
+      switch (key) {
+        case 'check':
+          classes += ' badge badge-pill badge-' + type + ' text-' + type
+          break
+        case 'code':
+          classes += ' fas fa-sync text-' + type
+          break
+        default:
+          classes += ' badge badge-pill badge-' + type
+      }
+
+      el.appendChild(yo`<span
+        title="${title}"
+        class="${classes}"
+        aria-hidden="true"
+      >
+      ${key === 'code' ? '' : key === 'check' ? 'o' : key}
+      </span>`)
 
       // el.classList = "" doesn't work on all browser use instead
       var classList = el.classList
       while (classList.length > 0) {
         classList.remove(classList.item(0))
       }
-
       el.classList.add(`${css.icon}`)
-      //el.classList.add('border')
-      //el.classList.add(`border-${type}`)
     }
   }
 
diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index beace33ca6..d44b2108da 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -99,7 +99,7 @@ staticAnalysisView.prototype.run = function () {
   var warningContainer = $('#staticanalysisresult')
   warningContainer.empty()
   var self = this
-  if (this.lastCompilationResult) {
+  if (this.lastCompilationResult && selected.length) {
     var warningCount = 0
     this.runner.run(this.lastCompilationResult, selected, function (results) {
       results.map(function (result, i) {
@@ -126,8 +126,10 @@ staticAnalysisView.prototype.run = function () {
       self.event.trigger('staticAnaysisWarning', [warningCount])
     })
   } else {
-    warningContainer.html('No compiled AST available')
-    self.event.trigger('staticAnaysisWarning', [0])
+    if (selected.length) {
+      warningContainer.html('No compiled AST available')
+    }
+    self.event.trigger('staticAnaysisWarning', [-1])
   }
 }
 
diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index e5cb75a7ac..3a8275ca1f 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -122,7 +122,7 @@ class CompileTab extends CompilerApi {
           )
         })
       } else {
-        this.events.emit('statusChanged', {key: 'exclamation', title: 'compilation failed', type: 'danger'})
+        this.events.emit('statusChanged', {key: data.errors.length.toString(), title: 'compilation failed', type: 'danger'})
       }
       // Update contract Selection
       let contractMap = {}

From 78c6eba428b1eea3798c14674bf7918fea50c9a4 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Fri, 26 Apr 2019 20:33:30 +0200
Subject: [PATCH 04/11] new icon for check

---
 src/app/components/vertical-icons-component.js | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/app/components/vertical-icons-component.js b/src/app/components/vertical-icons-component.js
index 41c41b9067..35a25b1841 100644
--- a/src/app/components/vertical-icons-component.js
+++ b/src/app/components/vertical-icons-component.js
@@ -101,7 +101,7 @@ class VerticalIconComponent {
       let classes = css.status
       switch (key) {
         case 'check':
-          classes += ' badge badge-pill badge-' + type + ' text-' + type
+          classes += ' fas fa-check-circle text-' + type + ' ' + css.statusCheck
           break
         case 'code':
           classes += ' fas fa-sync text-' + type
@@ -115,7 +115,7 @@ class VerticalIconComponent {
         class="${classes}"
         aria-hidden="true"
       >
-      ${key === 'code' ? '' : key === 'check' ? 'o' : key}
+      ${key === 'code' || key === 'check' ? '' : key}
       </span>`)
 
       // el.classList = "" doesn't work on all browser use instead
@@ -285,6 +285,9 @@ const css = csjs`
     bottom: 0;
     right: 0;
   }
+  .statusCheck {
+    font-size: 1.2em;
+  }
   .statusWithBG
     border-radius: 8px;
     background-color: var(--danger);

From eba224cc56017a7450804df45f71f2fe50d02460 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Mon, 29 Apr 2019 20:03:26 +0200
Subject: [PATCH 05/11] added warnings status update

---
 src/app/tabs/compile-tab.js | 11 +++++++++--
 src/app/ui/renderer.js      |  3 ++-
 2 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index 3a8275ca1f..7663adf87a 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -111,7 +111,13 @@ class CompileTab extends CompilerApi {
       if (success) {
         // forwarding the event to the appManager infra
         this.events.emit('compilationFinished', source.target, source, 'soljson', data)
-        this.events.emit('statusChanged', {key: 'check', title: 'compilation successful', type: 'success'})
+        if (data.errors) {
+          this.events.emit('statusChanged', {
+            key: data.errors.length.toString(),
+            title: 'compilation finished successful with warning' + data.errors.length > 1 ? 's' : '',
+            type: 'warning'
+          })
+        } else this.events.emit('statusChanged', {key: 'check', title: 'compilation successful', type: 'success'})
         // Store the contracts
         this.data.contractsDetails = {}
         this.compiler.visitContracts((contract) => {
@@ -122,7 +128,8 @@ class CompileTab extends CompilerApi {
           )
         })
       } else {
-        this.events.emit('statusChanged', {key: data.errors.length.toString(), title: 'compilation failed', type: 'danger'})
+        const count =  errorList.filter(error => error.severity === 'error').length.toString()
+        this.events.emit('statusChanged', {key: count, title: 'compilation failed', type: 'danger'})
       }
       // Update contract Selection
       let contractMap = {}
diff --git a/src/app/ui/renderer.js b/src/app/ui/renderer.js
index 138a32434e..a3914397ff 100644
--- a/src/app/ui/renderer.js
+++ b/src/app/ui/renderer.js
@@ -89,7 +89,8 @@ Renderer.prototype.error = function (message, container, opt) {
 
   var $pre = $(opt.useSpan ? yo`<span></span>` : yo`<pre></pre>`).html(message)
 
-  var $error = $(yo`<div class="sol ${opt.type}"><div class="close"><i class="fas fa-times"></i></div></div>`).prepend($pre)
+  let classList = opt.type === 'error' ? 'alert alert-danger' : 'alert alert-warning'
+  var $error = $(yo`<div class="${classList}"><div class="close"><i class="fas fa-times"></i></div></div>`).prepend($pre)
   $(container).append($error)
 
   $error.click((ev) => {

From da10ef0d00574ab003d5862091af4622f9cd8648 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Mon, 29 Apr 2019 20:04:32 +0200
Subject: [PATCH 06/11] standard

---
 src/app/tabs/compile-tab.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index 7663adf87a..5382ae27eb 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -128,7 +128,7 @@ class CompileTab extends CompilerApi {
           )
         })
       } else {
-        const count =  errorList.filter(error => error.severity === 'error').length.toString()
+        const count = data.errors.filter(error => error.severity === 'error').length.toString()
         this.events.emit('statusChanged', {key: count, title: 'compilation failed', type: 'danger'})
       }
       // Update contract Selection

From e8509680961d060a92b9323d156da365ccf49f1c Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Tue, 30 Apr 2019 10:35:36 +0200
Subject: [PATCH 07/11] compiler result: check error as well

---
 src/app/tabs/compile-tab.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index 5382ae27eb..b445b46356 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -128,7 +128,7 @@ class CompileTab extends CompilerApi {
           )
         })
       } else {
-        const count = data.errors.filter(error => error.severity === 'error').length.toString()
+        const count = (data.errors ? data.errors.filter(error => error.severity === 'error').length : 0 + data.error ? 1 : 0).toString()
         this.events.emit('statusChanged', {key: count, title: 'compilation failed', type: 'danger'})
       }
       // Update contract Selection

From ddfc094a0b22c759a2774ad9c659230a3dec2b76 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Tue, 30 Apr 2019 14:21:18 +0200
Subject: [PATCH 08/11] -restyle errors on compiler tab -check for fatal error
 as well -remove errors after file switch

---
 src/app/staticanalysis/staticAnalysisView.js | 2 +-
 src/app/tabs/compile-tab.js                  | 9 ++++++++-
 src/app/tabs/compileTab/compilerContainer.js | 1 +
 src/app/ui/renderer.js                       | 2 +-
 src/app/ui/styles/renderer-styles.js         | 4 ----
 5 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/app/staticanalysis/staticAnalysisView.js b/src/app/staticanalysis/staticAnalysisView.js
index d44b2108da..bc5b97bb0b 100644
--- a/src/app/staticanalysis/staticAnalysisView.js
+++ b/src/app/staticanalysis/staticAnalysisView.js
@@ -120,7 +120,7 @@ staticAnalysisView.prototype.run = function () {
           }
           warningCount++
           var msg = yo`<span>${location} ${item.warning} ${item.more ? yo`<span><br><a href="${item.more}" target="blank">more</a></span>` : yo`<span></span>`}</span>`
-          self._deps.renderer.error(msg, warningContainer, {type: 'staticAnalysisWarning', useSpan: true})
+          self._deps.renderer.error(msg, warningContainer, {type: 'staticAnalysisWarning alert alert-warning', useSpan: true})
         })
       })
       self.event.trigger('staticAnaysisWarning', [warningCount])
diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index b445b46356..f33a3da743 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -99,14 +99,21 @@ class CompileTab extends CompilerApi {
 
     this.fileManager.events.on('currentFileChanged', (name) => {
       this.compilerContainer.currentFile = name
+      cleanupErrors()
       onContentChanged()
     })
 
     this.fileManager.events.on('noFileSelected', () => {
       this.compilerContainer.currentFile = ''
+      cleanupErrors()
       onContentChanged()
     })
 
+    const cleanupErrors = () => {
+      this._view.errorContainer.innerHTML = ''
+      this.events.emit('statusChanged', {key: '', title: '', type: ''})
+    }
+
     this.compiler.event.register('compilationFinished', (success, data, source) => {
       if (success) {
         // forwarding the event to the appManager infra
@@ -259,7 +266,7 @@ class CompileTab extends CompilerApi {
             var result = yo`<div>${uploaded.map((value) => {
               return yo`<div><b>${value.filename}</b> : <pre>${value.output.url}</pre></div>`
             })}</div>`
-            modalDialogCustom.alert(yo`<span>Metadata published successfully.<br> <pre>${result}</pre> </span>`)
+            modalDialogCustom.alert(yo`<span>Metadata published successfully.<br> <span>${result}</span> </span>`)
           }
         }, (item) => { // triggered each time there's a new verified publish (means hash correspond)
           this.swarmfileProvider.addReadOnly(item.hash, item.content)
diff --git a/src/app/tabs/compileTab/compilerContainer.js b/src/app/tabs/compileTab/compilerContainer.js
index 5ed1bf7bae..6b6ba50c66 100644
--- a/src/app/tabs/compileTab/compilerContainer.js
+++ b/src/app/tabs/compileTab/compilerContainer.js
@@ -40,6 +40,7 @@ class CompilerContainer {
   }
 
   activate () {
+    this.currentFile = this.config.get('currentFile')
     this.listenToEvents()
   }
 
diff --git a/src/app/ui/renderer.js b/src/app/ui/renderer.js
index a3914397ff..6d9ee500a1 100644
--- a/src/app/ui/renderer.js
+++ b/src/app/ui/renderer.js
@@ -90,7 +90,7 @@ Renderer.prototype.error = function (message, container, opt) {
   var $pre = $(opt.useSpan ? yo`<span></span>` : yo`<pre></pre>`).html(message)
 
   let classList = opt.type === 'error' ? 'alert alert-danger' : 'alert alert-warning'
-  var $error = $(yo`<div class="${classList}"><div class="close"><i class="fas fa-times"></i></div></div>`).prepend($pre)
+  var $error = $(yo`<div class="sol ${opt.type} ${classList}"><div class="close"><i class="fas fa-times"></i></div></div>`).prepend($pre)
   $(container).append($error)
 
   $error.click((ev) => {
diff --git a/src/app/ui/styles/renderer-styles.js b/src/app/ui/styles/renderer-styles.js
index 2a143a165a..2cb023dfdf 100644
--- a/src/app/ui/styles/renderer-styles.js
+++ b/src/app/ui/styles/renderer-styles.js
@@ -40,16 +40,12 @@ var css = yo`<style>
 }
 
 .sol.error {
-    background-color: var(--danger);
-    color: var(--white);
 }
 
 .sol.warning {
-  background-color: var(--warning);
 }
 
 .sol.staticAnalysisWarning {
-  background-color: var(--warning);
 }
 
 .sol.success {

From 5afbb84791a82b8623dbfd4176344b22e27301bf Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Tue, 30 Apr 2019 15:59:23 +0200
Subject: [PATCH 09/11] better text color for "Connect to Local Plugin"

---
 src/app/components/plugin-manager-component.js | 2 +-
 src/app/tabs/compile-tab.js                    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/app/components/plugin-manager-component.js b/src/app/components/plugin-manager-component.js
index 2213eceb3b..cd01259664 100644
--- a/src/app/components/plugin-manager-component.js
+++ b/src/app/components/plugin-manager-component.js
@@ -155,7 +155,7 @@ class PluginManagerComponent extends BaseApi {
       <div id='pluginManager'>
         <div class="form-group ${css.pluginSearch}">
           <input onkeyup="${e => this.filterPlugins(e)}" class="form-control" placeholder="Search">
-          <button onclick="${_ => this.openLocalPlugin()}" class="btn btn-sm ${css.localPluginBtn}">
+          <button onclick="${_ => this.openLocalPlugin()}" class="btn btn-sm text-dark ${css.localPluginBtn}">
             Connect to a Local Plugin
           </button>
         </div>
diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index f33a3da743..f59f11e905 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -266,7 +266,7 @@ class CompileTab extends CompilerApi {
             var result = yo`<div>${uploaded.map((value) => {
               return yo`<div><b>${value.filename}</b> : <pre>${value.output.url}</pre></div>`
             })}</div>`
-            modalDialogCustom.alert(yo`<span>Metadata published successfully.<br> <span>${result}</span> </span>`)
+            modalDialogCustom.alert(yo`<span>Metadata published successfully.<br> <pre>${result}</pre> </span>`)
           }
         }, (item) => { // triggered each time there's a new verified publish (means hash correspond)
           this.swarmfileProvider.addReadOnly(item.hash, item.content)

From a9bef6b3eb67b3fab89e5850a1b15b743122439f Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Thu, 2 May 2019 19:32:33 +0200
Subject: [PATCH 10/11] new keys are defined

---
 .../components/vertical-icons-component.js    | 98 ++++++++++++-------
 src/app/tabs/analysis-tab.js                  |  6 +-
 src/app/tabs/compile-tab.js                   | 16 +--
 3 files changed, 71 insertions(+), 49 deletions(-)

diff --git a/src/app/components/vertical-icons-component.js b/src/app/components/vertical-icons-component.js
index 35a25b1841..4c7c8c04f2 100644
--- a/src/app/components/vertical-icons-component.js
+++ b/src/app/components/vertical-icons-component.js
@@ -51,15 +51,18 @@ class VerticalIconComponent {
 
   listenOnStatus (api) {
     if (!api.events) return
+
+    // the list of supported keys. 'none' will remove the status
+    const keys = ['edited', 'success', 'none', 'spinner', 'fail']
+    const types = ['error', 'warning', 'success', 'info', '']
     const fn = (status) => {
-      if (
-        status.type === 'warning' ||
-        status.type === 'danger' ||
-        status.key === 'code' ||
-        status.key === 'check' ||
-        (status.key === '' && status.type === '' && status.title === '')) {
-        this.setIconStatus(api.profile.name, status)
+      if (!types.includes(status.type) && status.type) throw new Error(`type should be ${keys.join()}`)
+      if (!status.key) throw new Error(`status key should be defined`)
+
+      if (typeof status.key === 'string' && (!keys.includes(status.key))) {
+        throw new Error('key should contain either number or ' + keys.join())
       }
+      this.setIconStatus(api.profile.name, status)
     }
     this.iconStatus[api.profile.name] = fn
     api.events.on('statusChanged', this.iconStatus[api.profile.name])
@@ -81,6 +84,33 @@ class VerticalIconComponent {
     this.iconKind[kind || 'other'].appendChild(this.icons[name])
   }
 
+  /**
+   * resolve a classes list for @arg key
+   * @param {Object} key
+   * @param {Object} type
+   */
+  resolveClasses (key, type) {
+    let classes = css.status
+    switch (key) {
+      case 'success':
+        classes += ' fas fa-check-circle text-' + type + ' ' + css.statusCheck
+        break
+      case 'edited':
+        classes += ' fas fa-sync text-' + type + ' ' + css.statusCheck
+        break
+      case 'spinner':
+        classes += ' fas fa-spinner text-' + type + ' ' + css.statusCheck
+        break
+      case 'fail':
+        classes += ' fas fa-exclamation-triangle text-' + type + ' ' + css.statusCheck
+        break
+      default: {
+        classes += ' badge badge-pill badge-' + type
+      }
+    }
+    return classes
+  }
+
   /**
    * Set a new status for the @arg name
    * @param {String} name
@@ -93,38 +123,30 @@ class VerticalIconComponent {
     if (statusEl) {
       el.removeChild(statusEl)
     }
-    if (status.key) {
-      let key = helper.checkSpecialChars(status.key) ? '' : status.key
-      let type = helper.checkSpecialChars(status.type) ? '' : status.type
-      let title = helper.checkSpecialChars(status.title) ? '' : status.title
-
-      let classes = css.status
-      switch (key) {
-        case 'check':
-          classes += ' fas fa-check-circle text-' + type + ' ' + css.statusCheck
-          break
-        case 'code':
-          classes += ' fas fa-sync text-' + type
-          break
-        default:
-          classes += ' badge badge-pill badge-' + type
-      }
+    if (status.key === 'none') return // remove status
 
-      el.appendChild(yo`<span
-        title="${title}"
-        class="${classes}"
-        aria-hidden="true"
-      >
-      ${key === 'code' || key === 'check' ? '' : key}
-      </span>`)
-
-      // el.classList = "" doesn't work on all browser use instead
-      var classList = el.classList
-      while (classList.length > 0) {
-        classList.remove(classList.item(0))
-      }
-      el.classList.add(`${css.icon}`)
-    }
+    let text = ''
+    let key = ''
+    if (typeof status.key === 'number') {
+      key = status.key.toString()
+      text = key
+    } else key = helper.checkSpecialChars(status.key) ? '' : status.key
+
+    let type = ''
+    if (status.type === 'error') {
+      type = 'danger' // to use with bootstrap
+    } else type = helper.checkSpecialChars(status.type) ? '' : status.type
+    let title = helper.checkSpecialChars(status.title) ? '' : status.title
+
+    el.appendChild(yo`<span
+      title="${title}"
+      class="${this.resolveClasses(key, type)}"
+      aria-hidden="true"
+    >
+    ${text}
+    </span>`)
+
+    el.classList.add(`${css.icon}`)
   }
 
   /**
diff --git a/src/app/tabs/analysis-tab.js b/src/app/tabs/analysis-tab.js
index 54cd001f05..b9f6301016 100644
--- a/src/app/tabs/analysis-tab.js
+++ b/src/app/tabs/analysis-tab.js
@@ -30,11 +30,11 @@ class AnalysisTab extends BaseApi {
     if (!this.staticanalysis) this.staticanalysis = new StaticAnalysis()
     this.staticanalysis.event.register('staticAnaysisWarning', (count) => {
       if (count > 0) {
-        this.events.emit('statusChanged', {key: count.toString(), title: count + ' warnings', type: 'warning'})
+        this.events.emit('statusChanged', {key: count, title: `${count} warning${count === 1 ? '' : 's'}`, type: 'warning'})
       } else if (count === 0) {
-        this.events.emit('statusChanged', {key: 'check', title: 'no warning', type: 'success'})
+        this.events.emit('statusChanged', {key: 'success', title: 'no warning', type: 'success'})
       } else {
-        this.events.emit('statusChanged', {key: '', title: '', type: ''})
+        this.events.emit('statusChanged', {key: 'none'})
       }
     })
     this.registry.put({api: this.staticanalysis, name: 'staticanalysis'})
diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index f59f11e905..6786c8c4e0 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -77,7 +77,7 @@ class CompileTab extends CompilerApi {
 
   listenToEvents () {
     let onContentChanged = () => {
-      this.events.emit('statusChanged', {key: 'code', title: 'the content has changed, needs recompilation', type: 'info'})
+      this.events.emit('statusChanged', {key: 'edited', title: 'the content has changed, needs recompilation', type: 'info'})
     }
     this.editor.event.register('contentChanged', onContentChanged)
     this.editor.event.register('sessionSwitched', onContentChanged)
@@ -87,7 +87,7 @@ class CompileTab extends CompilerApi {
     })
 
     this.compiler.event.register('compilerLoaded', () => {
-      this.events.emit('statusChanged', {key: '', title: '', type: ''})
+      this.events.emit('statusChanged', {key: 'none'})
     })
 
     this.compileTabLogic.event.on('startingCompilation', () => {
@@ -111,7 +111,7 @@ class CompileTab extends CompilerApi {
 
     const cleanupErrors = () => {
       this._view.errorContainer.innerHTML = ''
-      this.events.emit('statusChanged', {key: '', title: '', type: ''})
+      this.events.emit('statusChanged', {key: 'none'})
     }
 
     this.compiler.event.register('compilationFinished', (success, data, source) => {
@@ -120,11 +120,11 @@ class CompileTab extends CompilerApi {
         this.events.emit('compilationFinished', source.target, source, 'soljson', data)
         if (data.errors) {
           this.events.emit('statusChanged', {
-            key: data.errors.length.toString(),
-            title: 'compilation finished successful with warning' + data.errors.length > 1 ? 's' : '',
+            key: data.errors.length,
+            title: `compilation finished successful with warning${data.errors.length > 1 ? 's' : ''}`,
             type: 'warning'
           })
-        } else this.events.emit('statusChanged', {key: 'check', title: 'compilation successful', type: 'success'})
+        } else this.events.emit('statusChanged', {key: 'success', title: 'compilation successful', type: 'success'})
         // Store the contracts
         this.data.contractsDetails = {}
         this.compiler.visitContracts((contract) => {
@@ -135,8 +135,8 @@ class CompileTab extends CompilerApi {
           )
         })
       } else {
-        const count = (data.errors ? data.errors.filter(error => error.severity === 'error').length : 0 + data.error ? 1 : 0).toString()
-        this.events.emit('statusChanged', {key: count, title: 'compilation failed', type: 'danger'})
+        const count = (data.errors ? data.errors.filter(error => error.severity === 'error').length : 0 + data.error ? 1 : 0)
+        this.events.emit('statusChanged', {key: count, title: 'compilation failed', type: 'error'})
       }
       // Update contract Selection
       let contractMap = {}

From 66e1c95b3a904e30c5f44ce744abf9ed57c92e83 Mon Sep 17 00:00:00 2001
From: LianaHus <liana@ethdev.com>
Date: Thu, 2 May 2019 19:55:01 +0200
Subject: [PATCH 11/11] remove refresh on no fileselected

comment
---
 src/app/tabs/analysis-tab.js                 | 1 +
 src/app/tabs/compile-tab.js                  | 1 -
 src/app/tabs/compileTab/compilerContainer.js | 2 +-
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/app/tabs/analysis-tab.js b/src/app/tabs/analysis-tab.js
index b9f6301016..dde0a2762e 100644
--- a/src/app/tabs/analysis-tab.js
+++ b/src/app/tabs/analysis-tab.js
@@ -34,6 +34,7 @@ class AnalysisTab extends BaseApi {
       } else if (count === 0) {
         this.events.emit('statusChanged', {key: 'success', title: 'no warning', type: 'success'})
       } else {
+        // count ==-1 no compilation result
         this.events.emit('statusChanged', {key: 'none'})
       }
     })
diff --git a/src/app/tabs/compile-tab.js b/src/app/tabs/compile-tab.js
index 6786c8c4e0..1a6957d2f9 100644
--- a/src/app/tabs/compile-tab.js
+++ b/src/app/tabs/compile-tab.js
@@ -106,7 +106,6 @@ class CompileTab extends CompilerApi {
     this.fileManager.events.on('noFileSelected', () => {
       this.compilerContainer.currentFile = ''
       cleanupErrors()
-      onContentChanged()
     })
 
     const cleanupErrors = () => {
diff --git a/src/app/tabs/compileTab/compilerContainer.js b/src/app/tabs/compileTab/compilerContainer.js
index 6b6ba50c66..d3bbaef903 100644
--- a/src/app/tabs/compileTab/compilerContainer.js
+++ b/src/app/tabs/compileTab/compilerContainer.js
@@ -100,7 +100,7 @@ class CompilerContainer {
     var displayed = name === '' ? '<no file selected>' : name
     var el = yo`
     <div class="${css.compilerArticle}">
-      <button class="btn btn-primary btn-block" title="Compile" onclick="${this.compile.bind(this)}">
+      <button class="btn btn-primary btn-block ${name === '' ? 'disabled' : ''}" title="Compile" onclick="${this.compile.bind(this)}">
         <span>${this._view.compileIcon} Compile ${displayed}</span>
       </button>
     </div>`