From 60bb76a9945693c146b116e5430e117f8b93059a Mon Sep 17 00:00:00 2001 From: aniket-engg Date: Fri, 8 May 2020 13:52:20 +0530 Subject: [PATCH] module title and subtitle updated --- .../src/solidity-analyzer/modules/blockBlockhash.ts | 4 ++-- .../src/solidity-analyzer/modules/blockTimestamp.ts | 2 +- .../src/solidity-analyzer/modules/deleteDynamicArrays.ts | 4 ++-- .../src/solidity-analyzer/modules/deleteFromDynamicArray.ts | 2 +- .../src/solidity-analyzer/modules/guardConditions.ts | 2 +- .../src/solidity-analyzer/modules/intDivisionTruncate.ts | 2 +- remix-analyzer/src/solidity-analyzer/modules/lowLevelCalls.ts | 2 +- remix-analyzer/src/solidity-analyzer/modules/selfdestruct.ts | 2 +- remix-analyzer/src/solidity-analyzer/modules/txOrigin.ts | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/remix-analyzer/src/solidity-analyzer/modules/blockBlockhash.ts b/remix-analyzer/src/solidity-analyzer/modules/blockBlockhash.ts index 388883a032..f8b535f490 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/blockBlockhash.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/blockBlockhash.ts @@ -5,8 +5,8 @@ import { AnalyzerModule, ModuleAlgorithm, ModuleCategory, ReportObj, Compilation export default class blockBlockhash implements AnalyzerModule { warningNodes: FunctionCallAstNode[] = [] - name: string = `Blockhash usage: ` - description: string = `Semantics maybe unclear` + name: string = `Block hash: ` + description: string = `Can be influenced by miners` category: ModuleCategory = category.SECURITY algorithm: ModuleAlgorithm = algorithm.EXACT diff --git a/remix-analyzer/src/solidity-analyzer/modules/blockTimestamp.ts b/remix-analyzer/src/solidity-analyzer/modules/blockTimestamp.ts index b2f05e5f7d..bfb1781b24 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/blockTimestamp.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/blockTimestamp.ts @@ -8,7 +8,7 @@ export default class blockTimestamp implements AnalyzerModule { warningNowNodes: IdentifierAstNode[] = [] warningblockTimestampNodes: MemberAccessAstNode[] = [] name: string = `Block timestamp: ` - description: string = `Semantics maybe unclear` + description: string = `Can be influenced by miners` category: ModuleCategory = category.SECURITY algorithm: ModuleAlgorithm = algorithm.EXACT diff --git a/remix-analyzer/src/solidity-analyzer/modules/deleteDynamicArrays.ts b/remix-analyzer/src/solidity-analyzer/modules/deleteDynamicArrays.ts index 1e728a5444..859f6f09e9 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/deleteDynamicArrays.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/deleteDynamicArrays.ts @@ -5,8 +5,8 @@ import { AnalyzerModule, ModuleAlgorithm, ModuleCategory, ReportObj, Compilation export default class deleteDynamicArrays implements AnalyzerModule { rel: UnaryOperationAstNode[] = [] - name: string = `Delete on dynamic array: ` - description: string = `Use require/assert appropriately` + name: string = `Delete dynamic array: ` + description: string = `Use require/assert to ensure` category: ModuleCategory = category.GAS algorithm: ModuleAlgorithm = algorithm.EXACT diff --git a/remix-analyzer/src/solidity-analyzer/modules/deleteFromDynamicArray.ts b/remix-analyzer/src/solidity-analyzer/modules/deleteFromDynamicArray.ts index 37d12c4263..c92299a1e0 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/deleteFromDynamicArray.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/deleteFromDynamicArray.ts @@ -6,7 +6,7 @@ import { AnalyzerModule, ModuleAlgorithm, ModuleCategory, ReportObj, Compilation export default class deleteFromDynamicArray implements AnalyzerModule { relevantNodes: UnaryOperationAstNode[] = [] name: string = `Delete from dynamic array: ` - description: string = `'delete' on an array leaves a gap` + description: string = `'delete' leaves a gap in array` category: ModuleCategory = category.MISC algorithm: ModuleAlgorithm = algorithm.EXACT diff --git a/remix-analyzer/src/solidity-analyzer/modules/guardConditions.ts b/remix-analyzer/src/solidity-analyzer/modules/guardConditions.ts index 52982117d1..b360e68242 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/guardConditions.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/guardConditions.ts @@ -6,7 +6,7 @@ import { AnalyzerModule, ModuleAlgorithm, ModuleCategory, ReportObj, Compilation export default class guardConditions implements AnalyzerModule { guards: FunctionCallAstNode[] = [] name: string = `Guard conditions: ` - description: string = `Use 'require' and 'assert' appropriately` + description: string = `Ensure appropriate use of require/assert` category: ModuleCategory = category.MISC algorithm: ModuleAlgorithm = algorithm.EXACT diff --git a/remix-analyzer/src/solidity-analyzer/modules/intDivisionTruncate.ts b/remix-analyzer/src/solidity-analyzer/modules/intDivisionTruncate.ts index e211d565ff..fb9328a913 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/intDivisionTruncate.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/intDivisionTruncate.ts @@ -5,7 +5,7 @@ import { AnalyzerModule, ModuleAlgorithm, ModuleCategory, ReportObj, Compilation export default class intDivisionTruncate implements AnalyzerModule { warningNodes: BinaryOperationAstNode[] = [] - name: string = `Data Truncated: ` + name: string = `Data truncated: ` description: string = `Division on int/uint values truncates the result` category: ModuleCategory = category.MISC algorithm: ModuleAlgorithm = algorithm.EXACT diff --git a/remix-analyzer/src/solidity-analyzer/modules/lowLevelCalls.ts b/remix-analyzer/src/solidity-analyzer/modules/lowLevelCalls.ts index 0d7d362774..65f452589d 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/lowLevelCalls.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/lowLevelCalls.ts @@ -11,7 +11,7 @@ interface llcNode { export default class lowLevelCalls implements AnalyzerModule { llcNodes: llcNode[] = [] name: string = `Low level calls: ` - description: string = `Semantics maybe unclear` + description: string = `Should be last resort` category: ModuleCategory = category.SECURITY algorithm: ModuleAlgorithm = algorithm.EXACT diff --git a/remix-analyzer/src/solidity-analyzer/modules/selfdestruct.ts b/remix-analyzer/src/solidity-analyzer/modules/selfdestruct.ts index d623791e41..a5d621d588 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/selfdestruct.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/selfdestruct.ts @@ -6,7 +6,7 @@ import { AnalyzerModule, ModuleAlgorithm, ModuleCategory, ReportObj, ContractHLA export default class selfdestruct implements AnalyzerModule { name: string = `Selfdestruct: ` - description: string = `Beware of caller contracts` + description: string = `Dependent contracts can be inoperable` category: ModuleCategory = category.SECURITY algorithm: ModuleAlgorithm = algorithm.HEURISTIC diff --git a/remix-analyzer/src/solidity-analyzer/modules/txOrigin.ts b/remix-analyzer/src/solidity-analyzer/modules/txOrigin.ts index 99bd627eba..adcf5cb7dd 100644 --- a/remix-analyzer/src/solidity-analyzer/modules/txOrigin.ts +++ b/remix-analyzer/src/solidity-analyzer/modules/txOrigin.ts @@ -6,7 +6,7 @@ import { AnalyzerModule, ModuleAlgorithm, ModuleCategory, ReportObj, Compilation export default class txOrigin implements AnalyzerModule { txOriginNodes: MemberAccessAstNode[] = [] name: string = `Transaction origin: ` - description: string = `'tx.origin' is used` + description: string = `'tx.origin' used` category: ModuleCategory = category.SECURITY algorithm: ModuleAlgorithm = algorithm.EXACT