From e18a615d390594eb42a5d7733a056aacbb67fd00 Mon Sep 17 00:00:00 2001 From: yann300 Date: Thu, 26 Aug 2021 13:53:44 +0200 Subject: [PATCH 1/3] remove calling undefined function --- apps/remix-ide/src/app.js | 1 - 1 file changed, 1 deletion(-) diff --git a/apps/remix-ide/src/app.js b/apps/remix-ide/src/app.js index c2f52d9ade..da6aaaf976 100644 --- a/apps/remix-ide/src/app.js +++ b/apps/remix-ide/src/app.js @@ -521,6 +521,5 @@ Please make a backup of your contracts and start using http://remix.ethereum.org const framingService = new FramingService(sidePanel, menuicons, mainview, this._components.resizeFeature) if (params.embed) framingService.embed() - if (params.code) framingService.code() framingService.start(params) } From 9382b70180571e315d5280346113d6194b25fdb6 Mon Sep 17 00:00:00 2001 From: yann300 Date: Thu, 26 Aug 2021 12:35:54 +0200 Subject: [PATCH 2/3] add item.id in the payload to matomo --- .../file-explorer/src/lib/file-explorer-context-menu.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx b/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx index 3d85829294..bc8014f167 100644 --- a/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx +++ b/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx @@ -108,7 +108,7 @@ export const FileExplorerContextMenu = (props: FileExplorerContextMenuProps) => deletePath(getPath()) break default: - _paq.push(['trackEvent', 'fileExplorer', 'customAction', item.name]) + _paq.push(['trackEvent', 'fileExplorer', 'customAction', `${item.id}${item.name}`]) emit && emit({ ...item, path: [path] } as customAction) break } From 53d8d3e27d54a7218147a9997ecba50186c3799a Mon Sep 17 00:00:00 2001 From: yann300 Date: Thu, 26 Aug 2021 12:39:26 +0200 Subject: [PATCH 3/3] add separator --- .../file-explorer/src/lib/file-explorer-context-menu.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx b/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx index bc8014f167..53dbddde3d 100644 --- a/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx +++ b/libs/remix-ui/file-explorer/src/lib/file-explorer-context-menu.tsx @@ -108,7 +108,7 @@ export const FileExplorerContextMenu = (props: FileExplorerContextMenuProps) => deletePath(getPath()) break default: - _paq.push(['trackEvent', 'fileExplorer', 'customAction', `${item.id}${item.name}`]) + _paq.push(['trackEvent', 'fileExplorer', 'customAction', `${item.id}/${item.name}`]) emit && emit({ ...item, path: [path] } as customAction) break }