From 635c15c52b4ffb0a33fec03d79792e407d6094c1 Mon Sep 17 00:00:00 2001 From: filip mertens Date: Mon, 19 Sep 2022 11:06:58 +0200 Subject: [PATCH] no flaky --- .circleci/config.yml | 2 +- apps/remix-ide-e2e/src/commands/noWorkerErrorFor.ts | 1 - apps/remix-ide-e2e/src/tests/url.test.ts | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bc3d384adc..dd7381131d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -3,7 +3,7 @@ version: 2.1 parameters: run_flaky_tests: type: boolean - default: true + default: false orbs: browser-tools: circleci/browser-tools@1.4.0 node: circleci/node@5.0.2 diff --git a/apps/remix-ide-e2e/src/commands/noWorkerErrorFor.ts b/apps/remix-ide-e2e/src/commands/noWorkerErrorFor.ts index ffc05a0b50..c9364c2552 100644 --- a/apps/remix-ide-e2e/src/commands/noWorkerErrorFor.ts +++ b/apps/remix-ide-e2e/src/commands/noWorkerErrorFor.ts @@ -16,7 +16,6 @@ class NoWorkerErrorFor extends EventEmitter { function noWorkerErrorFor (browser: NightwatchBrowser, version: string, callback: VoidFunction) { browser .setSolidityCompilerVersion(version) - .saveScreenshot(`./reports/screenhots/${version}.png`) .click('*[data-id="compilerContainerCompileBtn"]') .waitForElementPresent('*[data-id="compilationFinishedWith_' + version + '"]', 60000) .notContainsText('*[data-id="compiledErrors"]', `Worker error: Uncaught NetworkError: Failed to execute 'importScripts' on 'WorkerGlobalScope': The script at 'https://binaries.soliditylang.org/wasm/${version}' failed to load.`) diff --git a/apps/remix-ide-e2e/src/tests/url.test.ts b/apps/remix-ide-e2e/src/tests/url.test.ts index 2541b38af6..a73a449465 100644 --- a/apps/remix-ide-e2e/src/tests/url.test.ts +++ b/apps/remix-ide-e2e/src/tests/url.test.ts @@ -156,7 +156,7 @@ module.exports = { }) }, - 'Should select deploy with proxy option from URL params #group2 #flaky': function (browser: NightwatchBrowser) { + 'Should select deploy with proxy option from URL params #group2': function (browser: NightwatchBrowser) { browser .url('http://127.0.0.1:8080/#optimize=false&runs=200&deployProxy=true') .refresh()