From 62747b5fbebf6d162b865ac49d3dea3f56e06927 Mon Sep 17 00:00:00 2001 From: aniket-engg Date: Wed, 8 Sep 2021 19:24:44 +0530 Subject: [PATCH 1/2] hardhat compilation with error and result fixed --- libs/remixd/src/services/hardhatClient.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libs/remixd/src/services/hardhatClient.ts b/libs/remixd/src/services/hardhatClient.ts index 217a934e2d..b62258251a 100644 --- a/libs/remixd/src/services/hardhatClient.ts +++ b/libs/remixd/src/services/hardhatClient.ts @@ -37,10 +37,11 @@ export class HardhatClient extends PluginClient { result += msg + '\n' }) child.stderr.on('data', (err) => { - error += `[Hardhat Compilation]: ${err.toString()}` + error += `[Hardhat Compilation]: ${err.toString()} \n` }) child.on('close', () => { - if (error) reject(error) + if (error && result) resolve(error + result) + else if (error) reject(error) else resolve(result) }) }) From 3b3ad46383959e7e921b0679a368556866a8cecc Mon Sep 17 00:00:00 2001 From: aniket-engg Date: Wed, 8 Sep 2021 19:37:32 +0530 Subject: [PATCH 2/2] linting fix --- libs/remixd/src/services/hardhatClient.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/remixd/src/services/hardhatClient.ts b/libs/remixd/src/services/hardhatClient.ts index b62258251a..62400debda 100644 --- a/libs/remixd/src/services/hardhatClient.ts +++ b/libs/remixd/src/services/hardhatClient.ts @@ -40,7 +40,7 @@ export class HardhatClient extends PluginClient { error += `[Hardhat Compilation]: ${err.toString()} \n` }) child.on('close', () => { - if (error && result) resolve(error + result) + if (error && result) resolve(error + result) else if (error) reject(error) else resolve(result) })