minin sidepanel embed

apps/remix-ide/src/app.js

@@ -221,7 +221,6 @@ class AppComponent {
 
     // LAYOUT & SYSTEM VIEWS
     const appPanel = new MainPanel()
-  
     Registry.getInstance().put({ api: self.mainview, name: 'mainview' })
     const tabProxy = new TabProxy(fileManager, editor)
     self.engine.register([appPanel, tabProxy])

apps/remix-ide/src/framingService.js

@@ -1,30 +0,0 @@
-export class FramingService {
-  constructor (verticalIcons, layout) {
-    this.verticalIcons = verticalIcons
-  }
-
-  start (params) {
-    this.verticalIcons.select('filePanel')
-
-    document.addEventListener('keypress', (e) => {
-      if (e.shiftKey && e.ctrlKey) {
-        if (e.code === 'KeyF') { // Ctrl+Shift+F
-          this.verticalIcons.select('filePanel')
-        } else if (e.code === 'KeyA') { // Ctrl+Shift+A
-          this.verticalIcons.select('pluginManager')
-        } else if (e.code === 'KeyS') { //  Ctrl+Shift+S
-          this.verticalIcons.select('settings')
-        }
-        e.preventDefault()
-      }
-    })
-
-    if (params.minimizeterminal) this.mainView.minimizeTerminal()
-    if (params.minimizesidepanel) this.resizeFeature.hidePanel()
-  }
-
-  embed () {
-    this.mainView.minimizeTerminal()
-    this.resizeFeature.hidePanel()
-  }
-}

libs/remix-ui/app/src/lib/remix-app/remix-app.tsx

@@ -60,6 +60,13 @@ const RemixApp = (props: IRemixAppUi) => {
     props.app.sidePanel.events.on('showing', () => {
       setHideSidePanel(false)
     })
+
+    props.app.layout.event.on('minimizesidepanel', () => {
+      // the 'showing' event always fires from sidepanel, so delay this a bit
+      setTimeout(() => {
+        setHideSidePanel(true)
+      }, 1000)
+    })
   }
 
   const components = {

libs/remix-ui/terminal/src/lib/remix-ui-terminal.tsx

@@ -87,15 +87,10 @@ export const RemixUiTerminal = (props: RemixUiTerminalProps) => {
     props.onReady({
       logHtml: (html) => {
         scriptRunnerDispatch({ type: 'html', payload: { message: [html.innerText] } })
-
-        setTimeout(() => {
-        }, 100)
       },
 
       log: (message) => {
-        setTimeout(() => {
-          scriptRunnerDispatch({ type: 'log', payload: { message: [message] } })
-        }, 100)
+        scriptRunnerDispatch({ type: 'log', payload: { message: [message] } })
       }
     })
   }, [])